[PATCH] mm/debug: fix missing space in case statement

[PATCH] mm/debug: fix missing space in case statement

[Zhang Chujun]

In the setup_vm_debug() function, the case statement for 'p' option
is written as 'case'p':' without a space between 'case' and the
character constant. While this is syntactically valid C, it violates
the Linux kernel coding style, which requires a space after 'case'.
This patch adds the missing space to comply with coding standards.

Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>

diff --git a/mm/debug.c b/mm/debug.c
index 64ddb0c4b4be..d860864063be 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -327,7 +327,7 @@ static int __init setup_vm_debug(char *str)
 
 	while (*str) {
 		switch (tolower(*str)) {
-		case'p':
+		case 'p':
 			__page_init_poisoning = true;
 			break;
 		default:
-- 
2.50.1.windows.1

Re: [PATCH] mm/debug: fix missing space in case statement

[Dev Jain]

On 03/11/25 12:29 pm, Zhang Chujun wrote:
> In the setup_vm_debug() function, the case statement for 'p' option
> is written as 'case'p':' without a space between 'case' and the
> character constant. While this is syntactically valid C, it violates
> the Linux kernel coding style, which requires a space after 'case'.
> This patch adds the missing space to comply with coding standards.
>
> Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>

Reviewed-by: Dev Jain <dev.jain@arm.com>

Re: [PATCH] mm/debug: fix missing space in case statement

[Vlastimil Babka]

On 11/3/25 07:59, Zhang Chujun wrote:
> In the setup_vm_debug() function, the case statement for 'p' option
> is written as 'case'p':' without a space between 'case' and the
> character constant. While this is syntactically valid C, it violates
> the Linux kernel coding style, which requires a space after 'case'.
> This patch adds the missing space to comply with coding standards.
> 
> Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> 
> diff --git a/mm/debug.c b/mm/debug.c
> index 64ddb0c4b4be..d860864063be 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -327,7 +327,7 @@ static int __init setup_vm_debug(char *str)
>  
>  	while (*str) {
>  		switch (tolower(*str)) {
> -		case'p':
> +		case 'p':
>  			__page_init_poisoning = true;
>  			break;
>  		default:

Re: [PATCH] mm/debug: fix missing space in case statement

[David Hildenbrand]

On 03.11.25 07:59, Zhang Chujun wrote:
> In the setup_vm_debug() function, the case statement for 'p' option
> is written as 'case'p':' without a space between 'case' and the
> character constant. While this is syntactically valid C, it violates
> the Linux kernel coding style, which requires a space after 'case'.
> This patch adds the missing space to comply with coding standards.
> 
> Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>
> 
> diff --git a/mm/debug.c b/mm/debug.c
> index 64ddb0c4b4be..d860864063be 100644
> --- a/mm/debug.c
> +++ b/mm/debug.c
> @@ -327,7 +327,7 @@ static int __init setup_vm_debug(char *str)
>   
>   	while (*str) {
>   		switch (tolower(*str)) {
> -		case'p':
> +		case 'p':

Acked-by: David Hildenbrand <david@redhat.com>

Surprised that this compiles.

-- 
Cheers

David

Re: [PATCH] mm/debug: fix missing space in case statement

[Vishal Moola (Oracle)]

On Mon, Nov 03, 2025 at 02:59:09PM +0800, Zhang Chujun wrote:
> In the setup_vm_debug() function, the case statement for 'p' option
> is written as 'case'p':' without a space between 'case' and the
> character constant. While this is syntactically valid C, it violates
> the Linux kernel coding style, which requires a space after 'case'.
> This patch adds the missing space to comply with coding standards.
> 
> Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>

Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>