From: YoungJun Park <youngjun.park@lge.com>
To: Chris Li <chrisl@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Kemeng Shi <shikemeng@huaweicloud.com>,
Kairui Song <kasong@tencent.com>, Nhat Pham <nphamcs@gmail.com>,
Baoquan He <bhe@redhat.com>, Barry Song <baohua@kernel.org>
Subject: Re: [PATCH] mm: swap: remove duplicate nr_swap_pages decrement in get_swap_page_of_type()
Date: Sun, 2 Nov 2025 17:26:37 +0900 [thread overview]
Message-ID: <aQcVvSMxHtvYZCa9@yjaykim-PowerEdge-T330> (raw)
In-Reply-To: <CACePvbV=Br5yiaXOdyC43Dz+6eUV6GfyxqCsGPG0e6kggT84ig@mail.gmail.com>
On Sat, Nov 01, 2025 at 12:12:44PM -0700, Chris Li wrote:
> On Sat, Nov 1, 2025 at 6:42 AM Youngjun Park <youngjun.park@lge.com> wrote:
> >
> > After commit 4f78252da887, nr_swap_pages is decremented in
> > swap_range_alloc(). Since cluster_alloc_swap_entry() calls
> > swap_range_alloc() internally, the decrement in get_swap_page_of_type()
> > causes double-decrementing.
> >
> > Remove the duplicate decrement.
>
> Acked-by: Chris Li <chrisl@kernel.org>
>
> Thanks for the good catch. Indeed there is duplication, but only
> affects the hibernation usage of swap as far as I can tell.
> This bug is in v6.17-rc1 upwards including v6.17 as well. You might
> want to add the stable tag:
>
> Cc: stable@vger.kernel.org # v6.17-rc1
I add the Cc tag on v2 patch
Thank you for review
Best Regards,
Youngjun Park
next prev parent reply other threads:[~2025-11-02 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-01 13:41 Youngjun Park
2025-11-01 19:12 ` Chris Li
2025-11-02 8:26 ` YoungJun Park [this message]
2025-11-01 20:55 ` Barry Song
2025-11-02 8:28 ` YoungJun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQcVvSMxHtvYZCa9@yjaykim-PowerEdge-T330 \
--to=youngjun.park@lge.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=kasong@tencent.com \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox