From: Matthew Wilcox <willy@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Kiryl Shutsemau <kirill@shutemov.name>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Rik van Riel <riel@surriel.com>,
Harry Yoo <harry.yoo@oracle.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Dave Chinner <david@fromorbit.com>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/2] mm/memory: Do not populate page table entries beyond i_size
Date: Sat, 1 Nov 2025 05:00:47 +0000 [thread overview]
Message-ID: <aQWT_6cXWAcjZYON@casper.infradead.org> (raw)
In-Reply-To: <9e2750bf-7945-cc71-b9b3-632f03d89a55@google.com>
On Wed, Oct 29, 2025 at 02:45:52AM -0700, Hugh Dickins wrote:
> But you're giving yourself too hard a time of backporting with your
> 5.10 Fixee 01c70267053d for 1/2: the only filesystem which set the
> flag then was tmpfs, which you're now excepting. The flag got
> renamed later (in 5.16) and then in 5.17 at last there was another
> filesystem to set it. So, this 1/2 would be
>
> Fixes: 6795801366da ("xfs: Support large folios")
I haven't been able to keep up with this patchset -- sorry.
But this problem didn't exist until bs>PS support was added because we
would never add a folio to the page cache which extended beyond i_size
before. We'd shrink the folio order allocated in do_page_cache_ra()
(actually, we still do, but page_cache_ra_unbounded() rounds it up
again). So it doesn't fix that commit at all, but something far more
recent.
next prev parent reply other threads:[~2025-11-01 5:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 11:56 [PATCHv3 0/2] Fix SIGBUS semantics with large folios Kiryl Shutsemau
2025-10-27 11:56 ` [PATCHv3 1/2] mm/memory: Do not populate page table entries beyond i_size Kiryl Shutsemau
2025-10-27 22:33 ` Andrew Morton
2025-10-28 10:23 ` Kiryl Shutsemau
2025-10-29 9:45 ` Hugh Dickins
2025-10-29 10:23 ` Kiryl Shutsemau
2025-11-01 4:17 ` Andrew Morton
2025-11-01 5:00 ` Matthew Wilcox [this message]
2025-11-03 10:59 ` Kiryl Shutsemau
2025-11-03 14:35 ` Matthew Wilcox
2025-11-03 15:18 ` Kiryl Shutsemau
2025-10-27 11:56 ` [PATCHv3 2/2] mm/truncate: Unmap large folio on split failure Kiryl Shutsemau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQWT_6cXWAcjZYON@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=david@fromorbit.com \
--cc=david@redhat.com \
--cc=djwong@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox