Re: [PATCH 4/5] mm: swap: change swap_alloc_slow() to void

[YoungJun Park <youngjun.park@lge.com>]

On Thu, Oct 30, 2025 at 12:13:20AM +0800, Kairui Song wrote:
> On Wed, Oct 29, 2025 at 05:56:58PM +0800, Youngjun Park wrote:
> > swap_alloc_slow() does not need to return a bool, as all callers
> > handle allocation results via the entry parameter. Update the
> > function signature and remove return statements accordingly.
> > 
> > Signed-off-by: Youngjun Park <youngjun.park@lge.com>
> > ---
> >  mm/swapfile.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> > 
> > diff --git a/mm/swapfile.c b/mm/swapfile.c
> > index b5d42918c01b..89eb57eee7f7 100644
> > --- a/mm/swapfile.c
> > +++ b/mm/swapfile.c
> > @@ -1339,7 +1339,7 @@ static bool swap_alloc_fast(swp_entry_t *entry,
> >  }
> >  
> >  /* Rotate the device and switch to a new cluster */
> > -static bool swap_alloc_slow(swp_entry_t *entry,
> > +static void swap_alloc_slow(swp_entry_t *entry,
> >  			    int order)
> >  {
> >  	unsigned long offset;
> > @@ -1356,10 +1356,10 @@ static bool swap_alloc_slow(swp_entry_t *entry,
> >  			put_swap_device(si);
> >  			if (offset) {
> >  				*entry = swp_entry(si->type, offset);
> > -				return true;
> > +				return;
> >  			}
> >  			if (order)
> > -				return false;
> > +				return;
> >  		}
> >  
> >  		spin_lock(&swap_avail_lock);
> > @@ -1378,7 +1378,6 @@ static bool swap_alloc_slow(swp_entry_t *entry,
> >  			goto start_over;
> >  	}
> >  	spin_unlock(&swap_avail_lock);
> > -	return false;
> >  }
> >  
> 
> Hi Youngjun,
> 
> Thanks for the patch.
> 
> I just found a patch from mine series is doing the same thing:
> https://lore.kernel.org/linux-mm/20251029-swap-table-p2-v1-15-3d43f3b6ec32@tencent.com/
> 
> I'm fine merging your cleanup first, the conflict is really trivial and easy to resolve.
> 
> So:
> 
> Reviewed-by: Kairui Song <kasong@tencent.com>
> 
 
Hello Kairui,

Ah, I see you're working on the same area! Thanks for the review and
for being flexible about the merge order. Much appreciated!

Best,
Youngjun Park