linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Harry Yoo <harry.yoo@oracle.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	"Liam R . Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH V1 1/2] MAINTAINERS: add include/linux/pgalloc.h to MM CORE section
Date: Mon, 20 Oct 2025 23:10:58 +0900	[thread overview]
Message-ID: <aPZC8qhvSUJDZJKY@hyeyoo> (raw)
In-Reply-To: <ee54f8e1-0b1c-4db6-9773-7b30d18c0515@lucifer.local>

On Mon, Oct 20, 2025 at 03:05:52PM +0100, Lorenzo Stoakes wrote:
> On Mon, Oct 20, 2025 at 04:43:33PM +0900, Harry Yoo wrote:
> > On Sun, Oct 19, 2025 at 03:07:36PM -0700, SeongJae Park wrote:
> > > On Sun, 19 Oct 2025 16:25:08 +0900 Harry Yoo <harry.yoo@oracle.com> wrote:
> > >
> > > > Since include/linux/pgtable.h is already listed in the MM CORE section,
> > > > add it to the section as well to keep it maintained by the appropriate
> > > > maintainers.
> > > >
> > > > Signed-off-by: Harry Yoo <harry.yoo@oracle.com>
> 
> Thanks for adding, but please put before pgtable.h to fix the checkpatch
> warning.
> 
> With that done:
> 
> Acked-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> 
> > >
> > > Acked-by: SeongJae Park <sj@kernel.org>
> >
> > Thanks!
> >
> > > > ---
> > > >  MAINTAINERS | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 46126ce2f968..dedb9525c2bc 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -16249,6 +16249,7 @@ F:	include/linux/mmdebug.h
> > > >  F:	include/linux/mmu_notifier.h
> > > >  F:	include/linux/pagewalk.h
> > > >  F:	include/linux/pgtable.h
> > > > +F:	include/linux/pgalloc.h
> > >
> > > Nit.  Should we alphabetically sort?
> >
> > TBH I have no idea.
> >
> > I thought only subsystem names should be alphabetically sorted?
> 
> No it's files too, checkpatch will tell you:
> 
>    ● checkpatch.pl: 262: WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order

*blaming myself for not running checkpatch*

Thanks, will fix it!

-- 
Cheers,
Harry / Hyeonggon


  reply	other threads:[~2025-10-20 14:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-19  7:25 [PATCH V1 0/2] mm: MISC follow-up patches for linux/pgalloc.h Harry Yoo
2025-10-19  7:25 ` [PATCH V1 1/2] MAINTAINERS: add include/linux/pgalloc.h to MM CORE section Harry Yoo
2025-10-19 22:07   ` SeongJae Park
2025-10-20  7:43     ` Harry Yoo
2025-10-20 13:38       ` David Hildenbrand
2025-10-20 13:51         ` Harry Yoo
2025-10-20 14:07           ` David Hildenbrand
2025-10-20 14:05       ` Lorenzo Stoakes
2025-10-20 14:10         ` Harry Yoo [this message]
2025-10-20 14:34   ` Mike Rapoport
2025-10-19  7:25 ` [PATCH V1 2/2] treewide: include linux/pgalloc.h instead of asm/pgalloc.h Harry Yoo
2025-10-20 13:39   ` David Hildenbrand
2025-10-20 14:12   ` Lorenzo Stoakes
2025-10-20 14:44   ` Mike Rapoport
2025-10-21  5:09     ` Harry Yoo
2025-10-21  6:07       ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPZC8qhvSUJDZJKY@hyeyoo \
    --to=harry.yoo@oracle.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rppt@kernel.org \
    --cc=sj@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox