From: Uladzislau Rezki <urezki@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Uladzislau Rezki <urezki@gmail.com>, Baoquan He <bhe@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH mm-unstable] vmalloc: Separate gfp_mask adjunctive parentheses in __vmalloc_node_noprof() kernel-doc comment
Date: Mon, 20 Oct 2025 11:52:36 +0200 [thread overview]
Message-ID: <aPYGZBYTBoAEYjAK@milan> (raw)
In-Reply-To: <20251020044933.15222-1-bagasdotme@gmail.com>
On Mon, Oct 20, 2025 at 11:49:33AM +0700, Bagas Sanjaya wrote:
> Sphinx reports htmldocs warning on __vmalloc_node() comment:
>
> Documentation/core-api/mm-api:52: ./mm/vmalloc.c:4036: WARNING: Inline strong start-string without end-string. [docutils]
>
> Fix it by separating adjunctive parentheses from preceding gfp_mask
> formatting markup.
>
> Fixes: 32904ba6f5ef ("vmalloc: update __vmalloc_node_noprof() documentation")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/linux-next/20251020134902.3a11107e@canb.auug.org.au/
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> mm/vmalloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index e207ca64a688ee..091a07f6d92524 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -4034,7 +4034,7 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align,
> * Allocate enough pages to cover @size from the page level allocator with
> * @gfp_mask flags. Map them into contiguous kernel virtual space.
> *
> - * Semantics of @gfp_mask(including reclaim/retry modifiers such as
> + * Semantics of @gfp_mask (including reclaim/retry modifiers such as
> * __GFP_NOFAIL) are the same as in __vmalloc_node_range_noprof().
> *
> * Return: pointer to the allocated memory or %NULL on error
> --
> An old man doll... just what I always wanted! - Clara
>
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Thank you!
--
Uladzislau Rezki
prev parent reply other threads:[~2025-10-20 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 4:49 Bagas Sanjaya
2025-10-20 9:52 ` Uladzislau Rezki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPYGZBYTBoAEYjAK@milan \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox