From: Matthew Wilcox <willy@infradead.org>
To: Huiwen He <hehuiwen@kylinos.cn>
Cc: markus.elfring@web.de, Liam.Howlett@oracle.com,
aliceryhl@google.com, andrewjballance@gmail.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
maple-tree@lists.infradead.org
Subject: Re: [PATCH] maple_tree: Fix potential NULL pointer dereference if mas_pop_node() fails
Date: Sun, 19 Oct 2025 21:14:33 +0100 [thread overview]
Message-ID: <aPVGqRKFcI1SjZdk@casper.infradead.org> (raw)
In-Reply-To: <20251019114916.1618642-1-hehuiwen@kylinos.cn>
On Sun, Oct 19, 2025 at 07:49:16PM +0800, Huiwen He wrote:
> Hi Markus,
>
> Thanks for your suggestion.
> The commit description could be improved to better follow the imperative style.
> I'll update it in the later version (maybe v2).
Do not send a v2 until somebody has a substantive comment. I suspect
that what you are doing here is wrong, but I lack the understanding to
explain why it is wrong.
next prev parent reply other threads:[~2025-10-19 20:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 15:23 Huiwen He
2025-10-18 16:38 ` Markus Elfring
2025-10-19 0:32 ` Matthew Wilcox
2025-10-19 11:49 ` Huiwen He
2025-10-19 20:14 ` Matthew Wilcox [this message]
2025-10-21 14:19 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPVGqRKFcI1SjZdk@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=hehuiwen@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=markus.elfring@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox