From: Matthew Wilcox <willy@infradead.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Huiwen He <hehuiwen@kylinos.cn>,
maple-tree@lists.infradead.org, linux-mm@kvack.org,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Andrew Ballance <andrewjballance@gmail.com>
Subject: Re: [PATCH] maple_tree: Fix potential NULL pointer dereference if mas_pop_node() fails
Date: Sun, 19 Oct 2025 01:32:04 +0100 [thread overview]
Message-ID: <aPQxhMH0CSZm86Lk@casper.infradead.org> (raw)
In-Reply-To: <9092f8af-72d9-472e-8d5c-f950c8ce782d@web.de>
On Sat, Oct 18, 2025 at 06:38:11PM +0200, Markus Elfring wrote:
> > mas_pop_node() may return NULL when memory allocation fails or when
> > mas->sheaf is invalid. Several callers of mas_pop_node() did not check
> > the return value and directly dereferenced the pointer, which could
> > lead to a NULL pointer dereference and kernel crash.
>
> Will another imperative wording approach become more helpful for an improved
> change description?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc1#n94
Markus, stop this. You've been told before.
next prev parent reply other threads:[~2025-10-19 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-18 15:23 Huiwen He
2025-10-18 16:38 ` Markus Elfring
2025-10-19 0:32 ` Matthew Wilcox [this message]
2025-10-19 11:49 ` Huiwen He
2025-10-19 20:14 ` Matthew Wilcox
2025-10-21 14:19 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPQxhMH0CSZm86Lk@casper.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=aliceryhl@google.com \
--cc=andrewjballance@gmail.com \
--cc=hehuiwen@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox