linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: YoungJun Park <youngjun.park@lge.com>
To: Chris Li <chrisl@kernel.org>
Cc: Baoquan He <bhe@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, kasong@tencent.com, baohua@kernel.org,
	nphamcs@gmail.com, shikemeng@huaweicloud.com
Subject: Re: [PATCH 3/3] mm/swap: remove unneeded swap_active_head
Date: Fri, 10 Oct 2025 11:56:29 +0900	[thread overview]
Message-ID: <aOh13R8OwgnGNryo@yjaykim-PowerEdge-T330> (raw)
In-Reply-To: <CACePvbVV7b+o4x04JS_SiQv1f8=gZv-fr-EhFT=AjkEsfg35qw@mail.gmail.com>

On Thu, Oct 09, 2025 at 10:09:56AM -0700, Chris Li wrote:
> Hi Baoquan,
> 
> On Thu, Oct 9, 2025 at 12:47 AM Baoquan He <bhe@redhat.com> wrote:
> >
> > By the way, Chris worried the plist swap_active_head could be reused by
> > the ongoing swap-tier work and suggested to hold off this patchset till
> > swap-tier work is clear. Now seems it won't impact swap-tier, I will
> > send a v2 against mm-new.
> 
> Sorry I haven't made it clear earlier. I withdraw the NACK because
> that is my misunderstanding of the code behavior. It does not mean I
> clear the swap tiers will not use swap_active_head yet, I actually
> haven't done that investigation.
> 
> I still suggest deferring this series which deletes the
> "swap_active_head". Wait until YoungPark's swap tiers to be sent out

Thanks Chris. 
"swap_active_head" is used on my current working patch.

> on the list. Let's wait for about 1 month or so, we should have a much

Yes, I am on the construct writing swap tier RFC.
it takes a few weeks to share on LKML.

> better understanding if the swap tiers series needs to use the
> "swap_active_head". We are not in a hurry to remove it, right? The
> earliest this can go into the official tree is 6.19 anyway. We still
> have some time.
> YoungPark, do you know if you want to use "swap_active_head" in your

On current version of my patch, I use "swap_active_head" 
on swap_tier assignment logic when traversing current swapfile.
It is efficient to use "swap_active_head" on traversing the swapfile 
in priority order.

I think about more on this part.

> pending patch series? Even better send your pending RFC patches to the
> list and Baoquan can collaborate on it.

As mentioned above, share it a few weeks later.

Thanks,
Youngjun Park


  reply	other threads:[~2025-10-10  2:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01  4:34 [PATCH 0/3] mm/swap: remove plist swap_active_head Baoquan He
2025-10-01  4:34 ` [PATCH 1/3] mm/swapfile.c: remove __has_usable_swap() Baoquan He
2025-10-01  4:34 ` [PATCH 2/3] mm/swapfile.c: use swap_info[] to find the swap device Baoquan He
2025-10-02 15:59   ` Chris Li
2025-10-03  2:38     ` Baoquan He
2025-10-03  4:50       ` Chris Li
2025-10-03  5:29         ` Baoquan He
2025-10-01  4:34 ` [PATCH 3/3] mm/swap: remove unneeded swap_active_head Baoquan He
2025-10-02  8:33   ` Chris Li
2025-10-02 13:42     ` Baoquan He
2025-10-09  3:26   ` Andrew Morton
2025-10-09  7:47     ` Baoquan He
2025-10-09 17:09       ` Chris Li
2025-10-10  2:56         ` YoungJun Park [this message]
2025-10-10  1:28       ` Andrew Morton
2025-10-10  2:14         ` Baoquan He
2025-10-10  2:34           ` Chris Li
2025-10-10  2:33         ` Chris Li
2025-10-10  2:52         ` Chris Li
2025-10-02  6:04 ` [PATCH 0/3] mm/swap: remove plist swap_active_head Chris Li
2025-10-02 13:09   ` Baoquan He
2025-10-02 16:23     ` Chris Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOh13R8OwgnGNryo@yjaykim-PowerEdge-T330 \
    --to=youngjun.park@lge.com \
    --cc=akpm@linux-foundation.org \
    --cc=baohua@kernel.org \
    --cc=bhe@redhat.com \
    --cc=chrisl@kernel.org \
    --cc=kasong@tencent.com \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox