* Re: [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN
2025-10-06 1:49 [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN Fushuai Wang
@ 2025-10-06 6:46 ` David Hildenbrand
2025-10-06 12:46 ` Matthew Wilcox
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2025-10-06 6:46 UTC (permalink / raw)
To: Fushuai Wang, akpm, hannes, mhocko, zhengqi.arch, shakeel.butt,
lorenzo.stoakes, axelrasmussen, yuanchu, weixugc
Cc: linux-mm, linux-kernel
On 06.10.25 03:49, Fushuai Wang wrote:
> The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
> 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
> remove the redundant __GFP_NOWARN flag.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN
2025-10-06 1:49 [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN Fushuai Wang
2025-10-06 6:46 ` David Hildenbrand
@ 2025-10-06 12:46 ` Matthew Wilcox
2025-10-06 19:46 ` Shakeel Butt
2025-10-13 10:52 ` Lorenzo Stoakes
3 siblings, 0 replies; 5+ messages in thread
From: Matthew Wilcox @ 2025-10-06 12:46 UTC (permalink / raw)
To: Fushuai Wang
Cc: akpm, hannes, david, mhocko, zhengqi.arch, shakeel.butt,
lorenzo.stoakes, axelrasmussen, yuanchu, weixugc, linux-mm,
linux-kernel
On Mon, Oct 06, 2025 at 09:49:48AM +0800, Fushuai Wang wrote:
> The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
> 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
> remove the redundant __GFP_NOWARN flag.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN
2025-10-06 1:49 [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN Fushuai Wang
2025-10-06 6:46 ` David Hildenbrand
2025-10-06 12:46 ` Matthew Wilcox
@ 2025-10-06 19:46 ` Shakeel Butt
2025-10-13 10:52 ` Lorenzo Stoakes
3 siblings, 0 replies; 5+ messages in thread
From: Shakeel Butt @ 2025-10-06 19:46 UTC (permalink / raw)
To: Fushuai Wang
Cc: akpm, hannes, david, mhocko, zhengqi.arch, lorenzo.stoakes,
axelrasmussen, yuanchu, weixugc, linux-mm, linux-kernel
On Mon, Oct 06, 2025 at 09:49:48AM +0800, Fushuai Wang wrote:
> The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
> 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
> remove the redundant __GFP_NOWARN flag.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN
2025-10-06 1:49 [PATCH v2] mm/vmscan: Remove redundant __GFP_NOWARN Fushuai Wang
` (2 preceding siblings ...)
2025-10-06 19:46 ` Shakeel Butt
@ 2025-10-13 10:52 ` Lorenzo Stoakes
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Stoakes @ 2025-10-13 10:52 UTC (permalink / raw)
To: Fushuai Wang
Cc: akpm, hannes, david, mhocko, zhengqi.arch, shakeel.butt,
axelrasmussen, yuanchu, weixugc, linux-mm, linux-kernel
On Mon, Oct 06, 2025 at 09:49:48AM +0800, Fushuai Wang wrote:
> The __GFP_NOWARN flag was included in GFP_NOWAIT since commit
> 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT"). So
> remove the redundant __GFP_NOWARN flag.
>
> Signed-off-by: Fushuai Wang <wangfushuai@baidu.com>
LGTM, so:
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> mm/vmscan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index b2fc8b626d3d..e7ecf3b608cf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1054,7 +1054,7 @@ static unsigned int demote_folio_list(struct list_head *demote_folios,
> * When this happens, 'page' will likely just be discarded
> * instead of migrated.
> */
> - .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) | __GFP_NOWARN |
> + .gfp_mask = (GFP_HIGHUSER_MOVABLE & ~__GFP_RECLAIM) |
> __GFP_NOMEMALLOC | GFP_NOWAIT,
> .nid = target_nid,
> .nmask = &allowed_mask,
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread