linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Itamar Dalal <dalalitamar@gmail.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"lorenzo.stoakes@oracle.com" <lorenzo.stoakes@oracle.com>,
	"riel@surriel.com" <riel@surriel.com>,
	"Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>,
	"vbabka@suse.cz" <vbabka@suse.cz>,
	"harry.yoo@oracle.com" <harry.yoo@oracle.com>,
	"jannh@google.com" <jannh@google.com>,
	"surenb@google.com" <surenb@google.com>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"shuah@kernel.org" <shuah@kernel.org>
Subject: Re: selftests/mm/rmap: verify correct RMAP handling of COW pages after fork()
Date: Wed, 15 Oct 2025 12:02:31 +0300	[thread overview]
Message-ID: <aO9jJ-wGR5ANmKZs@kernel.org> (raw)
In-Reply-To: <8c2c9721-e2ca-488b-b7be-c58170f6ceba@redhat.com>

On Wed, Oct 15, 2025 at 10:49:48AM +0200, David Hildenbrand wrote:
> On 15.10.25 10:43, Itamar Dalal wrote:
> > Add a new test `migrate.cow_after_fork` that verifies correct RMAP handling
> > of Copy-On-Write (COW) pages after fork().
> > 
> > Before a write, the parent and child share the same PFN. After a write, the
> > child’s PFN differs. This confirms that proper COW duplication occurred and
> > that RMAP correctly tracks page ownership transitions during COW events.
> > 
> > Signed-off-by: Itamar-Dalal <dalalitamar@gmail.com>
> > ---
> 
> Se my reply to your other patch.
> 
> For the next time
> 
> a) Use git-format-patch that will automatically add [PATCH]
> 
> b) Use versioning, e.g., [PATCH v1], explain changes since the last version
> under the "---" the
> 
> c) Use RESEND for resends, e.g., [PATCH v1 RESEND]
> 
> d) Use git-send-email to send mails out
> 
> The b4 tool might help as well.

And

e) please don't respin new version as soon as you get a single feedback.

https://docs.kernel.org/process/submitting-patches.html#don-t-get-discouraged-or-impatient
 

-- 
Sincerely yours,
Mike.


  reply	other threads:[~2025-10-15  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  8:43 Itamar Dalal
2025-10-15  8:49 ` David Hildenbrand
2025-10-15  9:02   ` Mike Rapoport [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-15  8:33 Itamar Dalal
2025-10-15  8:47 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aO9jJ-wGR5ANmKZs@kernel.org \
    --to=rppt@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=dalalitamar@gmail.com \
    --cc=david@redhat.com \
    --cc=harry.yoo@oracle.com \
    --cc=jannh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=riel@surriel.com \
    --cc=shuah@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox