From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18461CAC5A7 for ; Tue, 23 Sep 2025 11:52:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FF6F8E0021; Tue, 23 Sep 2025 07:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 688DA8E0001; Tue, 23 Sep 2025 07:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 529778E0021; Tue, 23 Sep 2025 07:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3350D8E0001 for ; Tue, 23 Sep 2025 07:52:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D85931A0490 for ; Tue, 23 Sep 2025 11:52:30 +0000 (UTC) X-FDA: 83920352460.10.B28E349 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf17.hostedemail.com (Postfix) with ESMTP id 44E7E40008 for ; Tue, 23 Sep 2025 11:52:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=EFGvr8Qy; spf=pass (imf17.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1758628348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FZaoT1QNSR93wIPtHts3CPzp0ctIk0vYDNbzffEOi0c=; b=XQqhUUwDL3q+FbV0eSVpc14gPBxpMHHJCV1o2E4KdbxtB+S9jHV4+gBzY3BHSowRoOx60S CmnPsGuYZ71UYObIY16U6sexvCVD1b1q3+CTdcgu6g/KtQMIEqz2p+pA7QwUEUVj5LPe+H dTEyBHcn62pQpaBr7MH8H+lp+ZnxxPQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=EFGvr8Qy; spf=pass (imf17.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1758628348; a=rsa-sha256; cv=none; b=Z+IaOHo+g1+M1F35vtxyLaE3vkYchYGcf3gjrWXQkj+5W2f+YN6jOl4ut8vPFf7D/DCTFk 4MPLi3NE3TWuSLwizBgpGVypm1M6GnfOZxuM3LsiAfcQkzDi8mDSVXhK+niCm/Kixyocoj LUOvSQ1riBamu06hdi/tXEWd+dKaHSA= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58N8Y12b008695; Tue, 23 Sep 2025 11:52:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=FZaoT1QNSR93wIPtHts3CPzp0ctIk0 vYDNbzffEOi0c=; b=EFGvr8QyltIf32/aszOR/qJfepgW+UcWXreJDplTglupit m+X7rmX3tdEzuL1hJj2o5XWwJ0r+pCJ4BjGEMOhGvQ5uA7F1CUxQtR7TqdF163bV I3YXhbagNN2r+8NAvqFEHYkOG72rBgt1rm+ek1A/MwpmvyPZqT+huO4x+iKBFWTR eo6ih9hfsFn2nHia9aCP+YLY6UeADcGZp/ivckC/FFUA6i0IL4LnbBeJbqc6eiAl 5jWsuCjMMTLD7wV7h8suNXD082oB3YYd9QtgvibDoicaRjRsG3bClbPAwbAw7H1U VId+vHnlTcxFpVyEmlJvEr0+HDviZMbBrXxprVQA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 499n0jgm9c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Sep 2025 11:52:19 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 58NBn9Dd005820; Tue, 23 Sep 2025 11:52:18 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 499n0jgm96-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Sep 2025 11:52:18 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 58N9Tk1U019675; Tue, 23 Sep 2025 11:52:17 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49a83k31qr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Sep 2025 11:52:17 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 58NBqDIE43516160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Sep 2025 11:52:13 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F401A20043; Tue, 23 Sep 2025 11:52:12 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A61F420040; Tue, 23 Sep 2025 11:52:10 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.87.150.243]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 23 Sep 2025 11:52:10 +0000 (GMT) Date: Tue, 23 Sep 2025 13:52:09 +0200 From: Sumanth Korikkar To: Lorenzo Stoakes Cc: Andrew Morton , Jonathan Corbet , Matthew Wilcox , Guo Ren , Thomas Bogendoerfer , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S . Miller" , Andreas Larsson , Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Nicolas Pitre , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Baoquan He , Vivek Goyal , Dave Young , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Alexander Viro , Christian Brauner , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Uladzislau Rezki , Dmitry Vyukov , Andrey Konovalov , Jann Horn , Pedro Falcato , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-csky@vger.kernel.org, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, kexec@lists.infradead.org, kasan-dev@googlegroups.com, Jason Gunthorpe , iommu@lists.linux.dev, Kevin Tian , Will Deacon , Robin Murphy Subject: Re: [PATCH v4 11/14] mm/hugetlbfs: update hugetlbfs to use mmap_prepare Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTIwMDAzMyBTYWx0ZWRfX1/CT4ehdu5F7 6VnJC5JZb/TGq0GTxXqzwutGBpnh5zvXhqXxihnE0ZIBeLxavZe5A1rzKbuxO1bDNyuFhUEM+Rk 4I1KMXyeBzNEU/g4Tedu1h1rULa5Sn/p0/UqkELdAnxrKDhWjf96WssSMg0ltTS+aMBZqn2U8bf Mm6V030K3rfmUmm6+2tKL/Lil9yhk2vaa1ilZs3936p1XOaPfvsu3tSuBabaOBW+S4p6UJCCS7o UssKxq/W9pewKawoXgWRMXrenvRD0Q+OeFvs8GRRauXhjlsHet/L1r4+QnnsJQ0kVijCVo4qQhY p/3nafFZQN3AWkhiFthvrI3hfInHVuTDSlQN3xLdzE/r0zMDPQuTX7WW9M8m8X+BWNkt+j6HOZU bcmWMt/c X-Authority-Analysis: v=2.4 cv=TOlFS0la c=1 sm=1 tr=0 ts=68d289f3 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=kj9zAlcOel0A:10 a=yJojWOMRYYMA:10 a=NEAV23lmAAAA:8 a=yPCof4ZbAAAA:8 a=Ikd4Dj_1AAAA:8 a=P7Dlay8f7KcL8MNlhToA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-ORIG-GUID: F6nP2Q8ol4BSxLNz15joz3bImrmTREZ1 X-Proofpoint-GUID: 5HR21TLQQZuGh5ctB-qo8M6ErsQDpoDW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-23_02,2025-09-22_05,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509200033 X-Rspamd-Queue-Id: 44E7E40008 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: oz1b69exj5xzthc97wbqytb38fh1hu1r X-HE-Tag: 1758628348-719757 X-HE-Meta: U2FsdGVkX19tT3646igZ0xh6sEwfG/AxBBXnYHK/qNgwe+f0A3ub5BbWpSRrnK9Xx6LSXgjFpUUtShRwU8brkUMEf1TAeQDS3vgjEbcP14l6oQj7/P2/SLgVC2xPlGa9ZQjG9awc/tuz+w2qQrFfiwx/Ct9Vn0CskYBchPT873pIEDzG1pHIn7dzOWngb9lZKqQrIVFJmbVSVZkw9CvgJs7DWy303beVKBU1bFtS/izlaFClcIx+V2N0UTES9Jrw4hbbnAAZgZ8nq1tfMm1hvAqttGQFH3aY6fNIfUmHbhirI85BeDj2gwbk8hS+2LbTuKPpI6PHN5WazxCXJhOzbYhdBH34RQLIaLTR632YIw+OoseZtI9/7fm6FjUnpExg35y1BmSvFvT8AXFCuU/HB1f956lnGrAUjSbEDygYBjI90pVsBxQjggYjmKhmCCHuBgJFqeG1aF+M4ZDEKGhfaG5D2tqxEpv0WgcERHW8OoTXclIuYnCy+6wGMA+0TRPFZw2RvDmdljboLS10HvOr/NeANVV3EPFdQ3byHLDYkaiYKkqvxwSl2JzKuw9sajhbYiExXBnC5WSO4vBy3//Ft5w7NM7IO39qA5+mxLhUxG/2hr2MSbiunDsSUkv+K4P4QcRBv50RHNZm9IXdi/RNmPHv+XB+i7rOxzxiG5bD23EW8PiC7i3YYCCOi5u72yOp2meZGsGEvHR4nUG+S+eiJXMZ2oj0/d9luwY4e2uJeZr4XxEhmyALLiRk9yMGttwziyUrzKwkWJmyp5P7OxOLeIFktZ+FKS/9Y02ldBiFL8bfcFD9i8do2FdcD9tan/LqkV9NbiI7Hwza5adJoVU5Xcom2Szqh9oJC5SH0KCPhsZreaTDAhhUH7/IXImdPb6w9tk/LOFmc997VOpw4edoQfRoYpDtqB1qYFF91wLJKTR12lMZyMtoGvjR1e6h7Ddg+C4whL4LMtX0AIppK2s 7TztKCHd YT0rzOmTEFuGejRd/eHURikbwxO/ca3jSLBa3vSbCrT3X/Fnnl3Y0D1BxHbXoqACHPrh855diS3Tcf8sCx/+QxPYzmB1OTbxY9RBmcubsdI0owS7E2H0FzVyl+CaCmUh3Tz3sGe0T3PH9Wqi8zx1LJKIirIEum9pbqxf6m+vnxiNj3iAtIYY3eH8wliw2x2lgQrkyDMps81vr3pbaX7eVDPakM94Gpwflv6AZKZ3PU6hvtIjHLZ4J4Gd5ik/SaHaEmmez+qvFqAGXlk4TjuQdT4pHcHviRGKlr6s6c9U9cESWi/y2q9ebvZgilucEkcB8C1HJTU+7DO4NHtFJ5MU6vOkdf68XIhL7OulBkh/HrvpcsQvTU3h4mVX26T1xzqhIi0Ho X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 17, 2025 at 08:11:13PM +0100, Lorenzo Stoakes wrote: > Since we can now perform actions after the VMA is established via > mmap_prepare, use desc->action_success_hook to set up the hugetlb lock > once the VMA is setup. > > We also make changes throughout hugetlbfs to make this possible. > > Signed-off-by: Lorenzo Stoakes > Reviewed-by: Jason Gunthorpe > --- > fs/hugetlbfs/inode.c | 36 ++++++++++------ > include/linux/hugetlb.h | 9 +++- > include/linux/hugetlb_inline.h | 15 ++++--- > mm/hugetlb.c | 77 ++++++++++++++++++++-------------- > 4 files changed, 85 insertions(+), 52 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index f42548ee9083..9e0625167517 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -96,8 +96,15 @@ static const struct fs_parameter_spec hugetlb_fs_parameters[] = { > #define PGOFF_LOFFT_MAX \ > (((1UL << (PAGE_SHIFT + 1)) - 1) << (BITS_PER_LONG - (PAGE_SHIFT + 1))) > > -static int hugetlbfs_file_mmap(struct file *file, struct vm_area_struct *vma) > +static int hugetlb_file_mmap_prepare_success(const struct vm_area_struct *vma) > { > + /* Unfortunate we have to reassign vma->vm_private_data. */ > + return hugetlb_vma_lock_alloc((struct vm_area_struct *)vma); > +} Hi Lorenzo, The following tests causes the kernel to enter a blocked state, suggesting an issue related to locking order. I was able to reproduce this behavior in certain test runs. Test case: git clone https://github.com/libhugetlbfs/libhugetlbfs.git cd libhugetlbfs ; ./configure make -j32 cd tests echo 100 > /proc/sys/vm/nr_hugepages mkdir -p /test-hugepages && mount -t hugetlbfs nodev /test-hugepages ./run_tests.py ... shm-fork 10 100 (1024K: 64): PASS set shmmax limit to 104857600 shm-getraw 100 /dev/full (1024K: 32): shm-getraw 100 /dev/full (1024K: 64): PASS fallocate_stress.sh (1024K: 64): Blocked task state below: task:fallocate_stres state:D stack:0 pid:5106 tgid:5106 ppid:5103 task_flags:0x400000 flags:0x00000001 Call Trace: [<00000255adc646f0>] __schedule+0x370/0x7f0 [<00000255adc64bb0>] schedule+0x40/0xc0 [<00000255adc64d32>] schedule_preempt_disabled+0x22/0x30 [<00000255adc68492>] rwsem_down_write_slowpath+0x232/0x610 [<00000255adc68922>] down_write_killable+0x52/0x80 [<00000255ad12c980>] vm_mmap_pgoff+0xc0/0x1f0 [<00000255ad164bbe>] ksys_mmap_pgoff+0x17e/0x220 [<00000255ad164d3c>] __s390x_sys_old_mmap+0x7c/0xa0 [<00000255adc60e4e>] __do_syscall+0x12e/0x350 [<00000255adc6cfee>] system_call+0x6e/0x90 task:fallocate_stres state:D stack:0 pid:5109 tgid:5106 ppid:5103 task_flags:0x400040 flags:0x00000001 Call Trace: [<00000255adc646f0>] __schedule+0x370/0x7f0 [<00000255adc64bb0>] schedule+0x40/0xc0 [<00000255adc64d32>] schedule_preempt_disabled+0x22/0x30 [<00000255adc68492>] rwsem_down_write_slowpath+0x232/0x610 [<00000255adc688be>] down_write+0x4e/0x60 [<00000255ad1c11ec>] __hugetlb_zap_begin+0x3c/0x70 [<00000255ad158b9c>] unmap_vmas+0x10c/0x1a0 [<00000255ad180844>] vms_complete_munmap_vmas+0x134/0x2e0 [<00000255ad1811be>] do_vmi_align_munmap+0x13e/0x170 [<00000255ad1812ae>] do_vmi_munmap+0xbe/0x140 [<00000255ad183f86>] __vm_munmap+0xe6/0x190 [<00000255ad166832>] __s390x_sys_munmap+0x32/0x40 [<00000255adc60e4e>] __do_syscall+0x12e/0x350 [<00000255adc6cfee>] system_call+0x6e/0x90 Thanks, Sumanth