From: Matthew Wilcox <willy@infradead.org>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, david@redhat.com,
mhocko@kernel.org, zhengqi.arch@bytedance.com,
shakeel.butt@linux.dev, lorenzo.stoakes@oracle.com,
hughd@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: vmscan: remove folio_test_private() check in pageout()
Date: Fri, 12 Sep 2025 16:21:17 +0100 [thread overview]
Message-ID: <aMQ6bW-OoMWMVEFF@casper.infradead.org> (raw)
In-Reply-To: <b8c0fe71982aa1cafafd59d8e71064efaac16007.1757648598.git.baolin.wang@linux.alibaba.com>
On Fri, Sep 12, 2025 at 11:45:07AM +0800, Baolin Wang wrote:
> @@ -697,22 +697,8 @@ static pageout_t pageout(struct folio *folio, struct address_space *mapping,
> * swap_backing_dev_info is bust: it doesn't reflect the
> * congestion state of the swapdevs. Easy to fix, if needed.
> */
> - if (!is_page_cache_freeable(folio))
> + if (!is_page_cache_freeable(folio) || !mapping)
> return PAGE_KEEP;
I feel like we need to keep the comment (assuming it's still true ...
which it probably is, although there's nobody who would think to update
this comment if it became no longer true). I would certainly wonder why
we can have this !mapping test.
> - /*
> - * Some data journaling orphaned folios can have
> - * folio->mapping == NULL while being dirty with clean buffers.
> - */
I approve of this simplification, and I think there's more work to be
done in this area. Thanks for doing it.
next prev parent reply other threads:[~2025-09-12 15:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 3:45 [PATCH 0/2] some cleanups for pageout() Baolin Wang
2025-09-12 3:45 ` [PATCH 1/2] mm: vmscan: remove folio_test_private() check in pageout() Baolin Wang
2025-09-12 8:24 ` David Hildenbrand
2025-09-12 8:24 ` David Hildenbrand
2025-09-12 8:31 ` Baolin Wang
2025-09-12 8:57 ` David Hildenbrand
2025-09-12 9:03 ` Baolin Wang
2025-09-12 8:57 ` David Hildenbrand
2025-09-12 15:21 ` Matthew Wilcox [this message]
2025-09-13 3:04 ` Baolin Wang
2025-09-15 20:47 ` Matthew Wilcox
2025-09-18 2:45 ` Baolin Wang
2025-09-12 16:13 ` Shakeel Butt
2025-09-13 3:24 ` Baolin Wang
2025-09-15 20:00 ` Shakeel Butt
2025-09-16 4:00 ` Hugh Dickins
2025-09-16 7:18 ` Baolin Wang
2025-09-17 3:50 ` Baolin Wang
2025-09-17 7:49 ` Hugh Dickins
2025-09-18 2:22 ` Baolin Wang
2025-09-12 3:45 ` [PATCH 2/2] mm: vmscan: simplify the folio refcount " Baolin Wang
2025-09-12 8:58 ` David Hildenbrand
2025-09-12 16:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aMQ6bW-OoMWMVEFF@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox