[PATCH v3] huge_memory: return -EINVAL in folio split functions when THP is disabled

[PATCH v3] huge_memory: return -EINVAL in folio split functions when THP is disabled

[Pankaj Raghav (Samsung)]

From: Pankaj Raghav <p.raghav@samsung.com>

split_huge_page_to_list_[to_order](), split_huge_page() and
try_folio_split() return 0 on success and error codes on failure.

When THP is disabled, these functions return 0 indicating success even
though an error code should be returned as it is not possible to split a
folio when THP is disabled.

Make all these functions return -EINVAL to indicate failure instead of
0. As large folios depend on CONFIG_THP, issue warning as this function
should not be called without a large folio.

Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Zi Yan <ziy@nvidia.com>
Acked-by: Kiryl Shutsemau <kas@kernel.org>
Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202509051753.riCeG7LC-lkp@intel.com/
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
Changes since v2:
  - use page_folio(page) directly in VM_WARN_ON_ONCE_FOLIO

 include/linux/huge_mm.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index 7748489fde1b..1aeec06a89f7 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -553,22 +553,26 @@ static inline int
 split_huge_page_to_list_to_order(struct page *page, struct list_head *list,
 		unsigned int new_order)
 {
-	return 0;
+	VM_WARN_ON_ONCE_FOLIO(1, page_folio(page));
+	return -EINVAL;
 }
 static inline int split_huge_page(struct page *page)
 {
-	return 0;
+	VM_WARN_ON_ONCE_FOLIO(1, page_folio(page));
+	return -EINVAL;
 }
 
 static inline int split_folio_to_list(struct folio *folio, struct list_head *list)
 {
-	return 0;
+	VM_WARN_ON_ONCE_FOLIO(1, folio);
+	return -EINVAL;
 }
 
 static inline int try_folio_split(struct folio *folio, struct page *page,
 		struct list_head *list)
 {
-	return 0;
+	VM_WARN_ON_ONCE_FOLIO(1, folio);
+	return -EINVAL;
 }
 
 static inline void deferred_split_folio(struct folio *folio, bool partially_mapped) {}

base-commit: e6b9dce0aeeb91dfc0974ab87f02454e24566182
-- 
2.50.1

Re: [PATCH v3] huge_memory: return -EINVAL in folio split functions when THP is disabled

[Matthew Wilcox]

On Fri, Sep 05, 2025 at 03:13:52PM +0200, Pankaj Raghav (Samsung) wrote:
> Changes since v2:
>   - use page_folio(page) directly in VM_WARN_ON_ONCE_FOLIO

... why not use VM_WARN_ON_ONCE_PAGE?

Re: [PATCH v3] huge_memory: return -EINVAL in folio split functions when THP is disabled

[Pankaj Raghav (Samsung)]

On Fri, Sep 05, 2025 at 02:53:04PM +0100, Matthew Wilcox wrote:
> On Fri, Sep 05, 2025 at 03:13:52PM +0200, Pankaj Raghav (Samsung) wrote:
> > Changes since v2:
> >   - use page_folio(page) directly in VM_WARN_ON_ONCE_FOLIO
> 
> ... why not use VM_WARN_ON_ONCE_PAGE?
No idea how I missed that!

--
Pankaj

Re: [PATCH v3] huge_memory: return -EINVAL in folio split functions when THP is disabled

[Barry Song]

On Fri, Sep 5, 2025 at 10:57 PM Pankaj Raghav (Samsung)
<kernel@pankajraghav.com> wrote:
>
> On Fri, Sep 05, 2025 at 02:53:04PM +0100, Matthew Wilcox wrote:
> > On Fri, Sep 05, 2025 at 03:13:52PM +0200, Pankaj Raghav (Samsung) wrote:
> > > Changes since v2:
> > >   - use page_folio(page) directly in VM_WARN_ON_ONCE_FOLIO
> >
> > ... why not use VM_WARN_ON_ONCE_PAGE?
> No idea how I missed that!

With this,

Reviewed-by: Barry Song <baohua@kernel.org>

Thanks
Barry