Re: [PATCH] tools/mm: Add madvise tool

[Michal Hocko <mhocko@suse.com>]

On Fri 05-09-25 11:16:38, Lorenzo Stoakes wrote:
> On Fri, Sep 05, 2025 at 11:17:10AM +0200, Michal Hocko wrote:
> >
> > Is there any reason to have this in the tree? This seems like a very
> > trivial tools that doesn't really need to be in a lockstep with the
> > kernel source.
> 
> To give my own 2 pence on this :>)
> 
> I think this is actually quite useful because it invokes process_madvise() and
> so can be used for experiments against other processes in a way that'd you'd
> have to write code for otherwise.

I am not questioning usefulness of the tool itself.

> I think it's useful to keep in sync with kernel as if we add more remote process
> madvise functionality this can be updated with it.

I just do not see any value in having it in the tree. It doesn't use (or
rely on) any kernel infrastructure and it can happily live outside of
the tree. New madvise functionality requires a runtime support rather
than a support in the current source tree.

We are certainly not pulling in other potentially useful tools
into the kernel tree in for some it was even really hard/impossible to
be merged yet they would benefit from a close lockstep with kernel
sources.


-- 
Michal Hocko
SUSE Labs