From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: I Viswanath <viswanathiyyappan@gmail.com>
Cc: shuah@kernel.org, akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] selftests/mm: use calloc instead of malloc in pagemap_ioctl.c
Date: Mon, 25 Aug 2025 11:56:24 -0700 [thread overview]
Message-ID: <aKyx2IKTLpaxjZnV@fedora> (raw)
In-Reply-To: <20250825170643.63174-1-viswanathiyyappan@gmail.com>
On Mon, Aug 25, 2025 at 10:36:43PM +0530, I Viswanath wrote:
> As per Documentation/process/deprecated.rst, dynamic size calculations
> should not be performed in memory allocator arguments due to possible
> overflows.
>
> Replaced malloc with calloc to avoid open-ended arithmetic
> and prevent possible overflows.
>
> Signed-off-by: I Viswanath <viswanathiyyappan@gmail.com>
> ---
LGTM.
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
next prev parent reply other threads:[~2025-08-25 18:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 17:06 I Viswanath
2025-08-25 18:56 ` Vishal Moola (Oracle) [this message]
2025-08-25 19:21 ` David Hildenbrand
2025-08-26 4:41 ` Donet Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKyx2IKTLpaxjZnV@fedora \
--to=vishal.moola@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=viswanathiyyappan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox