linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Yueyang Pan <pyyjason@gmail.com>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Suren Baghdasaryan <surenb@google.com>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	Usama Arif <usamaarif642@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 0/1] Try to add memory allocation info for cgroup oom kill
Date: Thu, 21 Aug 2025 12:18:00 -0700	[thread overview]
Message-ID: <aKdw6Pkj2H4B6QDb@devbig569.cln6.facebook.com> (raw)
In-Reply-To: <6qu2uo3d2msctkkz5slhx5piqtt64wsvkgkvjjpd255k7nrds4@qtffskmesivg>

On Thu, Aug 21, 2025 at 11:35:19AM -0700, Shakeel Butt wrote:
> On Thu, Aug 14, 2025 at 10:11:56AM -0700, Yueyang Pan wrote:
> > Right now in the oom_kill_process if the oom is because of the cgroup 
> > limit, we won't get memory allocation infomation. In some cases, we 
> > can have a large cgroup workload running which dominates the machine. 
> > The reason using cgroup is to leave some resource for system. When this 
> > cgroup is killed, we would also like to have some memory allocation 
> > information for the whole server as well. This is reason behind this 
> > mini change. Is it an acceptable thing to do? Will it be too much 
> > information for people? I am happy with any suggestions!
> 
> For a single patch, it is better to have all the context in the patch
> and there is no need for cover letter.

Thanks for your suggestion Shakeel! I will change this in the next version.

> 
> What exact information you want on the memcg oom that will be helpful
> for the users in general? You mentioned memory allocation information,
> can you please elaborate a bit more.
> 

As in my reply to Suren, I was thinking the system-wide memory usage info 
provided by show_free_pages and memory allocation profiling info can help 
us debug cgoom by comparing them with historical data. What is your take on 
this?

Thanks,
Pan


  reply	other threads:[~2025-08-21 19:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14 17:11 Yueyang Pan
2025-08-14 17:11 ` [RFC 1/1] Add memory allocation info for cgroup oom Yueyang Pan
2025-08-14 20:11   ` Joshua Hahn
2025-08-18 14:24     ` Yueyang Pan
2025-08-21  1:25       ` Suren Baghdasaryan
2025-08-21 19:09         ` Yueyang Pan
2025-08-21 18:35 ` [RFC 0/1] Try to add memory allocation info for cgroup oom kill Shakeel Butt
2025-08-21 19:18   ` Yueyang Pan [this message]
2025-08-21 19:53     ` Shakeel Butt
2025-08-21 20:00       ` Suren Baghdasaryan
2025-08-21 21:26         ` Shakeel Butt
2025-08-26 13:52           ` Yueyang Pan
2025-08-26 14:06       ` Yueyang Pan
2025-08-27  2:38         ` Suren Baghdasaryan
2025-08-29  6:35           ` Michal Hocko
2025-09-08 17:34             ` Kent Overstreet
2025-09-08 17:47               ` Suren Baghdasaryan
2025-09-08 17:49                 ` Kent Overstreet
2025-09-08 17:51                   ` Suren Baghdasaryan
2025-09-08 19:07                     ` Shakeel Butt
2025-09-08 19:55                       ` Suren Baghdasaryan
2025-09-09  6:17               ` Michal Hocko
2025-08-27  2:32       ` Suren Baghdasaryan
2025-08-27  4:47         ` Usama Arif
2025-08-27 21:15         ` Shakeel Butt
2025-09-07  5:16           ` Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aKdw6Pkj2H4B6QDb@devbig569.cln6.facebook.com \
    --to=pyyjason@gmail.com \
    --cc=kent.overstreet@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shakeel.butt@linux.dev \
    --cc=surenb@google.com \
    --cc=usamaarif642@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox