From: Herbert Xu <herbert@gondor.apana.org.au>
To: Barry Song <21cnbao@gmail.com>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
Johannes Weiner <hannes@cmpxchg.org>,
Nhat Pham <nphamcs@gmail.com>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Takero Funaki <flintglass@gmail.com>,
David Hildenbrand <david@redhat.com>, Baoquan He <bhe@redhat.com>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>
Subject: Re: [PATCH v4] mm/zswap: store <PAGE_SIZE compression failed page as-is
Date: Wed, 20 Aug 2025 09:20:46 +0800 [thread overview]
Message-ID: <aKUi7hvcaK0h0oMg@gondor.apana.org.au> (raw)
In-Reply-To: <CAGsJ_4ygTv1tCJeuF43NhRR4E0kiMLpk6i8c+UHoUMt6LXykww@mail.gmail.com>
On Wed, Aug 20, 2025 at 01:13:13PM +1200, Barry Song wrote:
>
> Let’s sync with Herbert: have we reached the stage where all drivers
> reliably return -ENOSPC when dst_buf is PAGE_SIZE but the compressed
> size would exceed it?
It doesn't matter. Software compression should never fail, and
if it does fail due to a bug, that's not something that the user
of the API should worry about.
Hardware compression should always fall back to software compression
in case of failure.
IOW all compression errors should be treated as incompressible
data.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2025-08-20 1:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 19:34 SeongJae Park
2025-08-20 1:13 ` Barry Song
2025-08-20 1:20 ` Herbert Xu [this message]
2025-08-20 1:34 ` Barry Song
2025-08-20 1:37 ` Herbert Xu
2025-08-20 17:32 ` Nhat Pham
2025-08-21 10:27 ` Barry Song
2025-08-21 16:42 ` SeongJae Park
2025-08-21 20:49 ` Chris Li
2025-08-21 21:36 ` SeongJae Park
2025-08-22 0:48 ` Barry Song
2025-08-22 5:54 ` Herbert Xu
2025-08-22 7:30 ` Barry Song
2025-08-22 16:44 ` SeongJae Park
2025-08-20 5:07 ` Chris Li
2025-08-20 5:10 ` Herbert Xu
2025-08-20 5:20 ` Chris Li
2025-08-20 5:22 ` Herbert Xu
2025-08-21 20:42 ` Chris Li
2025-08-20 4:55 ` Chris Li
2025-08-20 4:49 ` Chris Li
2025-08-21 16:17 ` SeongJae Park
2025-08-21 21:21 ` Chris Li
2025-08-21 21:41 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aKUi7hvcaK0h0oMg@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=sj@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox