From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE98CA0EE6 for ; Tue, 19 Aug 2025 11:03:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D53A8E0035; Tue, 19 Aug 2025 07:03:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 586068E0001; Tue, 19 Aug 2025 07:03:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49BE98E0035; Tue, 19 Aug 2025 07:03:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 33E188E0001 for ; Tue, 19 Aug 2025 07:03:56 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9F2651A031C for ; Tue, 19 Aug 2025 11:03:55 +0000 (UTC) X-FDA: 83793222030.03.7353D6C Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf03.hostedemail.com (Postfix) with ESMTP id D8B7320005 for ; Tue, 19 Aug 2025 11:03:53 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JxdFsQCr; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1755601434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WyAwx7R6tLQApXt0d2rYp308YDLTH9zLqptJETzz5Hk=; b=sHZlpPXIOBYx+AVn32+ebRY1qcZ7TabVNqWk+8S8vxHzqNI/e6NpoMUoSMgmmTULLK/58Q SNWlJejuUGEniEze3+ZseChOnelOZRERyVSlqkbRgHnTKq+77lalvHZb7xHCfJ65nn0Dl8 tevPPdgUh9TrGoymj5ZVFtzA6jHBHkg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1755601434; a=rsa-sha256; cv=none; b=DTyyK70JEtPiW1ag+zmAzWzLVlEp68j/IWakAp2hjqJuvIgvVkJRslnSBfuJtK+E/ZXNLr Yskozzppctr2W2gGRCVRasgogCjmDkkCiYgMB12wmCkngkvBYk8uu2G57RwyWz5ySQ4xdh J80nfezG5mYm9NHyvKpeNMJDUJLvmA0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JxdFsQCr; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 67C1643B7C; Tue, 19 Aug 2025 11:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DA29C4CEF1; Tue, 19 Aug 2025 11:03:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755601432; bh=UcQi5igNficMd4VE9yzQLipb16wG55Yu37q1KOU8F3I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JxdFsQCr+OjBL4861fcA/j5N8Oi65KK+RZZZyZzgjdpJWamtjzsI7kPg8IClpZw80 fOWd66glzc6/gDVKCBlSWtSlEN/Wz/BqrtIKCuu0UahC8Ayy2dDToiyBer+GjsbwJ1 OiKqqguAFWrSk9KMh65PqMgMypHQEhpBOc1ZcJTnhpUPyCN60wUFDBftVgOHWuo7DS WJDHwI812W+q5eXugX7VlOo6/O07U6KmBkvF+lgB0LkH4Gax4D1Ej7x0ITsnREWlpv M4cI4GOw7v4nGQoTZDgZMVM3cgp91mgschqg3a83hpaFGYnX44tBitFQbpCRheo6hO bwDXvMFXjtyuQ== Date: Tue, 19 Aug 2025 14:03:44 +0300 From: Mike Rapoport To: Yin Tirui Cc: robh@kernel.org, saravanak@google.com, dan.j.williams@intel.com, akpm@linux-foundation.org, david@redhat.com, Jonathan.Cameron@huawei.com, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, chenjun102@huawei.com Subject: Re: [PATCH v3] of_numa: fix uninitialized memory nodes causing kernel panic Message-ID: References: <20250819075510.2079961-1-yintirui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250819075510.2079961-1-yintirui@huawei.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D8B7320005 X-Stat-Signature: y6dtbw6q3eeyjtyzhphpx6z5jthesn1a X-Rspam-User: X-HE-Tag: 1755601433-540746 X-HE-Meta: U2FsdGVkX18VGq7swKBMdvG3LnB6OJLx2GtTzd0D0Yt8KM9fFVYEaZzPTpk8f1PBLEIxaWhYeOhTApUnyh4QR9iLO7E1bRbJrgs6rWVAjWwAJrXpEiIkxZoQLM4AIj5abY13K7Q44do+RCG3xUBv00juXmb3iampqo1Ay7opyf2C7caBvguaHNBp6Mh9ay2l6O6VtXvzYio1OMGqvpHIDsiLRlOH9YBdbATzBOObTzMOQaqLsD6pa1LX3gIdmusOBzvIQVIJ71bUNQ2z9pdBxsSCMdmqadZcaMz2EIYbkaE24YotOp5623CL2L7WN77qru/LsEMMyEVaYUznCj4orUC9ZQ2U0VHdcYOn5wTIZwPKdDiCQl3WJYbuuQWh9OBuncwncK50B+oHG0grBcTX7aLnZyrJ3qQYRaqkYG43bdvO99gH7u5IVrAyoUSgpm0vq5RvsT81Ex6w0FZzzAKF3ZYcVogmwIuRrhEkep7431tamkvHi8+l+p3Be9Yp8+Rqs7DefY31U0K9ayZUtGk4WOcmIZVumJ1OTvUmBqRgegFmrZ9asg88t/GTjHibZpO+AsPAbuSSw+qVJMB5zs58UKEi6HZhO2N+JP6YQo4V1tRoT360X23fTlcdew0NZ5uPl29eWGNvqPtbYIX0R6XWiOVdQ14VNP/cf6+Nyz6Vvkl8bTv4+kQGKX0cMhNFO6vOr+gj22xhP22Ep7rwN1GG4aT9rrgm0a38MduPm4h/Afs2gtcZm0feKFJAzkPGNuo+imO29dd5awMAIK9zq2tNTGiT4Lhq9gTBlAPAlp19lvTYOyQzzihJEdBZmtClHf0cPsGCgbt+q43xDruimrQn18DhacQkZxR85xmKG1G7UX3WavpZTAGHgE3cFyVPXBEbL6vgUzF5tFY1PXTrSZ9hKBU1LzgrY37KlOGlb9m0G4WWEEIC4x3b1lkITpkoffeAQAtfW/61Aw2Q7DzEr2k A9NvJge/ DbD9RJ2fKKGWeuQZ6dr2+k8QtH/6LINnswfGZodDalVo8HyW1Fb+T16AoneZ9JoXo48p9R64BeeFXz3gzB/dfeXfA+3jM43J7t3lU9QUcKEP1kJTKy6De+TaWyghK3jfcmrXKx/s0V0D+mEw/Mkwxct+3Gv9O7CzvHD/n50xcTkyShnip2JG/IAUVWMo8Hrwt0uw+yY2tOAtaTguo25dSO6rW6Y05Bctj+tneCf+XpIDcLNfTDTtYF5+0OPRFN1w6xjMEk6UznluI74NCJo5YeNeq2ffEegNxCjLu0umzutuZhcGlURj1r8rLI8gKSLGd/jvuuosIgoL0BYFKgffmIkxFXWCEO/vb/ag6UJs0C149rXjvdXhBFAbv8g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 19, 2025 at 03:55:10PM +0800, Yin Tirui wrote: > When there are memory-only nodes (nodes without CPUs), these nodes > are not properly initialized, causing kernel panic during boot. > > of_numa_init > of_numa_parse_cpu_nodes > node_set(nid, numa_nodes_parsed); > of_numa_parse_memory_nodes > > In of_numa_parse_cpu_nodes, numa_nodes_parsed gets updated only for > nodes containing CPUs. Memory-only nodes should have been updated in > of_numa_parse_memory_nodes, but they weren't. > > Subsequently, when free_area_init() attempts to access NODE_DATA() > for these uninitialized memory nodes, the kernel panics due to NULL > pointer dereference. > > This can be reproduced on ARM64 QEMU with 1 CPU and 2 memory nodes: > > qemu-system-aarch64 \ > -cpu host -nographic \ > -m 4G -smp 1 \ > -machine virt,accel=kvm,gic-version=3,iommu=smmuv3 \ > -object memory-backend-ram,size=2G,id=mem0 \ > -object memory-backend-ram,size=2G,id=mem1 \ > -numa node,nodeid=0,memdev=mem0 \ > -numa node,nodeid=1,memdev=mem1 \ > -kernel $IMAGE \ > -hda $DISK \ > -append "console=ttyAMA0 root=/dev/vda rw earlycon" > > [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x481fd010] > [ 0.000000] Linux version 6.17.0-rc1-00001-gabb4b3daf18c-dirty (yintirui@local) (gcc (GCC) 12.3.1, GNU ld (GNU Binutils) 2.41) #52 SMP PREEMPT Mon Aug 18 09:49:40 CST 2025 > [ 0.000000] KASLR enabled > [ 0.000000] random: crng init done > [ 0.000000] Machine model: linux,dummy-virt > [ 0.000000] efi: UEFI not found. > [ 0.000000] earlycon: pl11 at MMIO 0x0000000009000000 (options '') > [ 0.000000] printk: legacy bootconsole [pl11] enabled > [ 0.000000] OF: reserved mem: Reserved memory: No reserved-memory node in the DT > [ 0.000000] NODE_DATA(0) allocated [mem 0xbfffd9c0-0xbfffffff] > [ 0.000000] node 1 must be removed before remove section 23 > [ 0.000000] Zone ranges: > [ 0.000000] DMA [mem 0x0000000040000000-0x00000000ffffffff] > [ 0.000000] DMA32 empty > [ 0.000000] Normal [mem 0x0000000100000000-0x000000013fffffff] > [ 0.000000] Movable zone start for each node > [ 0.000000] Early memory node ranges > [ 0.000000] node 0: [mem 0x0000000040000000-0x00000000bfffffff] > [ 0.000000] node 1: [mem 0x00000000c0000000-0x000000013fffffff] > [ 0.000000] Initmem setup node 0 [mem 0x0000000040000000-0x00000000bfffffff] > [ 0.000000] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000a0 > [ 0.000000] Mem abort info: > [ 0.000000] ESR = 0x0000000096000004 > [ 0.000000] EC = 0x25: DABT (current EL), IL = 32 bits > [ 0.000000] SET = 0, FnV = 0 > [ 0.000000] EA = 0, S1PTW = 0 > [ 0.000000] FSC = 0x04: level 0 translation fault > [ 0.000000] Data abort info: > [ 0.000000] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000 > [ 0.000000] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 > [ 0.000000] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 > [ 0.000000] [00000000000000a0] user address but active_mm is swapper > [ 0.000000] Internal error: Oops: 0000000096000004 [#1] SMP > [ 0.000000] Modules linked in: > [ 0.000000] CPU: 0 UID: 0 PID: 0 Comm: swapper Not tainted 6.17.0-rc1-00001-g760c6dabf762-dirty #54 PREEMPT > [ 0.000000] Hardware name: linux,dummy-virt (DT) > [ 0.000000] pstate: 800000c5 (Nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 0.000000] pc : free_area_init+0x50c/0xf9c > [ 0.000000] lr : free_area_init+0x5c0/0xf9c > [ 0.000000] sp : ffffa02ca0f33c00 > [ 0.000000] x29: ffffa02ca0f33cb0 x28: 0000000000000000 x27: 0000000000000000 > [ 0.000000] x26: 4ec4ec4ec4ec4ec5 x25: 00000000000c0000 x24: 00000000000c0000 > [ 0.000000] x23: 0000000000040000 x22: 0000000000000000 x21: ffffa02ca0f3b368 > [ 0.000000] x20: ffffa02ca14c7b98 x19: 0000000000000000 x18: 0000000000000002 > [ 0.000000] x17: 000000000000cacc x16: 0000000000000001 x15: 0000000000000001 > [ 0.000000] x14: 0000000080000000 x13: 0000000000000018 x12: 0000000000000002 > [ 0.000000] x11: ffffa02ca0fd4f00 x10: ffffa02ca14bab20 x9 : ffffa02ca14bab38 > [ 0.000000] x8 : 00000000000c0000 x7 : 0000000000000001 x6 : 0000000000000002 > [ 0.000000] x5 : 0000000140000000 x4 : ffffa02ca0f33c90 x3 : ffffa02ca0f33ca0 > [ 0.000000] x2 : ffffa02ca0f33c98 x1 : 0000000080000000 x0 : 0000000000000001 > [ 0.000000] Call trace: > [ 0.000000] free_area_init+0x50c/0xf9c (P) > [ 0.000000] bootmem_init+0x110/0x1dc > [ 0.000000] setup_arch+0x278/0x60c > [ 0.000000] start_kernel+0x70/0x748 > [ 0.000000] __primary_switched+0x88/0x90 > [ 0.000000] Code: d503201f b98093e0 52800016 f8607a93 (f9405260) > [ 0.000000] ---[ end trace 0000000000000000 ]--- > [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task! > [ 0.000000] ---[ end Kernel panic - not syncing: Attempted to kill the idle task! ]--- > > v2: Move the changes to the of_numa related. Correct the fixes tag. > v3: Only amend commit message with no code changes. > > Cc: stable@vger.kernel.org > Fixes: 767507654c22 ("arch_numa: switch over to numa_memblks") > Signed-off-by: Yin Tirui > Acked-by: David Hildenbrand Acked-by: Mike Rapoport (Microsoft) > --- > drivers/of/of_numa.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c > index 230d5f628c1b..cd2dc8e825c9 100644 > --- a/drivers/of/of_numa.c > +++ b/drivers/of/of_numa.c > @@ -59,8 +59,11 @@ static int __init of_numa_parse_memory_nodes(void) > r = -EINVAL; > } > > - for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++) > + for (i = 0; !r && !of_address_to_resource(np, i, &rsrc); i++) { > r = numa_add_memblk(nid, rsrc.start, rsrc.end + 1); > + if (!r) > + node_set(nid, numa_nodes_parsed); > + } > > if (!i || r) { > of_node_put(np); > -- > 2.43.0 > -- Sincerely yours, Mike.