From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E152C83F17 for ; Fri, 18 Jul 2025 14:23:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 015DA8D0005; Fri, 18 Jul 2025 10:23:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F31648D0001; Fri, 18 Jul 2025 10:23:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6D8B8D0005; Fri, 18 Jul 2025 10:23:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D3A0D8D0001 for ; Fri, 18 Jul 2025 10:23:11 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 86DA512F175 for ; Fri, 18 Jul 2025 14:23:11 +0000 (UTC) X-FDA: 83677602582.16.48EEE19 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf01.hostedemail.com (Postfix) with ESMTP id C60E540014 for ; Fri, 18 Jul 2025 14:23:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Je0n7J0h; spf=pass (imf01.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752848589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9SOEV6YumHYEyRGyyP79J8rvD8TjeHgIyyHaf22UjKQ=; b=d44Eb08AHWB5TR0SZedKFFqF7Kh3NfnlnnuFBlDIWXevzJ5XvAT3iwinLuDYqghgiWdjL0 u1N9Y3iVBFfK7l5k5TzlwcZm3kKTZig63C3BoE+Ty8aekOE076UydjbUbQt+ReowiA5NK8 LU7dvLzKHFVRfU8XELez7f/Dw8qzd3Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Je0n7J0h; spf=pass (imf01.hostedemail.com: domain of frederic@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=frederic@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752848589; a=rsa-sha256; cv=none; b=NN27FtZNoBV3g0yYRS4fFUNNKCU1Fx3Fg79XvJxjMji5PxQwkXSrPy15BDSQAsNKHhaEwg GicE4cH0Hg4jiYh8btkxfeoVFx/BWWiAtebRzGe0zBweWpG7ivFaz/FdwOSZyO49R7+Jhn 85U0xIhkV5ZZyB+3qvnc9ntI+zvFRBw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8F20945114; Fri, 18 Jul 2025 14:23:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FAD4C4CEF4; Fri, 18 Jul 2025 14:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752848588; bh=udKiPtsfo5ZeHKc4m3xNjNZyVu6OikeDVNRQXrxyBK4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Je0n7J0hN4ADj1ilRQU7O2c1AMngZNQseTNbWu03g6WoFHxeQzpJGuF4bmPIlTg0Z WKaRCvp/SHkOifHBrxaH4cU7twyD6uxGQOmeit1EhMFQmIqJONnzO+PFtrIudWSK20 cxTNkMdPY1oj5yvbegZeE6pni7f/g3IBkdbXpnEH0ALvrmIZhVrlGkDo7JXbGEv8jn IH/4CmpuECKpyxyPeviOTCv78FCT6kgzPDWlfMwxxSfxd9VuQdaWbbiPRTfYD52bgC N1EHG/AbvmXmY6qdz1vaYKAqzKYU77f5Seaefzbjn7c1lCYp3FOBkw5sl+q2dO4MYT XYp0nbPNc0bMw== Date: Fri, 18 Jul 2025 16:23:05 +0200 From: Frederic Weisbecker To: Valentin Schneider Cc: LKML , Andrew Morton , Ingo Molnar , Marcelo Tosatti , Michal Hocko , Oleg Nesterov , Peter Zijlstra , Thomas Gleixner , Vlastimil Babka , linux-mm@kvack.org Subject: Re: [PATCH 5/6] sched/isolation: Introduce isolated task work Message-ID: References: <20250703140717.25703-1-frederic@kernel.org> <20250703140717.25703-6-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: C60E540014 X-Rspamd-Server: rspam06 X-Stat-Signature: qw8qc4u4xrjrk6t8r9khq9ntxguthe89 X-HE-Tag: 1752848589-32100 X-HE-Meta: U2FsdGVkX19hhwdIJGPdJSzCqE+hcilppT+BfEAHQS1YKr9LotA/qPOLfE2kIXVG2i3OKskRJgTkAekTvcQlbY1blaTRgfjNoHwE+4HQRe+yh1JXNRkpKlPG/Ms9i6eU4anurncngrJRSbOF5vxzF4VkpotWuehGCoHdagasoU/6Ep3Ggo4uF3scGh3jiaMFVWyIKieEcdUG5z19IGEx2MV3PxnB8xQ6jHTbbEmGqhu98KA59c9JiR6WZfkDqmDUIJ8cSIP2pcFF0ttlnzZZC5QwvMu4Svc2x6eiUlYm2kU9GQAcmUmjA4mWp4hVGs+v2UHhCDZv/Ic0mFDI0rX5xqyRguJlJUj5KFU1l++LgLeGq9u+gnvFkp2TUTUQ4RA74A1NBapUavpM01zYpnh+NZnNxpOTtBKuRzquYsiqNsiNE+8LX8FpBdO7IqIyV4wFlooMS3Dy0e/ET5ND2LBVwYh5a44Z0eYZUMFr/DZ/829RoMkRJw2+8WCC3b7DT0LH9HqIMUlPEit0NZo20xbWg0biE6ejrxeSV5IDEx0j4xafFDU8t1xUDxblljl8d0LpBSoO43Zgwh6OQcGH9YtcffzAkGZSda1NS6NiBYTs69brQk5y38j6xVkJ38NeoLByA/QER2tMv43FkGXg8OWDg3yiAS2y0cF46s0W2Cw/gGY6SfctI+eJqs0M01PgndKetvlh9hpQwvdTqwdml4IVAIlCnn8955rMy9S3x0Lm5sl6nVWnWG4UCWQUS1HdIy1XwXZxAQ5YRzhGeaWGvydy1/pom6KIBbuUlB24myYta1jUCFVK76L9WTdtCxFfMDj51yXY73YXmvNG1o3DdoEmLnhCp9K3OGAqnhd92CercbHM5HVCAJ1dnW/MOR8/lGBLL0sX2BDiDu2GMfDXjtTWzUl7RnE018HmpswluXelSXwa7lXsLCOCo4gHDXb77nSwywSMJ6mE6b/asXyekF2 FW2cp8vb hJpEvXlP9ESe/TcMicPoRb8YkyePG3JhxGCNWzV0T7d3Xf3DA54Wb9uxRc9B979Xoc+kRsBn06OzeU/4SXXbmag4bG0zcJWDJkp0beMfNR2qGGePzpU+ldyy4ubCxR83VUd1KUkHNBHTnkHLAvTSG5dwp91r940cAT/VwCMMKTmauaFBtH8Bn1GJrL+uZGZiLsolkSru1tY5gZMPoyXHKqQO9gE3PH8HZCGcPZZUw1QHKpPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le Fri, Jul 18, 2025 at 11:52:01AM +0200, Valentin Schneider a écrit : > On 03/07/25 16:07, Frederic Weisbecker wrote: > > @@ -77,4 +77,21 @@ static inline bool cpu_is_isolated(int cpu) > > cpuset_cpu_is_isolated(cpu); > > } > > > > +#if defined(CONFIG_NO_HZ_FULL_WORK) > > +extern int __isolated_task_work_queue(void); > > + > > +static inline int isolated_task_work_queue(void) > > +{ > > + if (!housekeeping_cpu(raw_smp_processor_id(), HK_TYPE_KERNEL_NOISE)) > > + return -ENOTSUPP; > > + > > Am I being dense or this condition the opposite of what we want? That is, > AIUI we want isolated_task_work() to run on NOHZ_FULL/isolated CPUs' > resume-to-userspace path, so this should bail if the current CPU > *is* a housekeeping CPU. Geeze! > > > + return __isolated_task_work_queue(); > > +} > > + > -- Frederic Weisbecker SUSE Labs