From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8056C83F22 for ; Thu, 17 Jul 2025 13:37:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22E4E6B009D; Thu, 17 Jul 2025 09:37:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE806B009E; Thu, 17 Jul 2025 09:37:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CDC26B00A0; Thu, 17 Jul 2025 09:37:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F00F56B009D for ; Thu, 17 Jul 2025 09:37:37 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 999C8110CB4 for ; Thu, 17 Jul 2025 13:37:37 +0000 (UTC) X-FDA: 83673858954.13.A32B84A Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf03.hostedemail.com (Postfix) with ESMTP id 3442320011 for ; Thu, 17 Jul 2025 13:37:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mrly2IrG; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752759456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=klLI39Cr6uZT7YmpGU+jr7D80xjbFT1YSq1xA+hs9xA=; b=kHcUvNHsOyuC3+fbaz48jKP87ffWjD9oVqXtA+28HXddaW52C64KmVQ13j085vHVt7+mwp KFwMnDlJHzYE9vHXMoomuunKIyxmitqeMiN8kQmNZNJAsy5I2pEFiqgF7Eu1TLTOmu6uTA u5TZLG15spkqyow/SxrqAFzpBGw/Izs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752759456; a=rsa-sha256; cv=none; b=kYb/huKzbGA7LtYYhkx/fa6RTPXuz+fTo29B6aJ4ojppWoNB01RMGhFqBpkkbDqdT8inFs iFtlvLdBLv/BfDwn31HJMh1gpyHysizwUYrBpQZNvsU00bimSTX30aoJTSvevuSe6Mh7Cw bRrrsTxDj8xNfOVi3K+Za9P820hdJGA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Mrly2IrG; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 66B0260200; Thu, 17 Jul 2025 13:37:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13D2AC4CEE3; Thu, 17 Jul 2025 13:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752759455; bh=6T8wTmK1c/bVMEmHRiqoAWj+wBZhCiIYy+DHw9DywLU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Mrly2IrGsVF07td0hpdpwDm5dfaMyj8qi5VpkuJIOVWyJsBDykEYH3FYVSni5s1lX C5aNEKToNSqkQhU6cJyndq9XXz394kSMwYpWBM7Q9zjLqt0U5+slJ2Mq191OieIilR WG/h8MiotXBEVEHxmyNuAjCWyj4aGZBUIY0WMmBWdI99iDE45tRAVK3Ely0k3wuLqz MpmeZUqk8YGFnB+bTfMecGzqqf5gTJfFkJY20+8nX0oEQpv17bYvayoEnflxc+QQ66 SnQpQI0pbDMchTJJU5aeZYCUnS62WTvm1kqIB9ll0aWm/AYINwgAPoWFGewOFDU4rX BK8Zu4YNV8EHw== Date: Thu, 17 Jul 2025 16:37:29 +0300 From: Mike Rapoport To: mawupeng Cc: akpm@linux-foundation.org, ardb@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: ignore nomap memory during mirror init Message-ID: References: <20250717085723.1875462-1-mawupeng1@huawei.com> <9688e968-e9af-4143-b550-16c02a0b4ceb@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9688e968-e9af-4143-b550-16c02a0b4ceb@huawei.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3442320011 X-Stat-Signature: 7kfwwcsbstd3a436yaoqx1191kngu8ef X-Rspam-User: X-HE-Tag: 1752759456-804010 X-HE-Meta: U2FsdGVkX196ZPBNiSmgmwgCbC0qJ6Y2SsiliybbTEMY8WCqiBeL31Cpx//rKMHg0LuLUHwm0vXwIWmJg9yMGX/J+L8zIcXhm3IP18a6iFleDQA/ck3VyBJ5y4rNBfiTEuEMPD2z6eCjEboOrIJWqg4mlNI/rtWWSpW470DjMH2OL0kaAU+8+amJzHaG2rimMg692MWqoH70aeu5T2jsk8rOvscN1zVdHoTLGzwczuOF/KjuG120AzT13z4Rz+Tgb9evdGDXOTrHnS/Adu10tyq2zCs/XIgtZ2cAL+JJEloD10xAokuQ3ueXGov2QMHvKtuqDTNLqLr7d7BtELfPxEEnh+sssFQGdl8sd7NmYU8c/s2R2MyPkUgKiolXza8PqY5AuG8cxXIGJwy7tF3jBXEK4j1gJc4VD3e+DfB4rTkj7OldU42ktGbNcyrx0WIPciTXRWqKYTi1/BqrOnMWvgOgUI+ZJ8AVLmXHIqe9ybrBUe7tYTrTJ/UwTeBdNSo7CRVPwa6jFbOpF1GZMVWElNOxIgptds9pyEVObfFXQpyFJME9Xo5qO8HG75CCbpn5OUa1dgonVDqjHAE6AV3QT+gi1Wkw5mKBNfSzexV0k9MciVZBOs/B33osziFMCO8tW/RRtjLmpV5ismcOJ8p0h74hlQYh9W6DabpfTRMxNnZYo4TFJQbbvN9Hw44FqFOa/JZ7KjOXTXbbiQShU+/v9Lv28UNmdkd3dVVnfrEYziz6S0EyySRDzX9W8lnk/PiQOKxHSZBoWgINq+5JjwT00wB38uml/JarnbGcUK7ezIfsgNE+YSd53CtjDZXAQI7GXLoD9FIeDLjhuYuesSF0umDmHg2AFrdhO69EBPpZ7CkU5Q8dBwr+CbO7mvkByHWxHtp+lZSXmBo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 07:06:52PM +0800, mawupeng wrote: > > On 2025/7/17 18:29, Mike Rapoport wrote: > > On Thu, Jul 17, 2025 at 04:57:23PM +0800, Wupeng Ma wrote: > >> When memory mirroring is enabled, the BIOS may reserve memory regions > >> at the start of the physical address space without the MR flag. This will > >> lead to zone_movable_pfn to be updated to the start of these reserved > >> regions, resulting in subsequent mirrored memory being ignored. > >> > >> Here is the log with efi=debug enabled: > >> efi: 0x084004000000-0x0842bf37ffff [Conventional| | |MR|...|WB|WT|WC| ] > >> efi: 0x0842bf380000-0x0842c21effff [Loader Code | | |MR|...|WB|WT|WC| ] > >> efi: 0x0842c21f0000-0x0847ffffffff [Conventional| | |MR|...|WB|WT|WC| ] > >> efi: 0x085000000000-0x085fffffffff [Conventional| | | |...|WB|WT|WC| ] > >> ... > >> efi: 0x084000000000-0x084003ffffff [Reserved | | | |...|WB|WT|WC| ] > >> > >> Since this kind of memory can not be used by kernel. ignore nomap memory to fix > >> this issue. > > Since the first non-mirror pfn of this node is 0x084000000000, then zone_movable_pfn > for this node will be updated to this. This will lead to Mirror Region > - 0x084004000000-0x0842bf37ffff > - 0x0842bf380000-0x0842c21effff > - 0x0842c21f0000-0x0847ffffffff > be seen as non-mirror memory since zone_movable_pfn will be the start_pfn of this node > in adjust_zone_range_for_zone_movable(). What do you mean by "seen as non-mirror memory"? What is the problem with having movable zone on that node start at 0x084000000000? Can you post the kernel log up to "Memory: nK/mK available" line for more context? > So igore nomap memory to fix this problem. > > > > > If the memory is nomap it won't be used by the kernel anyway. > > What's the actual issue you are trying to fix? > > > >> Signed-off-by: Wupeng Ma > >> --- > >> mm/mm_init.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/mm_init.c b/mm/mm_init.c > >> index f2944748f526..1c36518f0fe4 100644 > >> --- a/mm/mm_init.c > >> +++ b/mm/mm_init.c > >> @@ -405,7 +405,7 @@ static void __init find_zone_movable_pfns_for_nodes(void) > >> } > >> > >> for_each_mem_region(r) { > >> - if (memblock_is_mirror(r)) > >> + if (memblock_is_mirror(r) || memblock_is_nomap(r)) > >> continue; > >> > >> nid = memblock_get_region_node(r); > >> -- > >> 2.43.0 > >> > > > -- Sincerely yours, Mike.