From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE2AC83F1B for ; Wed, 16 Jul 2025 18:21:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 995616B00A6; Wed, 16 Jul 2025 14:21:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 945D26B00AD; Wed, 16 Jul 2025 14:21:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 834846B00AE; Wed, 16 Jul 2025 14:21:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C2D46B00A6 for ; Wed, 16 Jul 2025 14:21:33 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0FDF3593E1 for ; Wed, 16 Jul 2025 18:21:33 +0000 (UTC) X-FDA: 83670945666.15.7CDCE7C Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf06.hostedemail.com (Postfix) with ESMTP id E1A8518000F for ; Wed, 16 Jul 2025 18:21:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ghG2rrm4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752690091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZnrCFtIVZL8hyVV2JzefY+gIDN+ezQ0AtgNK2sjo+OQ=; b=lj8wn5cOUJXXNP5WIpbXazhITbQQgTcJmBInBGv9361u6gJpl3WJCkzDGfWy7l6ylp76Bn /ngJQLnssapD3/rGQ8YySgOnVwBp9jd/fDlC1S5t05YdGDrPzdaiK0nSV7gcjLZfBIVWj5 1B+tYGRNFzcZVJ242eqM0nPVS0r/txc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752690091; a=rsa-sha256; cv=none; b=CiMCaCaacDjwIi5pSZ96jCnRjWab9cLWLADpGgm9iJZOsJG5bQkWcXrruP3PEN92h4FBgW dDdlN6mY01RMwqxXdVBvjOHltkTo9zfu7nseEt8duJ7Ap0bMqNYNCe0dFS0RmRU4oksqIe WI6jcl3v1+b9UbSZxiyoSbgfTlt1iFg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ghG2rrm4; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-55502821bd2so189936e87.2 for ; Wed, 16 Jul 2025 11:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752690089; x=1753294889; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ZnrCFtIVZL8hyVV2JzefY+gIDN+ezQ0AtgNK2sjo+OQ=; b=ghG2rrm4a4gMGr8uZ3paa4RdLdbMdQpd97Vtskfpn2QtSKpnfixuOOuBrvY6/CumJS Qt1bpU83gV7oWAZWGKSf5GM35b1MUhPX+IfSWYD2ykPLEnZvl2nhcXX/YZMDgnAmBAUW 1+RkoqfLz1Rb3FqEbNREPPp7tzGhClyDwCxm6DfbTYnqHd1D5wZzIK9Nl74qrMIMFo8C 3M556UpeMxSchCxHYTBdYRhAkvHSpIdYfVplpT85NX+LgK0FX5ZgB2DK6+m0SrvyFUoU VDp3KlpckZMTvu9e4FpGNwnjkY1JqvSH2OJK+FBSP3o+rW/pwcpXqirZdn68YfTT/sS2 CFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752690089; x=1753294889; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZnrCFtIVZL8hyVV2JzefY+gIDN+ezQ0AtgNK2sjo+OQ=; b=ZwsLd8e6y5RHg+xS6zpsVtFFI/tDTUQVrhyQZj4xKqiKx9RntQAcSXmLgdS3FVxQ8y +Sxo9aUu77/TCNPK/aLqHKkaXInDMb6OEcNbodWvncCI2NmXp8UHbRJKXO9J9i2mZaHM bFgPIPzIVwJnsFCA5WTEGz2JIBsb0jGHL4tm+DY4OZ6JwPPLECrNNnpoD3B0pYRyv+Yx Y++sBsxFeH879n4vCfWUnuOaVRIC5A0xr8QsaSZywCBGCiIiv6pDw3DSLZj0DhrnONG7 hhBXukx7BM2nD4v9NhO17mDjVXRpU6mz3ulVmTxlaLh1Jso/dYc8bysNOVudQWsZSe/Z 4UtQ== X-Forwarded-Encrypted: i=1; AJvYcCVeglu36PgB+GIexgDJ1iZOpdpWRDXcCI+fHPLIHOsxEzgCUSNBMXhZppR9G2qRGdjBfCWcR1G/1A==@kvack.org X-Gm-Message-State: AOJu0YyaU0OvrnWr1wHJr6eQ2yZXrr5NAc8qLdhiSsPKOM8EJ7DfMk+K TjP53IB4x0CsPwia+TXUSKyDd7oSfqF9vZmWDCrYVAV1h9VsTUQa68Zf X-Gm-Gg: ASbGncseSD3zP2CcxCpASvVcGSZ4l1PjjaP3WIGx/mVwZgbi/rw0eLOvSC/1RMXKV7y LxJOZ8nT8COSX/JVCOhTBifBTEGDLCoG5tc9hYLomZL9VHEkibxKUKuximUMO726AXqStJYO2jT f4QTNZxBSs9vXh0LeqVZa3j4xMVTRdxpr1/1DeOV58o3sBz6izabsJreR4fkvebLiRQsjPv0Ljn FEJ0VRisA6LwupLLkUhEaBVKDdoeIAlYuONU93sE/LoTjPM4R7wwg9/y2ZnUZvuYK257ooo2xV4 mEaYX4fVg2FQAoSH4By1x8iPdyoZ6Okzk1Sfdzny1GDHsvA9xxDtChmgoAcli+5UqMwCwY2MsgZ ecbUjebhSO5sRxcf8jCiUDTVy9mvNVSRvSfH01O5KI5135riVGYU6BgVJfw== X-Google-Smtp-Source: AGHT+IEQz/zAiPjsnW5zYim84jDmcgUqNS4qYdyO0Gc0hROsmXxeu2rgPFlRY76a52RFnXIwzEU0fQ== X-Received: by 2002:a05:6512:61a1:b0:553:314e:81f7 with SMTP id 2adb3069b0e04-55a23ef4e8amr1113594e87.17.1752690088553; Wed, 16 Jul 2025 11:21:28 -0700 (PDT) Received: from pc636 (host-95-203-27-91.mobileonline.telia.com. [95.203.27.91]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55943b6bb54sm2743150e87.179.2025.07.16.11.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jul 2025 11:21:27 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 16 Jul 2025 20:21:25 +0200 To: Marco Elver Cc: Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Andrey Konovalov , Vincenzo Frascino , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Sebastian Andrzej Siewior , Yeoreum Yun , Yunseong Kim , stable@vger.kernel.org Subject: Re: [PATCH] kasan: use vmalloc_dump_obj() for vmalloc error reports Message-ID: References: <20250716152448.3877201-1-elver@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250716152448.3877201-1-elver@google.com> X-Stat-Signature: ciumzjf6b3m8uj1hpo7m7owziuwwchy5 X-Rspamd-Queue-Id: E1A8518000F X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752690090-636798 X-HE-Meta: U2FsdGVkX18Yzo1cVeKJxw4ICqdNuceQI5meUY1udvIB5oTrJ1aBP2L9BcyezC/LlPy8CMvm0zQv5PghrDdOcpoMmpx1f7uJI6XIt29b+wkh2V/o0zMy9haItQKINQ3yQuA3jZ+PnglcZ+8+3+LKRWEwK21Y+ygH4kjg4DJTEgQPTF0YWFLu+c/V72mjSB/OvwT+Z5lritXj+bERy9/6M0VvHU7U3IM+9oW3h6szM/27fCO16E7aT+yAQxTcyypeqVeyfECQd35JQZa5Xtu7x3z5I1vujyUXECjmSm7mRORuTyXbmF7PEDzm04Eqfzzl33tkA3JOnIPrnznabl6Db0OkrRwbRdLFO9RL05dgfM2Xauz/k0u7Jhp9qXxfF7WdTQvApKYF7HpFAEvgEYjuyP1rfVXlTTnmbOvpGg2E2LO4jNNe2vWACOlT/AML/uCDjTVnNt60ldzAX3TwsJaCSiSaF1nhV+wgvf40X1+E6t1Qn/YPtASAzweqWQ+AL9RGbFse6mw9xJV3lvGfI5mC3jfTV9NAO2srMDcazpcPjWsTaymt6g1YfgM0gI7wP01/ZBdVXFZTqGjfzTk2l5r6fQ5q2nXmiciRH76x0pbeg1zt/rJVfJuGw/eJrZgUNjM0QbVKPG+5XkEHEl8PM+trIgsVmMwEZHLTkJx3zGCQ4Ispl5uSd03OCpb8ECba+bgjYlQJ19lPiFRhVe/C30oowR1lUsGStJXm2eqPLOfW82ERUqI51oi0ysRZ0mQY9zk1rmPcuoygF307cCHML4hiuuPJNI1u3UPmy/4TzJa3dmoFvd/nY8T0qS4gm5ZWBt2HbLddk/qaiXAtkj/duN0QzpZdY/icL6hB8duaNijE7B50RuelsB5ZiAuxhUU8bapTfgzwq1UQ1/QNAS/DS1uoyl9nAZezbaCaW0ZPwY3ykk4lM4uoZHxcVdBzEw8+MtATVBWX8b8i4GIlJxVNUjL vju96giY KqI9Xe6PwXL4WO2gjNBoMiacAyPCMJRYrF64UbH0RCp6hXkgM4joQPtI36HTc7X2SE4A/PZ//vtXfKOOzTEjzelrKXA7d/Sqx/RX8QJBuxSGJ2a61DJ/4OHsioGJqq36tjXeWvheZ/Zrj2FfW0q6iuX/6Dlm9kLHtE8rlIxZKntb1DDuuj2MjDjcmfn/fQwzwolG5z91ikO1isK+NCbwsrkDvYcG8XQRiTAhMUlniaus44VCgukaVz3yxJBbi0PWl7nNPAoi6hGkhnVXMM1cUuII8aXmedU1zMZmWg3xrPXmjXTduv/7D21lkXcn/BrgE/qewwRAkXfK0uDNak9WLawqBpwERrdVBuXXJqnhSwrp3nMD9KGF1KZPozvyFZcUPzr6cwc5PlJRZxO/f8cGpnOurAONu9Qc0LZglbXPynmwVPNZa+dDoop2/8bXfCrTCfCuqLzFc4zZHcfW5y5fLeZHo+uLIghBE0kGcWVTlo+WMCUrhtRidBsk1EwgfnXlYjsF5xasWUIS/x3vK1K6kjyqX7ZvWU3hqRFbvYgzzXHpbMH6UVsffUT8LZpYpTYzH7f9f0qZTuK69MxWXf/4QjApnkDWqxJAGQD0oyGuiC+OgxgyHsXpX4JRpGbNI0ue76k9d8dN4VtCh54yjduvNcyz3yU0BvGY6RdsqPtWOCXhb7pCk2SNn1jYahodog+D86xWr8h2aIxT78+C3O4jlWsNrxBbMhkhHDwDWyZt6Mlt9mRqkFSaIc+MHVwJQeUCDtKV1TReA0mLMTE0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 16, 2025 at 05:23:28PM +0200, Marco Elver wrote: > Since 6ee9b3d84775 ("kasan: remove kasan_find_vm_area() to prevent > possible deadlock"), more detailed info about the vmalloc mapping and > the origin was dropped due to potential deadlocks. > > While fixing the deadlock is necessary, that patch was too quick in > killing an otherwise useful feature, and did no due-diligence in > understanding if an alternative option is available. > > Restore printing more helpful vmalloc allocation info in KASAN reports > with the help of vmalloc_dump_obj(). Example report: > > | BUG: KASAN: vmalloc-out-of-bounds in vmalloc_oob+0x4c9/0x610 > | Read of size 1 at addr ffffc900002fd7f3 by task kunit_try_catch/493 > | > | CPU: [...] > | Call Trace: > | > | dump_stack_lvl+0xa8/0xf0 > | print_report+0x17e/0x810 > | kasan_report+0x155/0x190 > | vmalloc_oob+0x4c9/0x610 > | [...] > | > | The buggy address belongs to a 1-page vmalloc region starting at 0xffffc900002fd000 allocated at vmalloc_oob+0x36/0x610 > | The buggy address belongs to the physical page: > | page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x126364 > | flags: 0x200000000000000(node=0|zone=2) > | raw: 0200000000000000 0000000000000000 dead000000000122 0000000000000000 > | raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 > | page dumped because: kasan: bad access detected > | > | [..] > > Fixes: 6ee9b3d84775 ("kasan: remove kasan_find_vm_area() to prevent possible deadlock") > Suggested-by: Uladzislau Rezki > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Andrey Ryabinin > Cc: Sebastian Andrzej Siewior > Cc: Yeoreum Yun > Cc: Yunseong Kim > Cc: > Signed-off-by: Marco Elver > --- > mm/kasan/report.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > index b0877035491f..62c01b4527eb 100644 > --- a/mm/kasan/report.c > +++ b/mm/kasan/report.c > @@ -399,7 +399,9 @@ static void print_address_description(void *addr, u8 tag, > } > > if (is_vmalloc_addr(addr)) { > - pr_err("The buggy address %px belongs to a vmalloc virtual mapping\n", addr); > + pr_err("The buggy address belongs to a"); > + if (!vmalloc_dump_obj(addr)) > + pr_cont(" vmalloc virtual mapping\n"); > page = vmalloc_to_page(addr); > } > > -- > 2.50.0.727.gbf7dc18ff4-goog > Acked-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki