From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CA2C83F1B for ; Wed, 16 Jul 2025 08:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52C0A6B009C; Wed, 16 Jul 2025 04:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5D56B009D; Wed, 16 Jul 2025 04:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39DFE6B009E; Wed, 16 Jul 2025 04:15:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 26AF56B009C for ; Wed, 16 Jul 2025 04:15:14 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B3B15802BE for ; Wed, 16 Jul 2025 08:15:13 +0000 (UTC) X-FDA: 83669417706.22.F96C021 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf12.hostedemail.com (Postfix) with ESMTP id A00974000E for ; Wed, 16 Jul 2025 08:15:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yNm/reCG"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RWidS2MG; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yNm/reCG"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RWidS2MG; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752653710; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jkSgIZSLDUxZGJTDY6g7f04pt3NDA9wqvE9dGLy8T3U=; b=zNY4MKGA+dHEbyICavu9aXx5bh0ndaMsb/eTHREoZ+642CYZdnlRSeRFqv2mnwXqtT2tL8 ZFD9mR6KpGy+KK12xezKA97g5E+99fA8bfl8JWvkwQXDI7J9uFEKQiNOiZjFGERWFf5bv4 Tzml07/6nKov1RVWfSZfStbELHkV6m0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752653710; a=rsa-sha256; cv=none; b=6/H/GGklbrL1K1a859Xz4FL1ZOvAAG3fIgxhiM6F7wazvFbdo6uA+rWKogUbvmvAc+fqfs T++aGhAhSCQAXPvxP19YddOFF4yn3JGnHl/tI6Ailt/mEIo08pwYzjbkUxzYODadIBdpdZ btSA6XoG5xw8NIdua4OOzleOoXGmCes= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yNm/reCG"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RWidS2MG; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="yNm/reCG"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=RWidS2MG; spf=pass (imf12.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B91CD21235; Wed, 16 Jul 2025 08:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752653708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jkSgIZSLDUxZGJTDY6g7f04pt3NDA9wqvE9dGLy8T3U=; b=yNm/reCGnpS06F2l9+0Ry+8Ejjq4CGRXtL+0STIy8ioMEUP1Djxt0KkgGMQPU5k0wm9u4d iOk/WQMGXfbDv4a24ny4YRvOQUXjHI7KRTRxVx1kn5vSqxq0049/OdAmX4pTJ3xt5MsmNB VULt+jCl2uroaJfVB3wWDgXYRKxzxLQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752653708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jkSgIZSLDUxZGJTDY6g7f04pt3NDA9wqvE9dGLy8T3U=; b=RWidS2MGx9plftoxMQMTNCZGN7vfWKVczAox/HX8yN9FEL66POamEEvVsYYl82h2WpaUyv HL2bIvusC0OnzCAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752653708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jkSgIZSLDUxZGJTDY6g7f04pt3NDA9wqvE9dGLy8T3U=; b=yNm/reCGnpS06F2l9+0Ry+8Ejjq4CGRXtL+0STIy8ioMEUP1Djxt0KkgGMQPU5k0wm9u4d iOk/WQMGXfbDv4a24ny4YRvOQUXjHI7KRTRxVx1kn5vSqxq0049/OdAmX4pTJ3xt5MsmNB VULt+jCl2uroaJfVB3wWDgXYRKxzxLQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752653708; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jkSgIZSLDUxZGJTDY6g7f04pt3NDA9wqvE9dGLy8T3U=; b=RWidS2MGx9plftoxMQMTNCZGN7vfWKVczAox/HX8yN9FEL66POamEEvVsYYl82h2WpaUyv HL2bIvusC0OnzCAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 284E6138D2; Wed, 16 Jul 2025 08:15:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id czrGBItfd2jfDwAAD6G6ig (envelope-from ); Wed, 16 Jul 2025 08:15:07 +0000 Date: Wed, 16 Jul 2025 10:15:05 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Jann Horn , Pedro Falcato , Hugh Dickins , Lance Yang Subject: Re: [PATCH v1 7/9] mm/memory: factor out common code from vm_normal_page_*() Message-ID: References: <20250715132350.2448901-1-david@redhat.com> <20250715132350.2448901-8-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715132350.2448901-8-david@redhat.com> X-Rspamd-Queue-Id: A00974000E X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: wbnawwwctw4hrgaowj9wznuh9eb898eb X-HE-Tag: 1752653710-614224 X-HE-Meta: U2FsdGVkX184spskuHhXYHPBtPfadNWjdQ6nsCvYc2eXlSfic2sX9mSHw756j97SgNNtnI+ZSiOfA1v/Z5oQ9KnXkXLPrJPWNpg4hUO/cYlYvP2Ye/m28SfcmupCkjTEGVZQ/ao7i5y5fY5uU4MO7k0yqsDWkJ5OlRkxFzbnVKG1B98J+udnIMSlrhhRRbi84qtdhsbeu9gjwohxduhHzT2+E2Gh4VHhq/O5/7QajnEwEkm9ey8DJth2tlLckVds2wp9wefJMOhu1ylSruwv+BST6iunGNtI53BXiYOa+QFZ6td0d0+xTMWYPCxvuN5V+6chkLR2sAkQ4SNY6GGCm93A1w2wI4mRP7H/sz85JDvzA8vS1cRbXZEsohCuh4hZns8woQ+brKczHY4kkeMWUXBj144WlDv5DhuFBC9QXyJm2XiCg1jkIFRzbqaW0jQBJ4PFf62HHStraHlcg8EEW7XtYq77Q19J+jqnfkDg/vo/jnilsJAWchrDFOviRjPToz36v14gUXgLQkYVW97+IA2odtxhQ4zd+EOrxNi2KZvTPqXvHkYi/qjCFYjBOSi3vV9eUmIRC8JyJBPBLEtW/aqwFXHUsjP1BiiXGIFt+veGRXEjNgR4fYiEw5B/dvN941OzIN06kZdGPL7oKdw/1ARktTGcaUi5PvS13iL5qbLM3kvo8Ncuyzore+G1x//8P4jDLNfv3ijrBUvNymsZDHc0GFT2TjUjYCCCGUMGMpVxzsvuHpNqXX3BMRdnLQyHmrx8xSzDaWYsUIBGyQ9RczryE/f3Kg6cGNQn1umx3RaglD+4k4IG/pxdYDAuxvUH0mB6jGU8TcibKsKWyv79E1po5zxmkW9vCovv/tyIEaNDt/337zxha1l1kBSb/ETqdykis4/FQUY3kq5WquZ6HZOd62WTZDTx5gFQHn8VRJst9DV/BCQBJMizz2apqZiuH3Fw2cBkd8nBP46Ub8r 5sH98KPN iSoovbWtYxdSxg1ne8j6g58CZwD48F34uXZawqBJI2rZzuckJ7pJROazeLsgyTafs4Czv3vMH/Q/zBK6ZrCn6nJgVae07L76ePeFSmesllx8wPxk8NOH0Sy6YSBflfRJgIlfMJplZRhh5LFU7bEhEGmOHvmxfDRYrl0hRcEj3f8SWSMa2esCYXjvits6P+aGBo7hfS+DMTWuDpxa1S3SBGxst85fpGx6c9QMTWqxmbDPlXOc5KJ2efconQiSEGOIkzfX3EbTPRyaXeAzu8W8EnNI/9VTJ2Li9EuaQ8jjSSFZL8AsdczBNPc95W1BrzRo/HcnnafdPRc2fxyk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 03:23:48PM +0200, David Hildenbrand wrote: > Let's reduce the code duplication and factor out the non-pte/pmd related > magic into vm_normal_page_pfn(). > > To keep it simpler, check the pfn against both zero folios. We could > optimize this, but as it's only for the !CONFIG_ARCH_HAS_PTE_SPECIAL > case, it's not a compelling micro-optimization. > > With CONFIG_ARCH_HAS_PTE_SPECIAL we don't have to check anything else, > really. > > It's a good question if we can even hit the !CONFIG_ARCH_HAS_PTE_SPECIAL > scenario in the PMD case in practice: but doesn't really matter, as > it's now all unified in vm_normal_page_pfn(). > > Add kerneldoc for all involved functions. > > No functional change intended. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs