From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27547C83F22 for ; Tue, 15 Jul 2025 20:18:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 207986B009F; Tue, 15 Jul 2025 16:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B7AE6B00A0; Tue, 15 Jul 2025 16:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F4F36B00A1; Tue, 15 Jul 2025 16:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 007EB6B009F for ; Tue, 15 Jul 2025 16:18:18 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A5AABB6D06 for ; Tue, 15 Jul 2025 20:18:18 +0000 (UTC) X-FDA: 83667611076.23.7D22277 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf17.hostedemail.com (Postfix) with ESMTP id 46D7140002 for ; Tue, 15 Jul 2025 20:18:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jyVCCDuM; spf=pass (imf17.hostedemail.com: domain of namhyung@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752610697; a=rsa-sha256; cv=none; b=1GFIE48s1z5EZDLmiJ3fUVqnX+k8Yz+osQ1V7tdDz6vZXSzeVgWwuaMvZVZdh0e+gJnvQ+ ika8EAI+BTZoQOLNptnILfZqF+nqHm0Ou4gY/w9U5DI4/vUaGfdmf5z6Dfq650andEwh4s 0plRCdt8kLZrWHmIhRf1ftitkrjeG8o= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jyVCCDuM; spf=pass (imf17.hostedemail.com: domain of namhyung@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752610697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ai08b6INcetOL7o/zIVQke3Te6A5Fmobw5pz/jlA9g0=; b=leSd9eELCHf5Xbhwj3Jsy0QV21750/J2r2h9V9iGTbGQRqXyf1egbVWiXWfO7/S6Y0rutP CeEcsQZaxuB9i4PFY8eEpF92dDACQlYXBSTUHf3FFD0RRmCrhtVhz9m5iE+zBbTOVJwym7 xC1mYxm18TAsrl8tMvGVhfnsV+DQpMs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9B7C161462; Tue, 15 Jul 2025 20:18:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 867B8C4CEE3; Tue, 15 Jul 2025 20:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752610696; bh=PLfZVjiWCJ9WF14jCAJgKwD4VJ4Dt11gzQfmw+/2c3w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jyVCCDuMqPBzMTOlmzPDbdUwwqhOPgyLtx3ZhVBAuEnk9j+E2uv0m1iIg/M3X2T3P eRwvimDqdtiR5EoCNbTtsSgNZB/5bpE8BjcYO6vKZEvXPFNXcOZ/KNOJ8sbt/dxoUL jdraJ6hFFwOnEWhYdfO7uifUJS07RNmufbn0O50JCFAmasowEJIjWsMPR+QjB2kkOt TGTK+W8WAZaJNcY5SHJ7bqYYDIxnmMrm+F1p5DS/dlOWoqfbIDoc6qXFcqtzSISmSZ 5NBaxlPvaTw3MxArqkDBWLig9VJbd7r0HE2VvIsaMCbqRQdFqyvVHrjmUGuN6wAWlM +oUxtlbQL1T5w== Date: Tue, 15 Jul 2025 13:18:14 -0700 From: Namhyung Kim To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, david@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, acme@kernel.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v5 08/14] perf bench mem: Refactor mem_options Message-ID: References: <20250710005926.1159009-1-ankur.a.arora@oracle.com> <20250710005926.1159009-9-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250710005926.1159009-9-ankur.a.arora@oracle.com> X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 46D7140002 X-Stat-Signature: psid9mgf4ekae78nyf4kkqm71hharc7h X-HE-Tag: 1752610697-464583 X-HE-Meta: U2FsdGVkX1+s2CUjWNfoD7pPZ1gtHA+MkMSJQEEXOdoJvJGrkivRBH2vyDCdxFZEV2zLCUg+Ia0GqEn9BnaSTt6yINDFZ6V00ctfllwo3mtvgGuFvVMWLJYsqJTV/GfjcZps372DSBSYxLv3vZSrfHWNdRyEzRBVZk+uTVkUy7q8QZDyvQ8fmemiCZsBOXqJbcAXMfbW1INrQ75m3fUqOrxznAFIo4Mu/07lRfMw9o7858Cp0bChBDnP9gATWuoDbsGCTEedjfUHIrqjaK3cbaG2iez96JNAy0OEoGlCFia1w5mE5xn/krMDM8vsRutGT0EGfexWJ7shqvCENKlZFgO3fz6FrTMlPDpgjkbILbCq7NJhBD+KLBDdhP87xiYAmeVA2jchrphpHXwVe30VEVrUhdlO41vYdlvoqW4rLyf6XI1j/ifCstqBiI0F2rZl/ZyzFS8KZd2+g2C+v+Pl9Cy+yoL+t+ZRAIAMhVC+XzmMYONjrByIrqvwCHEoj4f1jepR/iMadCW0UT07edxl0vegWIacQ4C+CnTI7/DCZhWcBjxbNnO0nFw698o+VdZjyXjwKoHI2Iikfx5+ftchIm4ed7Nrq60mVubnHeZBKs7VIEVH8GLt+RwLZPKyHjIkfnuZemDXjHS4CjYKjnzKuvvhC8IKt0Q9wQPlkT3PJHwaT9vNKczjN9tuBbD12P31PEAQPnpviDZYFSM1UT0ZPs38fzryLlHovZ+rFj5cqrjmiEPybrmUUKFHRISMZoZe7RrQAf6UYj/eb65wA4LpO44DWpBEQoUjjQp8KIYNgFiKBz21daNSxFbgDAgSz0blH/iGMe3EO/gnZSseilVzxKnip4YV2EYeiuuMVIgbvu1ffLw7L+OnWYoiouE56A3t6LfMMtOxR8dQ5b5vcW4w5tUorQkdf1i2GlCGbatOf1NLXIj0iFnZUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 09, 2025 at 05:59:20PM -0700, Ankur Arora wrote: > Split mem benchmark options into common and memset/memcpy specific. > > Signed-off-by: Ankur Arora Reviewed-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/bench/mem-functions.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c > index 412d18f2cb2e..8a37da149327 100644 > --- a/tools/perf/bench/mem-functions.c > +++ b/tools/perf/bench/mem-functions.c > @@ -41,7 +41,7 @@ static unsigned int nr_loops = 1; > static bool use_cycles; > static int cycles_fd; > > -static const struct option options[] = { > +static const struct option bench_common_options[] = { > OPT_STRING('s', "size", &size_str, "1MB", > "Specify the size of the memory buffers. " > "Available units: B, KB, MB, GB and TB (case insensitive)"), > @@ -50,10 +50,6 @@ static const struct option options[] = { > "Specify page-size for mapping memory buffers. " > "Available sizes: 4KB, 2MB, 1GB (case insensitive)"), > > - OPT_STRING('k', "chunk", &chunk_size_str, "0", > - "Specify the chunk-size for each invocation. " > - "Available units: B, KB, MB, GB and TB (case insensitive)"), > - > OPT_STRING('f', "function", &function_str, "all", > "Specify the function to run, \"all\" runs all available functions, \"help\" lists them"), > > @@ -66,6 +62,14 @@ static const struct option options[] = { > OPT_END() > }; > > +static const struct option bench_mem_options[] = { > + OPT_STRING('k', "chunk", &chunk_size_str, "0", > + "Specify the chunk-size for each invocation. " > + "Available units: B, KB, MB, GB and TB (case insensitive)"), > + OPT_PARENT(bench_common_options), > + OPT_END() > +}; > + > union bench_clock { > u64 cycles; > struct timeval tv; > @@ -84,6 +88,7 @@ struct bench_mem_info { > int (*do_op)(const struct function *r, struct bench_params *p, > void *src, void *dst, union bench_clock *rt); > const char *const *usage; > + const struct option *options; > bool alloc_src; > }; > > @@ -230,7 +235,7 @@ static int bench_mem_common(int argc, const char **argv, struct bench_mem_info * > struct bench_params p = { 0 }; > unsigned int page_size; > > - argc = parse_options(argc, argv, options, info->usage, 0); > + argc = parse_options(argc, argv, info->options, info->usage, 0); > > if (use_cycles) { > i = init_cycles(); > @@ -396,6 +401,7 @@ int bench_mem_memcpy(int argc, const char **argv) > .functions = memcpy_functions, > .do_op = do_memcpy, > .usage = bench_mem_memcpy_usage, > + .options = bench_mem_options, > .alloc_src = true, > }; > > @@ -453,6 +459,7 @@ int bench_mem_memset(int argc, const char **argv) > .functions = memset_functions, > .do_op = do_memset, > .usage = bench_mem_memset_usage, > + .options = bench_mem_options, > }; > > return bench_mem_common(argc, argv, &info); > -- > 2.43.5 >