From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F27C83F17 for ; Tue, 15 Jul 2025 20:09:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E53516B009A; Tue, 15 Jul 2025 16:09:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2B436B009B; Tue, 15 Jul 2025 16:09:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D686B6B009D; Tue, 15 Jul 2025 16:09:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CAE6E6B009A for ; Tue, 15 Jul 2025 16:09:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9E56610CB79 for ; Tue, 15 Jul 2025 20:09:56 +0000 (UTC) X-FDA: 83667589992.10.CD4890D Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf11.hostedemail.com (Postfix) with ESMTP id 0B43440011 for ; Tue, 15 Jul 2025 20:09:54 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lcMbcwTd; spf=pass (imf11.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752610195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BtsIubo6B2wTuiQ5hEy7rxRNY2MVabILtqsxWJcugFo=; b=6H6hinUr4MQPolUOS1IMhVYQMQTDO9NzTEccMfx+BURlEL3b4oDsJYZsDNJCqkLFVs62d7 8+huSiqB9xNOklp5qVAhKyeTPIZvykdx+xfsfvgsOYbbUc62SsbJFtJMShZCoOSg3QvkuC BiFB7y8aLR02HTAqAn6V/kjrS1Jm3DU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752610195; a=rsa-sha256; cv=none; b=iRR1wLfhyq5N2RgvmyyoOQo1wsEk/WPCSt/IXiydO0sHKLcHatj9tdB/qjGBdp2speCVNd cVUt2mgSniXe8nLQaRcQRCI1trYoYxfq3a4QUQEw3kb2738AfxjJkTRVPu03CJ63dug//2 ynBxixLW2t86qiST7kS1bn/vkd+qyfQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lcMbcwTd; spf=pass (imf11.hostedemail.com: domain of namhyung@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=namhyung@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 728FBA57162; Tue, 15 Jul 2025 20:09:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53804C4CEF5; Tue, 15 Jul 2025 20:09:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752610194; bh=Q9cYMUnVsqy9zgA08E5wnAg8X4F1feIzSkYK2sNicZs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lcMbcwTdP4CqQwvr0aZozIf34ikYuyeKHIfH1yDGVKPlmn5rCk5Z0nJ3Eb+a+L9VB /Dn8MLRpkW9PPG5c5JMQD5GB7XYNs+gcv8WbnGsC/uxZ3AKBI7KwyNIVPJzupBt4Ia g+ku3MiFnEEHUyw4JjHrOpFw/nwCdo9TSCst9c8XkCgpCZXuYSt06EN8Ww2hU8MCMA F916f1lqjaxuD5lzQUlDzjcdSGCvw4s2lNrYHrAJ4f6WoMiOaDj7dJUpws2j22wsWK SIpjlv9Z6tlcZyTKr9CPAwQ/RmoRVUqJib5djEcCJONKTRXL02fEXGl79yjySVmPSq WyKfi8uceQzow== Date: Tue, 15 Jul 2025 13:09:52 -0700 From: Namhyung Kim To: Ankur Arora Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, david@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, acme@kernel.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com Subject: Re: [PATCH v5 05/14] perf bench mem: Switch from zalloc() to mmap() Message-ID: References: <20250710005926.1159009-1-ankur.a.arora@oracle.com> <20250710005926.1159009-6-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250710005926.1159009-6-ankur.a.arora@oracle.com> X-Rspamd-Queue-Id: 0B43440011 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: kseycuoa7atwo77ugaprmru8x7jxtadz X-HE-Tag: 1752610194-741527 X-HE-Meta: U2FsdGVkX1+mYV8HvxV5KAbTCiBBQfmev9gXScZYty9Q5aSiQWwZOwOt6HZBmzuORkY5iAeDq/yzktKFH+XUyx81yOCDUW7blvzSSf86UwIS9j8lgylZM8ldDqxayt58wcc9TuY46s17D684JJN2n6tv6KjTbilOjXB5nXCkiED7k66KJAVpW4ehXY6qiAjKtI2HmByTtKQJL23+ZZ/AZbctD1sS84QfiJ5Mn2/glb1cc99Y9f03rY/nj4zpK+rBcDnMktQJrZOY/9OeXt9p5t+Rh+L9ht3aJLToo1AAMZCJIqltZn2lhjLFMMvg0BZ/p94pukb20cKFBXpm0f83Lf33UosecCSm5P3xRVVMryICjgcEKIlxDJEs76gmz2cLRsj0WGr+Ksynw/Mv/bVJgG930X98hKp+ssuOYSKRxlvW3HinWJj75FLk2+f3TuTaCnuabruvjtkdpjrxIHmxHWk1RuHOY5kifDHl6d0/jrqPXiNNkxwaVvmwfODxjZ1zMxD+XAinMadD3HZUBg5ibruIjMVig2eLCB3m5MznL5uUT21quO5xcuDoEDS1BonxzkvRfZO3OStRxBIYM0lZy/LwmEre2W+sFWBbO8nRetjy8OfxiLoh0N5m3EmqOkubn7+E9L/8qHfhGqvl8ybnsT1PrbpLCAYAzZYm437EmBE1fFa5plA8xH/bZF8iwveB+6Rr5ATG62cq36Txh7vp4sxVCYHX/crsF30I2tFIoUyMXcVX1l9zh+CWg54JP4G1EXbVVyFY7DRIK3V6xY0qL/BgDHg3CgTOGJ6T+KeoMCcAFI8lJ2WWsqPw0t10xeHaRnYWJnlqfa59m/lMOBsrfptT7ZB0FpYzDIm+KfT9DVDtj21LJtBVh8+kjLgNmXHrwUpfOGOuHh0Ze0GpFn5KVSG+dCIEObmPJlpD36Hw6U21dQwedIo3stUu6Gr0I2HMVpe7pS5hcPG4IPN9DXm nHBvnu5w UCz/yZ0zBFnrwFzce4OPPdd3PDPJhAScWECO6DfcjUoep7GAP+5O/vyBe+5wEPmFn5uXgShWNcJIieyNMzcNds/qYef+ZuBz/LlMRStXSqqCYyACqdubHJ7FrbIVD0WY+lmN2uzweC6/4Hco4aZ8iTh6rOIsTTjcfqEUwadhnoRiKwxz2bmEaGHgNBBEQo4BaCyj4QzxtAWStnvKqhdpbO+AGllO8VGjyL3QLAJ9RMeqbL5lQWef0NmIm8kKUROhC8IaHqFlYr4Hez1sU+vu2DcjEHdCJHrn+iDd6rYQcD7FvS7BQF7qCnQIvMBjN6PWjfUIk2rnXLaktVt4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 09, 2025 at 05:59:17PM -0700, Ankur Arora wrote: > Using mmap() ensures that the buffer is always aligned at a fixed > boundary. Switch to that to remove one source of variability. > > Since we always want to read/write from the the allocated buffers map > with pagetables pre-populated. > > Signed-off-by: Ankur Arora Reviewed-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/bench/mem-functions.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/bench/mem-functions.c b/tools/perf/bench/mem-functions.c > index 06d3ee6f5d69..914f9048d982 100644 > --- a/tools/perf/bench/mem-functions.c > +++ b/tools/perf/bench/mem-functions.c > @@ -22,9 +22,9 @@ > #include > #include > #include > +#include > #include > #include > -#include > > #define K 1024 > > @@ -285,16 +285,33 @@ static int do_memcpy(const struct function *r, struct bench_params *p, > return 0; > } > > +static void *bench_mmap(size_t size, bool populate) > +{ > + void *p; > + int extra = populate ? MAP_POPULATE : 0; > + > + p = mmap(NULL, size, PROT_READ|PROT_WRITE, > + extra | MAP_PRIVATE | MAP_ANONYMOUS, 0, 0); > + > + return p == MAP_FAILED ? NULL : p; > +} > + > +static void bench_munmap(void *p, size_t size) > +{ > + if (p) > + munmap(p, size); > +} > + > static bool mem_alloc(struct bench_mem_info *info, struct bench_params *p, > void **src, void **dst) > { > bool failed; > > - *dst = zalloc(p->size); > + *dst = bench_mmap(p->size, true); > failed = *dst == NULL; > > if (info->alloc_src) { > - *src = zalloc(p->size); > + *src = bench_mmap(p->size, true); > failed = failed || *src == NULL; > } > > @@ -305,8 +322,8 @@ static void mem_free(struct bench_mem_info *info __maybe_unused, > struct bench_params *p __maybe_unused, > void **src, void **dst) > { > - free(*dst); > - free(*src); > + bench_munmap(*dst, p->size); > + bench_munmap(*src, p->size); > > *dst = *src = NULL; > } > -- > 2.43.5 >