From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16878C83F22 for ; Tue, 15 Jul 2025 14:37:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C7D76B009C; Tue, 15 Jul 2025 10:37:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79F626B009D; Tue, 15 Jul 2025 10:37:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DC2E6B009E; Tue, 15 Jul 2025 10:37:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5983E6B009C for ; Tue, 15 Jul 2025 10:37:25 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 249181A050A for ; Tue, 15 Jul 2025 14:37:22 +0000 (UTC) X-FDA: 83666751924.23.9BF2721 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id CEF4E180002 for ; Tue, 15 Jul 2025 14:37:19 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mIk1OZeg ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752590240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ssm/Pf0xPS8BgVoBR78mDi4mbuFDFYdIquwSjn1ZXTQ=; b=wPLin35O8NzDeGacaaXxvQHFpvRGPiROvVXH8Ibroxm05Z3iaXCsCo8nqtkD7SaAGJ4M78 YbyqEt74FnQyoWK42EEVR26arP5UiqVKq27nOdx5uO9uACwNR0Xnc6P9xBcdgIRFESw2QD VgUO2VSspxCSOG127SAIdbEf/seH88w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=mIk1OZeg; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752590240; a=rsa-sha256; cv=none; b=E0xOsvV+xEiMuj9MdoSw7eowbQFmTGWTjQMbnTjcF0Ygg00vu38ihq3vY1+6VdKJujLOU1 3GBUcDT1SDVniDg4xOtE2j+Gzxh3jN8YuIguJ4i34sorGTuBLn1eyUpGN1quN6j8u7fT6h aeOg/4qUo2JaTnCiGiv+ICKme/c9GU8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ssm/Pf0xPS8BgVoBR78mDi4mbuFDFYdIquwSjn1ZXTQ=; b=mIk1OZegNjGFmNKH0vvGqh2HJC gNi9amAkigliamcRDqa5VOXl0WVWqS4eKz50TizpcMpmoGdQLrtYrUdGsRy7h3TDjSjluNeuh0ZqZ dteG+sFECDlnAR95RVR1TYBBdtHyFyV4UklwRMJLX6qjzIXjPM239izuwELzNqw5Uiw5BZNjMzzWc pl/MEKGRNTyw/WUqc3q7FNX+YdQbjEBkG8ha6LspqZXgzCzGngvHMGCav1iSvNJVCnQgQO6Z0gdm7 vrx1wEoozQ4ZjLVoOB/Ghno5ah6rot72je1rV1bqdAm6ek9FLaQYsPCGFtiwfrvxAPFw22to8wbBU mYgiInHQ==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ubgmP-0000000Cnat-4BGC; Tue, 15 Jul 2025 14:37:14 +0000 Date: Tue, 15 Jul 2025 15:37:13 +0100 From: Matthew Wilcox To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , Vlastimil Babka , rust-for-linux@vger.kernel.org, Lorenzo Stoakes , "Liam R . Howlett" , Kent Overstreet , linux-bcachefs@vger.kernel.org, bpf@vger.kernel.org, Herbert Xu , Jann Horn , Pedro Falcato Subject: Re: [PATCH v13 1/4] :mm/vmalloc: allow to set node and align in vrealloc Message-ID: References: <20250715135645.2230065-1-vitaly.wool@konsulko.se> <20250715135724.2230116-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715135724.2230116-1-vitaly.wool@konsulko.se> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CEF4E180002 X-Stat-Signature: 5sux1qw3t5njmx5b3bwafmyf5c3j7wc9 X-HE-Tag: 1752590239-226150 X-HE-Meta: U2FsdGVkX1/FHK6ma/xx5czOJthyl+EMf2z5VCjESIgz5Sg1VQLUkQ6JAOJRj8/EfnAv6/hUr1L4rAlldSExoMZe8z0iqnySpPJmPZMIck6LoOjQgErwKmDvikwz1HLq2HEHjyHTlFDtRHW7IK4tW6e4rje4R8fkzr+xBxGQEJY6abs9ABVtrXtNCTJiYwp3zxlC5GRhbOumxoSWXTjXmjvpsBbRtQTeTebL0weqPhY9dxoJhsKvB5aHe/WtDH95oru6SHssoUdFHUApWmG65vUK2NnwVY8v8b7BMtGkL1+EOiLWjnrj+fpqiUsbKssUqNd+XtbOtN5qBxFS4UH9B73zgNuODYgxjErqspUVbERLn6er4p/sF5USs7VzUSlGusiy+1ZDATFSzStgd16hNh9Yba44/cJkk6lx+9b9AdZVhcLIr7wMpn3XRQj32J+6XBOrBCDImKMd13vObB3ngBfhTcbFDqx7qN9QYrjXlu6qa4bLV4mu50wmHfmtdRSk7Vt227niyYjua8FpDi0pQCmHgS94/OlRTPXH//LfwYPhndKyJLBtNDdSd1GD2qRqh3ZeqLyUz5BXDRT5hvn+zPuBDjsH7HINyLLClFWhTHbuhcsMjZT+9VNzTZyv++Wtwfot2lCRlQGaqOdGlJliDXYAYEdRsoIfNmOQizFvgCAWRTMQgMaRaX8u27AlC4GcuvCk6uj+DzCfRqM2APVu8koaj/ChGxYj4KWTME28p3hqs5ijFMiictEHl1ZJJ3RBNdiMLuq0xTouorlfrPUbIzOeOJ7jFdUdyFWNaAYsY3R13iw2bfV4NKgac1wXZlL6EKmHNCKzlX6H0vFh/LNZS32NUG1wz+oaAromAKoUXNG97gfZr8DN7CE7EUbLoeJCzVz3sAyvf/GJMtP1km+XiGy4eqJq3rpMhVdHrjGx4L450w3+QSi6yrL3msG5hvLbrCDbv2788X/EesRJ/66 dtDiil6A HqKD3H9ZEQYsR5RrntA1fwKWDH7Drcc/3TkrA7gJL2zUtaj7O/N5EgOhvT+CtluvKMZiAocNwrWpOGYNdt0wSa/L5HHAStUnfVbcK2s9HeMgJra2kFmHG/Ct0KA98+lbUFec74rCdNvmR9mOZPNzw0T+laXfqVLp/Kz7JFqzvEeLvw74yoL0NpAH1Crskn9b+Jl73b8fQSAaEN4wOotsVRl7e9w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 15, 2025 at 03:57:24PM +0200, Vitaly Wool wrote: > +void *__must_check vrealloc_node_align_noprof(const void *p, size_t size, > + unsigned long align, gfp_t flags, int nid) __realloc_size(2); > +#define vrealloc_node_noprof(_p, _s, _f, _nid) \ > + vrealloc_node_align_noprof(_p, _s, 1, _f, _nid) > +#define vrealloc_noprof(_p, _s, _f) \ > + vrealloc_node_align_noprof(_p, _s, 1, _f, NUMA_NO_NODE) > +#define vrealloc_node_align(...) alloc_hooks(vrealloc_node_align_noprof(__VA_ARGS__)) > +#define vrealloc_node(...) alloc_hooks(vrealloc_node_noprof(__VA_ARGS__)) > +#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) I think we can simplify all of this. void *__must_check vrealloc_noprof(const void *p, size_t size, unsigned long align, gfp_t flags, int nid) __realloc_size(2); #define vrealloc_node_align(...) \ alloc_hooks(vrealloc_noprof(__VA_ARGS__)) #define vrealloc_node(p, s, f, nid) \ alloc_hooks(vrealloc_noprof(p, s, 1, f, nid)) #define vrealloc(p, s, f) \ alloc_hooks(vrealloc_noprof(p, s, 1, f, NUMA_NO_NODE))