From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF08C83F17 for ; Mon, 14 Jul 2025 17:46:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 555066B0093; Mon, 14 Jul 2025 13:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 505066B0095; Mon, 14 Jul 2025 13:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F3B26B009B; Mon, 14 Jul 2025 13:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2B91B6B0093 for ; Mon, 14 Jul 2025 13:46:37 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C89111A024D for ; Mon, 14 Jul 2025 17:46:36 +0000 (UTC) X-FDA: 83663599992.11.02937E1 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf21.hostedemail.com (Postfix) with ESMTP id 286901C0007 for ; Mon, 14 Jul 2025 17:46:34 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="CIhfGF/W"; spf=pass (imf21.hostedemail.com: domain of snitzer@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=snitzer@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752515195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EBEp5CcoTT9hNXxYm/dBGWgcN3OJ78s+P9JZuoCrG3c=; b=eb6Nfd4Ya808bFOMPKGjV4bvJTF+b/oKujFgsFifh0mSAG85jStkNODGYC7Xwd2NHkSKiO J4hz+WaYNkNPclMDpbo2RPsY2vZhYcwd8yy8mmqUNKqWrevTcwFLiFF58t0N4Yie/x2p5L 6bCK01Pn6UQurKsFSWThphukkaqJlAs= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="CIhfGF/W"; spf=pass (imf21.hostedemail.com: domain of snitzer@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=snitzer@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752515195; a=rsa-sha256; cv=none; b=WkMqJhmE5C41dZk1a1bGoSV0hpV+P3NsAovPmoBiOpBKSYw6vf50lP2UjatwBIZX+ZmvTn 7XqYoJomb/wnJ4/LQOC+hz+mQv8mW1baMeemUaLx+h6rfm6F/TIvJ9MWOdpTY4Xk48qvMT Za04yNLdS8CWS0Mw9x0ZirGznI8HAuI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DAB4046003; Mon, 14 Jul 2025 17:46:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89375C4CEED; Mon, 14 Jul 2025 17:46:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752515193; bh=5PE6/IBiSWRv1ULmZKm7V6xmwg8/qTq1E3BHbh9lJX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CIhfGF/WcV3IvhroaBY+lao5QWTelztEUk92CiJ4dfA/wJHxacVJU16Kmo7jgrAS+ Xd42ZyElE+lo/Zi6YcG1FCTQ++qrzuYyZ/DSV8zCmFWS+FAcIJpDXo4FcENO6X0+jH 2c/EK8ZpUAZJvo8d9n+9Jut3epql7gBgzA9L95HDxHyKIcDqQe+LdUEnjMskVQiYe6 JVJ9MZdG63hm0xa2my2l/+fNbuUN0wATZ6EJtFQZU78ta8R5QkMwtIpLmDHGGE7Pxe zL+wR7jEySuSDs8xtB/fQ5imH4nP9DN9SFJlVw2qKrwF7h0bfiPFOFz50AOVJq+GwT 5W8J6DiH+ufpA== Date: Mon, 14 Jul 2025 13:46:32 -0400 From: Mike Snitzer To: Christoph Hellwig Cc: Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 3/8] NFSD: filecache: add STATX_DIOALIGN and STATX_DIO_READ_ALIGN support Message-ID: References: <20250708160619.64800-1-snitzer@kernel.org> <20250708160619.64800-4-snitzer@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 286901C0007 X-Rspamd-Server: rspam06 X-Stat-Signature: w4b8xtejya7kf7q57qr3ig5gma36gc3p X-HE-Tag: 1752515194-954276 X-HE-Meta: U2FsdGVkX1+xwPZ0X0zHDLaLitLi4wgGYqyomRLMPbTk5xf/PuFfHiwzpMK+jkhlTs7iESZpX2MhXjKTmJkfERL+/Okgra+h7KwwOMzBaUxCRjZvKX8KBseBgg/6rxLjLzB0Y9eSnp7adlvbPxT/eRFDDkrHfGqjK3qsBmywqWiroAx1rcB0//1xQVA0rQ5eGOZQXf3JcvDz+9XiJWeVXXtHJR3j0xeBy/Jsd4dZWlDU9F8/cCfQLMs9puE8ho+/kt+NyCrSuwyROl4rspzFS6z71eBCiJAtAmhWt7JUZAWQ5yVtd5P4E1eygpiPqTXVvuQFzplurKXf+3jeLKtHaJpkYKI0OugVXbWsNm2bj9WUgfCK0BYsxmdBec/wQ9bPq0wYS+3OLMzJ0t1hT9wq3/Q5zxJLuba+A7bp4qOPba8EvdEwWjH/8wpl8YfKDRb7wPPIEBArwsA2K2bz2ePDO216Xb7oMjih52MNNwDfAHbHWw+3x0qQqBg7hlxCu0BUA1ZUPKqMLQrSzr3KJSvzfo1SnNSKUJ0NkPTFLt0/3m/coRWT1EyDSy7Z9XgFZ246T/ssxvmt71KqO/0eh+kC79SXwsgsXUO925gLHIKDPYLe372zIt7wdeve/fpPoS4cvwS0drqEe0ursFbkVo6ckTa0VxacE8JUCnZNLKyz+odknL0YenfEdrfxc9YxVgOkWGHKp6mVGwPXFSYr+I0khT+GClMACtXAkMl8c8IBBIqG/bwb0SAwgGtsNu/phll8agUW2JhyHgZTfBTHpIiDiZRuAkleqEW7BcwR7tL9U0o65qGR+1WEqv0I0ZIf+PzfrLBTYSqo+BW7saQXoPch+F95FdmVBxjEeiCm5e31N9MQKrDktJwzgqCAEabeHvPEnkCDLL40XYpt/8AJNL/SZ3U3cOnu3SCBIyWkalEzNbV1aQ/EyqMcubaF564VYY7iieODWNqAm+zGkeQ3FX0 I/UIix33 ZNNZGBuqoUPAh2Ti2kYeManCAoj+mmFVBBTYvLfDlWhYeeHdzlbS2v/rMYHtgCTS73wnX3y/DsjkN3ITY50xSZSfJLeE9mIbKWPp0x3K1TgM/mIvM/1sF+J/lUqqqFls1nv8347FVoDMghEci0O1wgC3J31YXpEV0N4O0GuXu5ljnXTntlapU9BSrKBULKs6cVKWul2KkivE7rUC+onfhM2m3q8y/Ga2Ug5oH2YlI9nGs1mdS9VP358tYZlfbK5dPv1cDT6FdKuoatdQr1Pzbo6vJZcuBsxZnf59hfn8eGf4rvXQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 12:45:52AM -0700, Christoph Hellwig wrote: > On Tue, Jul 08, 2025 at 12:06:14PM -0400, Mike Snitzer wrote: > > Use STATX_DIOALIGN and STATX_DIO_READ_ALIGN to get and store DIO > > alignment attributes from underlying filesystem in associated > > nfsd_file. This is done when the nfsd_file is first opened for > > a regular file. > > Just as a little warning: these are unfortunately only supported by > very few file systems right now. For someone with a little bit of > time on their hand it would be nice to do a pass to set them for > all remaining direct I/O supporting file systems, which is only about > a dozen anyway. That's a good point. Meanwhile, I'll be sure to have the NFSD code (and NFS LOCALIO code later) be more defensive about the possibility of these attributes being 0 (due to lack of underlying filesystem support). Mike