From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F2EC83F1A for ; Mon, 14 Jul 2025 13:39:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1E7C6B0099; Mon, 14 Jul 2025 09:39:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECEE56B009A; Mon, 14 Jul 2025 09:39:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE4886B009C; Mon, 14 Jul 2025 09:39:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C13A16B0099 for ; Mon, 14 Jul 2025 09:39:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7064712AD5D for ; Mon, 14 Jul 2025 13:39:04 +0000 (UTC) X-FDA: 83662976208.02.E8E6A10 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 9E2F5160009 for ; Mon, 14 Jul 2025 13:39:02 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UGJj5m5e; spf=pass (imf08.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752500342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Uhi1uFmJKyPqz0Sbh3TdHMzQjP8yWANmP/X7v+lUCQ=; b=DeoIKNcJvlCsnosTq9sS19+PAGxO9tEZvF46pQ56vIQSiQFeCQRmlfJv+RXq+reuUllbKS cUvgV5QaXHU/tD7a4A9ycgX/WDAjG3SkBc1A+zFj8++BXLvAqblqaqjVojsETZWcuSRQjK x54FzH11c3rbVTfBYQT6NDiM1zyo+jc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UGJj5m5e; spf=pass (imf08.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752500342; a=rsa-sha256; cv=none; b=EaIFCEUWF2LOiYAB6FCBBgFkHmOTAHTkwyNTdC2f7xtWWTnFZDB5OuIfD1VpKUTMDwW3ck gtyaU0wyOONTqmIaTYc65802RV0jWHZ8g421WBLnzrBDd8XTZYjDkzaoDeS9fg8VoFetKM Pk9GceOaDEMON1Bf5viLXBWMyFYOruQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752500341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4Uhi1uFmJKyPqz0Sbh3TdHMzQjP8yWANmP/X7v+lUCQ=; b=UGJj5m5efMEOO7qhmytFrafyxuge3NHm1cDUg98Uh3BvUI76iVhr2q6CfA5eblt5O+7i1d 20AQR0N3w0HsSZDjBhcNz8t9KDQ0ft9A8NW6GWmoKQDoqhYKY2IDn25bpu2d2JnOHvWhA/ hEXOPEALi/+oUA/cudnpPkRPYZzx0Xs= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-311-b0nWq0qONmarVTdsqbi0Vw-1; Mon, 14 Jul 2025 09:38:54 -0400 X-MC-Unique: b0nWq0qONmarVTdsqbi0Vw-1 X-Mimecast-MFC-AGG-ID: b0nWq0qONmarVTdsqbi0Vw_1752500330 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4489519560B3; Mon, 14 Jul 2025 13:38:50 +0000 (UTC) Received: from bfoster (unknown [10.22.64.43]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1006630001A1; Mon, 14 Jul 2025 13:38:48 +0000 (UTC) Date: Mon, 14 Jul 2025 09:42:30 -0400 From: Brian Foster To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, willy@infradead.org Subject: Re: [PATCH v2 2/7] iomap: move pos+len BUG_ON() to after folio lookup Message-ID: References: <20250714132059.288129-1-bfoster@redhat.com> <20250714132059.288129-3-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspam-User: X-Rspamd-Queue-Id: 9E2F5160009 X-Rspamd-Server: rspam06 X-Stat-Signature: muazyag35ih1oq4jcndung1ziyuxzfyj X-HE-Tag: 1752500342-2311 X-HE-Meta: U2FsdGVkX18ZLexnLMtvJRvDlQSwy/vzfM8HRlE98OA1XL/qI2sK791hajT/QSNrvZ/Sg2UXE22gAosHDe+Gkss39WcC3+ioeHjeRj6bs/hWDD1g/u2WxZmU6/GtXHnmuNvo6vzWVClrWukQbR52gL9LmO4mvPkkvMW1mCW8i+v2BnpzvRobd7AlCAUmpJkLskEm4z80a0Qdr3rrjbiKRt9alZ1/i/5URAy+qUGNi0Mk2ATwPaQ+DjHWDTXBsWNpAL+4dsV/S3NQXYz7PoJpB+0UaTLu4k7ysQwojMuPkXZChiE4fRkbJO0HbpEO95p9oWEEGaLy5nhOjIGUPO9ub3nastfozDSyCOefMk+N8+PWAVgmbRZlArxBQe06hSWy3SgWtKCrIEqD7w03hEhfFRlbxgKPjTdLQIl7oO5mcFSKnWdQzskaefgKjqOYecfkB2WeXWKJDNKCoWla5xa0LnUsSS4W6ey9HHPhK67Ba3v9pBIbxJTIbExuy+vU/D1DhVIMhjatBO9EaKPhLxhxarjkjlpE2BLEuoQGDPfiXRailW7RuL0wA45JnXHxtNhW6a7QY5CEQ8tgb4PHQnPqFYpSNPhqKSpGowys0kVfG6liF4U7brgKOVlJLqnPV3MM4AU0VPYdpfT6s8sFabT471LUG0Fwqf9lZJgd5nSFv5KKSCUTO/JiAx7895bkcrjzBJkq3uHiROZ+67CfGYQpL2+KscqF17zmulWtEhcuhTw6o63n6j9bp1u0GoayBm2Oyc6kXy4/e3/Eev6D4H7EKm6BAQbJ9ejC/ZsS5fJuOkk5WSo+i1tCAKAn7d2S7w5wygWXU3ioOgJJavuMA1TLOSISTGv23ShhOSGMJGYMua1ic1PrCNEwJJnV9TpIconC1cNEY2cxvp+ulkf5ZVTXiLKKzfLSa4jT8slgebNt3PI6srUv5KAG1yyQIWZ02Lempft+bi5HCEp9mAwW3aI OBPHzUGv mQcTbQXp3XXMm3157lnS3wCt+fvgVgw4k2iTBb0+K9r8po0HU0AXrDqMT739oA/4nh1B4SH8M7wd1dnBa/QHH/T1Hj+sd6YoQ/RYIhE9W7fnlSum4k+z80J3lxMjiR0LLsGHLU9ZzJmscMxBFL3vGEU2LS1ETxCTHk5e39TPlSNhthajAm35+Rda1zv/62uteSkU9tqvJvj1RPolJzyxlKJzL4zo55cO9vcMrbqozNm6TgzE/+GGS4ys4VlPGSh8OJUH9N9jm2SDwGKt6zjM6n4toaOPF+9yl/mVI6cx+f8pLu4EIvnZyzpYn8/yfNB0iVHWM9eApLbXDZ6qzu0Tp3tuIKPmbS9juhYw9WXqE04m8a8B5YZa1mOGuJy69SExMeXKpuH3AGLHb9MgrbXujSZmKsG/3nRR9OkAtn9bo1wPdQJRjkAdVOykYqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 06:20:08AM -0700, Christoph Hellwig wrote: > On Mon, Jul 14, 2025 at 09:20:54AM -0400, Brian Foster wrote: > > The bug checks at the top of iomap_write_begin() assume the pos/len > > reflect exactly the next range to process. This may no longer be the > > case once the get folio path is able to process a folio batch from > > the filesystem. Move the check a bit further down after the folio > > lookup and range trim to verify everything lines up with the current > > iomap. > > The subject line is wrong now that the checks are removed entirely. > Er yeah, I have to update the commit log description too. Brian > The patch itself looks good: > > Reviewed-by: Christoph Hellwig >