From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB42DC83F1A for ; Mon, 14 Jul 2025 13:20:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E4638D0003; Mon, 14 Jul 2025 09:20:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BC1C8D0001; Mon, 14 Jul 2025 09:20:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F8E78D0003; Mon, 14 Jul 2025 09:20:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4F46F8D0001 for ; Mon, 14 Jul 2025 09:20:11 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 247CDC0198 for ; Mon, 14 Jul 2025 13:20:11 +0000 (UTC) X-FDA: 83662928622.09.BA6DFF9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf23.hostedemail.com (Postfix) with ESMTP id A909714000E for ; Mon, 14 Jul 2025 13:20:09 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=W104I8Xg ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752499209; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vxvVJmLInnqfnAkGgRx8h+TaUwkzoqgmAd4ZI/enIPo=; b=bICADWrkFXmZsqakf4+59oZqni0cj77mV2vsQvXfcV+fnUlQ7+NK46P3cq09OrtYkcj9mS Q7bQF2RABS9KWR/2lsoD7Zdb8Be3xpO5BaGyuurdghMQqm1Kcemuq6m7bk2GVrEm/Gpey9 tK4X/3pax4ybDLCEiOXlVKjKmjnBQpg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752499209; a=rsa-sha256; cv=none; b=hPi5lm92pldN65gOOEiDVmgfaLkGjhWSTGIcOrkDDd9HwCh1v5IPXSYCPuyUwuM6VYNlEJ OFjd3dMlJcXdj+aC7U+l7ZS2nstuS9QzgoSl2Q2pvkvaGYBKV3PmZaGlKfkOvcyRHyD3UX 1Qm7VKwShCflBZgvQm4qk3nGNNaYZs0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=W104I8Xg; spf=none (imf23.hostedemail.com: domain of BATV+8a4ed83021dfd658536a+7995+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8a4ed83021dfd658536a+7995+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vxvVJmLInnqfnAkGgRx8h+TaUwkzoqgmAd4ZI/enIPo=; b=W104I8XgUHn4nb8S+d8ARvu5Rm MF+DFr16QKthEn0jFVNpgQTOL0spakJjV0dcNZZqNs0o+x+aJOuHDRt2hSju9dU7rIhetTROHT6xj R8kWYvICnymMO4Qam8WG6kDM6NzAbsSnpQJ0+cVu1O4nBiRwT2Qhnzx4G6NHJYIB+YMy4ba0UOzBe Pc1lT4FcsBWTW6al7/xVd+5pqXhfvlrcuRQka2K7cpKxWrPB1CiWGpm9vHTG5gwtfmA3Z8e5kQ2Zw 3f60tAcTsI9ofJJ70NI9LBftql2iJKuD1fyzE62xbCPlDzVhkHDJDHMdLy1dZ951O17J9/sV+Y/TR ddDKR4qg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ubJ6G-00000002GWk-0ZL7; Mon, 14 Jul 2025 13:20:08 +0000 Date: Mon, 14 Jul 2025 06:20:08 -0700 From: Christoph Hellwig To: Brian Foster Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, djwong@kernel.org, willy@infradead.org Subject: Re: [PATCH v2 2/7] iomap: move pos+len BUG_ON() to after folio lookup Message-ID: References: <20250714132059.288129-1-bfoster@redhat.com> <20250714132059.288129-3-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250714132059.288129-3-bfoster@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: A909714000E X-Stat-Signature: j5psux4tm4qqg45re43rgtxm7zku6pb6 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752499209-395196 X-HE-Meta: U2FsdGVkX19DjotqoDnMhEmNvLvA9uHF+9g1zg28YG/goaVkEd65gImYCM/dagqwtRIb2p8JI/PUPgwspDLSlMThQXsbDkp6JiET0MGdVC3O2xI1Y1+qqPh4jKbn1gJcqhzgkSLgfEHSmK2LFgg/v4L0VnfTUi9M7UsZ5OdCEwJF3cuYlA33wbZXZZu0/a/AyF8X7gypvz1Yl6aTENtxLLVTYG/y8Fz0aluV89GCbKK0TWDMzo4NtaVJXqGCVK7IgSYDQTLdJ1G6ZvtSOJQ3lFnXDy30qPUF5f09V67TojbERdhGpNQLOTPn3zpk+KL4LHef71X4iPojyrq1UOFTBw7wtqNpTSSzBbp6fZZTB3B2GQ3EzMIznz3ILxcFCdjGoDOTlKtWwVAjaWuPKR31HRCAZjWmSFxomqxio8Nreuh9BkFUzM6bAxfiwgrCykNs05ctQ4eluGoL+TO0EZYeyAJ5IrzV1+YvRe/dufJVkCav3enwiPLlbbLPbsl0nwjNeK49ky3Dqa/nHIXoA0PetamAokO7AZPV9AUl5hOJgqxcqjmGTIuQjcNrLuBznbk4aBh7K4VcVRY7EYiktk+HOIZYiFc3o52FK1V2i4ZYQXaFMkYyrRA7MuWC8OwVItbv1qGk4kJ9RhxeYTVRXoVuQy4NKYFzGLYUKjIsgjibp/vW49QuTg4a44DBj6b9r2p8bkKz97jrnT3xRj69kENzE5VKp5oBIAJ8qL05sczb9oZT3Ou639jV5Ox6ka1pRI8Yzedd1ewvn+9N0KGqV0VtQe0bc1ql1yFtx3LzhwysiI1nDjv7qso/fB9ffcm9aZDH044dOZDXgdJ3it02KRvW5EjAK+Bf7hHTaPFW1z2JBOyKbvsoGDCUUkD528qAOonbdS4cqMiFj7vktvel3/0i1jcExlyqW2RfT86/9R/WSea9liIgAYe/mbALKU70Bzx3ZSgLpwVnneg72nLQhDm mrEi8N/n zizrujhBjeV97Ic1Q7E2cURh1APZEXjE/VvNRW/iIWonWEOO8xjS7xdmruWEc64TV0Wunk2UL42XQDrzAHfJGi0BRPZ3Imfa0kekpmgyG04M3mOis5dZo6t9mWOhXbZ9HOcPUDeAYpWJ3k9gC1H3Sfd82MeNFjug8wsITM1tSZMsj2+E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 09:20:54AM -0400, Brian Foster wrote: > The bug checks at the top of iomap_write_begin() assume the pos/len > reflect exactly the next range to process. This may no longer be the > case once the get folio path is able to process a folio batch from > the filesystem. Move the check a bit further down after the folio > lookup and range trim to verify everything lines up with the current > iomap. The subject line is wrong now that the checks are removed entirely. The patch itself looks good: Reviewed-by: Christoph Hellwig