From: Jan Polensky <japo@linux.ibm.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>, Mike Rapoport <rppt@kernel.org>,
jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Paul Moore <paul@paul-moore.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH v1 1/1] fs: Fix use of incorrect flags with splice() on pipe from/to memfd
Date: Fri, 11 Jul 2025 16:01:13 +0200 [thread overview]
Message-ID: <aHEZKb-kdpIjABQu@li-276bd24c-2dcc-11b2-a85c-945b6f05615c.ibm.com> (raw)
In-Reply-To: <20250710-geburt-aufbegehren-07813aabf939@brauner>
On Thu, Jul 10, 2025 at 01:34:12PM +0200, Christian Brauner wrote:
> On Tue, Jul 08, 2025 at 05:43:52PM +0200, Jan Polensky wrote:
> > Fix use of incorrect flags when using splice() with pipe ends and
[skip]
> > + }
>
> That hides secret memory inodes from LSMs which is the exact opposite of
> what the original commit was there to fix. I'm pretty sure that the
> EACCES comes from the LSM layer because the relevant refpolicy or
> however that works hasn't been updated to allow secret memory files to
> use splice().
>
> This is a chicken-and-egg problem withy anything that strips S_PRIVATE
> from things that were previously S_PRIVATE.
Yes, agree. I've already send a fix to LTP.
Thank you for your reply.
prev parent reply other threads:[~2025-07-11 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250708154352.3913726-1-japo@linux.ibm.com>
2025-07-10 11:34 ` Christian Brauner
2025-07-11 14:01 ` Jan Polensky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aHEZKb-kdpIjABQu@li-276bd24c-2dcc-11b2-a85c-945b6f05615c.ibm.com \
--to=japo@linux.ibm.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox