From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71919C8303C for ; Fri, 11 Jul 2025 09:29:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F13056B009B; Fri, 11 Jul 2025 05:29:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE90B6B009E; Fri, 11 Jul 2025 05:29:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E25D76B00A0; Fri, 11 Jul 2025 05:29:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D23276B009B for ; Fri, 11 Jul 2025 05:29:50 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 78D82C1036 for ; Fri, 11 Jul 2025 09:29:50 +0000 (UTC) X-FDA: 83651461740.06.5E27ED7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id B89F5180003 for ; Fri, 11 Jul 2025 09:29:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SScJ1xeK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752226188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lwMYaPUzq/Qd+bx92dlYtexu6A2vKLz+aNrtPzsMsGY=; b=Exy3x+0rEvrhBTYF5oO4CaS+GfAln59klS8dQaoQM2AeTn65nlexNaj9DjGV+rfsstdw8S LOQFsEGEiaQ/q6y3bW4tc7yPMT21UWimbV0Eln6DZ6WgSqWanOc3XuhTb2zGEK8u7w+few c2zTRWH1cRHoZ2bq0EQcwPjyqN5UuKU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752226188; a=rsa-sha256; cv=none; b=EmAoJ/OSCaVRI1mM52I0SDNGwc6neEJlnT5xntoq+oFfB7OBVFsXXJhdUgax5gwOxzTqzo B8KVag8ocv4Z4IDMHbAP9/yycptLUSBFpD/7TEm4FM/mAYLVV9LpehqN5/WdWAOCmb54rg n6wi8llkHHmslhgDdIco2iACDq1Jl50= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SScJ1xeK; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 958415C5479; Fri, 11 Jul 2025 09:29:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E201FC4CEED; Fri, 11 Jul 2025 09:29:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752226187; bh=ZAZ+5Y11qKAvm1dXLvYH4qKO4T6pRKgWPUaiWkGhIqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SScJ1xeKZ8IadNXhyFKNLEscKZfr/U/LfmpCQ/2lJey+z4CfoQnyw23bugK8Tj196 UIzmms829d5gsgvUK/98teXYjiX64VHcGexQOILcQOb1uRtq4NYI1a1RSY4gJyWunL YN2cbVXlu/CtMGx37Zdi+K2DK9QcLsDyMDiep8C6ntZXydcmoc4WmQO0VTgiFjO4bz 1JeRBxSZ3W01qgZRIoQ3Ibmgvg1S3AwlmVXUiaOJnjh5rATz4Pnr989bQDT4S3d22u Kn1WyBCic1pII+wtZQU+B3bFc8UKUQhjVv6U42VfuWxLt1qTsuAQ2oWiM67YN+PqQk Qowr5XoUMuScw== Date: Fri, 11 Jul 2025 10:29:44 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: wang lian , akpm@linux-foundation.org, ziy@nvidia.com, david@redhat.com, sj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Liam.Howlett@oracle.com, brauner@kernel.org, gkwang@linx-info.com, jannh@google.com, p1ucky0923@gmail.com, ryncsn@gmail.com, vbabka@suse.cz, zijing.zhang@proton.me Subject: Re: [PATCH v4] selftests/mm: add process_madvise() tests Message-ID: References: <20250710112249.58722-1-lianux.mm@gmail.com> <81f9a104-6d7d-4552-851e-8690d4a1b723@lucifer.local> <569270da-8827-4a3c-84db-91f715ef5c22@lucifer.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SFZKbjgBQq/vRqfg" Content-Disposition: inline In-Reply-To: <569270da-8827-4a3c-84db-91f715ef5c22@lucifer.local> X-Cookie: Do not cut switchbacks. X-Rspam-User: X-Rspamd-Queue-Id: B89F5180003 X-Rspamd-Server: rspam03 X-Stat-Signature: xtd9nnxfz67fb8then6pwnd1khbuut7n X-HE-Tag: 1752226188-407709 X-HE-Meta: U2FsdGVkX1/B3CzGbhS3Vm8JsmnIN4zP6kzTt4WfHPbvCM30CYkQZL3jwBVwLGZNSIgJJTqhqXAxRLGexR0qXw674I2D9Q96n491ikxVCiZXCroW9y7zJeE8s/CDjunqaS5k16FoEcgrWvPXIZ77qv7TIugIwvTtRm1Th/hBPb9mjrn2kYeGe87TOedBKmUwWLqmzmTt3Cg5y6oFSKynqIkzlDLDRhx2QOJ3tVmG/gQ6eyR9rcLfLWDMTgXwqFKuHejumpS8a2KF7ZtQ0b5GKl/Uox1i5uoOy/yQP7/V3iZGEr7WIsa2hKx5gXgJWtmj0+8k10trkx08qVXHi722gT1g81HmR4+zadl9CFyWKeSNbq9a0BSH40fwSLI3drC25NkiwWYL+FbA4c3DNGi3qdfvsVyvbCK/fQgMj8L0w5GCk1f8z+Bfk6GaFT5mJXDWC8mjYMNIegaoQ8mVfne+RbEhn/27PKlvwnEkLS2ZUviwegb1tLdnjiIHtzeMMRd+LFXxzZX2ZJt6/RH5nPf+pEFEmNG/FxyyHEswYEo2DU4c31qOJYz1EwaMnC00rlp1zi/rl1vgq+yFg57oAGul2J9SaLG5wNS52LaN7UXdeMwIYUuZ4o+ejpkNuYPzLDdXPD/0bbGuauzDfdgz7fbVVO8Tm0U15huT3CHYI4rLWylB1QmqFGzFUmQ+jr8pimxRFxm+kihxuHhnlF2s+NaWLKe0WxNj3US5OIPlIY7+crhoumiTKJkHlQ1vnDstvU0EV/OPedY9mJvySsSRZv1BI4EeyJtHjhlcoXAr75fp2nQiZQAIBRZDlHTPJQNBQA8Hqg3qHVqgL0OdjpsoIcSY3F16pTVK7jUNXNE0pIFk3rEhXR85Ony2IMGXZWz1IRNo9h7jVc8+3NhzCN4+6yMLAjgZmbbKLE7OFzQ85LicDJMz5Fld7xe9ziyArtTMx+RAh9MmH3owsaz+hbBg/0a hG2boSZ5 WhO4ix3SGfJpZeHrjXW6d5Efix5BkQtRrvsLrj1XqOrU5DUoNyCvTbKj9WTQln5kJcXJ+oBaj2whnkcQlVc5JKiPWILfYpIFXUXvdme6L5/PDSCkJTHLn+/3DquXyKcIAC6DYQrgfn0S8l55IkI9bNPGQzhEawig7xIExicdYM3H6PH9TNkSyRnb9HsIypaAZ0SocIMK1/BGe79cO/b9wIOeDcwemuUZuqGjnT3SXvwClJD3v0xmlfNYKKYYDYoVWjqFwXdFd0YErTqhWaTFXdlSOm5LWj8rmLLHmIJv4d7Ah12im/4J3DXJN1dtO1bhSooK68LhYJoRObPdemZrUHHWK589pHKF3WeeECUHDDzJrAIq7vB3kgaqE0kW8lr576Kx6nLGADLrCUdQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --SFZKbjgBQq/vRqfg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 11, 2025 at 09:53:10AM +0100, Lorenzo Stoakes wrote: > On Fri, Jul 11, 2025 at 09:11:47AM +0100, Mark Brown wrote: > > One thing to watch out for with peering into the private header files of > > other selftests is that it's a routine source of build and sometimes > > runtime failures, people have a tendency to update one selftest without > > thinking that other selftests might be peering at their code. The cross > > tree aspect can make it painful to deal with the resulting issues. > I take it from the lack of reported issues this hasn't happened in reality. That's a general comment about this pattern over the selftests as a whole rather than this specific header - if this one has been working well then great (I certainly didn't run into it myself). In general I'd say this pattern is up there as one of the most common individual sources of build breaks in the selftests, and often has a relatively high level of friction getting things fixed compared to the others. --SFZKbjgBQq/vRqfg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhw2YcACgkQJNaLcl1U h9CLEwf/ZWeg29sShJdmo1DWOnsYSf29FpSHfH2135dGeKf0J7qanbDbzlmhfIkX UoJgs3j0OFL4hr3g9KTTqdGGevlHT2NBcX1hY3JG3Xqx3tG5i4xbG4tXQaDFxCTf qH2gllx8AOhggUSdSAVge4/jLsKcwnovp3chXzCZpBsSBqIgQB0LnSG6TkY0meYJ hK0lAxnX3UOBmd3Lsd7qdpuz0r815Z11hntEUjejGwVUaLKMpDmR7AblyUZ6lwSI AYdL5Vv447Gjcc6ajl4ORTrNYKh4jsEOQVptictoSwy3iYxuZ24JJ8w0k4HzL2NT 8s8zrXM5H94bGESAcdET8n6gBKSH+g== =WTBl -----END PGP SIGNATURE----- --SFZKbjgBQq/vRqfg--