From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D4FDC83F1A for ; Fri, 11 Jul 2025 08:11:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CE646B009B; Fri, 11 Jul 2025 04:11:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A5F66B009E; Fri, 11 Jul 2025 04:11:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 294AE6B00A0; Fri, 11 Jul 2025 04:11:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 184E86B009B for ; Fri, 11 Jul 2025 04:11:55 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8BAFCC0D2A for ; Fri, 11 Jul 2025 08:11:54 +0000 (UTC) X-FDA: 83651265348.10.B8412B0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id B7F671C000B for ; Fri, 11 Jul 2025 08:11:52 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kRh9y3+E; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752221512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GOZ3qXtZX8ilX0blWqFBgJou8xiklVVxmd3XUazWVkw=; b=u7qLgJWFXW+9PJKgwJ3jo3xC5tBCbMoIy4vdIkFxL6y2AIQv0O95H58jQIKPSuRnSU7GB+ ijtF1RfIvlpzIgwqxOrgzyraqhKw0DcU3AaTuqHyCGCsrrF/2oyjLCrbqE9OQH2uumoLdU lg1Q9LAQgL4o5LfI6GE4DzkKa1V+G5k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752221512; a=rsa-sha256; cv=none; b=LRMOPzKQNTh35bkAlD7EA25cW0eKq7pk2Ro5N/fbupwtHheB43h/6A2t4mVMCIOBIv5n5R MevF2sVgoEV8UTK6S0c+s+O2cxzEstlCBivGHsg7xsxmzXKY8B8VkZmVl/IxkSCiI9LDBH 0BTbTcWQ5ggfmGIoYtdsY1lkoELPobc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kRh9y3+E; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E24665C6B8A; Fri, 11 Jul 2025 08:11:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8952C4CEED; Fri, 11 Jul 2025 08:11:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752221511; bh=hBats0wOEkeXVrWJcZXz4Tib1MVX0DvTh0e9YuBEi/8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kRh9y3+EuV+xzIfX2kJSHk/AZ/GwgX1guRRSw5leHLz7M8Muup3jJQ1ZXYiU7ahn1 CTjJmJlogTLdSvA+SM3VUFmtc1J1OIYAgSqbZWbxiPFYRVRzMKu+LjhSQKRnI/Bqov tlQRoA1u4v/UrWVUuhZ0oblxYdWxlJcfZiH6qyJGFzwGIRfAmkVR87fwwxR/bHF0dy /uspO+GVHrjXg7eyK77PmOga29jUtJp5CI+vsmvAPBRYEtfYRp4sbMGOCihcO9Gqy6 XJgn5MW+F6lpuuhgttqhaE5YyFTuvHoTqFfXSctImFwf0BWdHmbbdkKaDvqsmD4hKs gVCykGhzf2eFQ== Date: Fri, 11 Jul 2025 09:11:47 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: wang lian , akpm@linux-foundation.org, ziy@nvidia.com, david@redhat.com, sj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, Liam.Howlett@oracle.com, brauner@kernel.org, gkwang@linx-info.com, jannh@google.com, p1ucky0923@gmail.com, ryncsn@gmail.com, vbabka@suse.cz, zijing.zhang@proton.me Subject: Re: [PATCH v4] selftests/mm: add process_madvise() tests Message-ID: References: <20250710112249.58722-1-lianux.mm@gmail.com> <81f9a104-6d7d-4552-851e-8690d4a1b723@lucifer.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+/IoXd4HsyHrPrR4" Content-Disposition: inline In-Reply-To: <81f9a104-6d7d-4552-851e-8690d4a1b723@lucifer.local> X-Cookie: Do not cut switchbacks. X-Rspam-User: X-Rspamd-Queue-Id: B7F671C000B X-Rspamd-Server: rspam03 X-Stat-Signature: 6zt9p8j3p5hpwsj1ep6dcstogrgndqie X-HE-Tag: 1752221512-227919 X-HE-Meta: U2FsdGVkX1+IL62IPHUIk6XtGcf8HjXQAgmqvQtIvPcdT6YhVgGQFKPatgv/2KOiBHYqhoH+osR7r9otV1+KMnFcgQr0BKLDyXgDuxW0pne7+G02pXhBOLhDJYw6QxSkquHhh3HwN/z2Y/5xn4GUBmyeZ8RzW7ErQPXuFidQ4C9OrE8Zm0MStlMPsGpYgkr3+kns62GJQ4RFP668N43HJxr15HIOZejDMeZnrKxlyt0cf+IvQP3OZYkgD2jkfaFJfKk8FDxabX0n+tm4AHEMaRu4zK9+exld0yEgkGyEsLkSKc1Yfg7VNzuXVv3L9Pe2iX+azxHUY48b3S2/gVoq8neKwCY17FvMXmDMTAc8hCpY7qgvAoOPsS8VHQHNwe+Cg5Dmc/OW2VZ7wjt3MVAHPlJGHexPCa/qdqVlbckyeNS6xr+MVMtq0sBfFOsLavev9zCJIKlXLl312UevfkEX3JONItNBRr2dgcmGGvuyvy/xxfo/CVyNpp/I6Loh1ijviSagD1yENjYtv1H6yW0++oQAdAKOYiIxIlq9hPqMu8SUbKQfIoR0nbYnWP/al1PIpu+5Cl+ZfEOiRiQhuBhKTXSEZ+Z5zUmFWYzZpm8AP0K2yCfaGGc2VDlk6gM9Bf7+JNwyAwGsfJjZZSRInW2/4mM1/hiwaU5W0fFIVFR5cderAGgRV5wf3CHilGjXlCLS4EYzvePcfabjnTp9n8BqT4sKHG6qOKvw3KBD1lZVbATYuqjCLx28YQiIxqguvlq7VuajYBcHb+gsCp05oTBWnxqiBccI7eVWdaw9eu2bbhWaijhdWFdQw40PAeZh5cygJ96m5/N3xkMvpE68oVF96Nagy0qGamSFbxStiCxX8MXfX0p6Bx+F2fYX5kBLSZb3VhNn4P0WdmXYxKi0rG7kucYL2WVFGFsE/iX8iUiDDu+OJzqbn29VJ41hUlcyVGEcx8oEP1XJqc6ahxvIRyE 899Zk5Qu rS9zqvoFwG9ojrmXoZ1nLJF5dMbyCmerRlVofiSySNj5RGqEPt+PSuebPm1Oak8wn2ExMVDq9RUYMvYHviXAQ/xjCoLKiKQrW/ti19ZqCkk595n6glfcCc9RKfo0XBsV/+1nZhr/qytCjcXevyeNYBTv0iXN5SEzkq3WGLBBoOcKiGOsonxnny94bD9/mBwQdg05Gfp+aeWqMSuE/RPbI4AWMPMVQOajpvJrK9YmuGAkB9DIUqVjPiV9sbojEx+f5CvPsU7yv8WmtAWMbhgMDyRBPhb4zb9LqikodG3h4XLBSl17lqCFnp/7PlADUqaHvTW4PiTEKh/whGSZSo8vQKMSzCpS03hgQ/mhgMWibM9qDa25HVB8oQV4Yn590p9iUjUDi0iISiH7oV5usHYvfAQflPW8RBfEYvGNInwZV8wF0W3Bt+btdzEfyLF/FtOjtaEwRYosVFTo2Tmvt6FuIOWcf5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --+/IoXd4HsyHrPrR4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 10, 2025 at 05:57:23PM +0100, Lorenzo Stoakes wrote: > On Thu, Jul 10, 2025 at 07:22:49PM +0800, wang lian wrote: > > +#include > However, the pidfd tests already have a stub in so you can alternatively > use: > #include "../pidfd/pidfd.h" > As is done in guard-regions.c. One thing to watch out for with peering into the private header files of other selftests is that it's a routine source of build and sometimes runtime failures, people have a tendency to update one selftest without thinking that other selftests might be peering at their code. The cross tree aspect can make it painful to deal with the resulting issues. --+/IoXd4HsyHrPrR4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmhwx0MACgkQJNaLcl1U h9A/uAf+MIGVFcilIba7icBSDcbAcHzzgAbmbJUq82ekRCx2smLjWfU6ypbcQh1M iK9OzYaU2ecoHTIEHgaFK0j+jn4y1dENcKs24bYk/1mOeOaV3neipktCUO85wRFQ mBfyAUgBQAUVozPBB9B8idWIlPE3NeYCFEMQxg6qu9v/bhBVJQzantwXQwWCM7eO f8bbyeopLKHx4XYzZTIJoPbiZDK0TlzxLEU8WIa9/yKeL4VkkiUPVgDvbulIW91A F0cJFWm2hdbMY6hr21WmrFV4vkTcFKLmXnKVGUcQ33hCzXhRXVaA/7gICQrCio4J jVcdZTOenc/2hGO2abDiB2daXoz2nw== =rGrn -----END PGP SIGNATURE----- --+/IoXd4HsyHrPrR4--