From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3BEC8303C for ; Fri, 11 Jul 2025 05:37:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E0546B0099; Fri, 11 Jul 2025 01:37:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B80D6B009B; Fri, 11 Jul 2025 01:37:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CDBC6B009D; Fri, 11 Jul 2025 01:37:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3CBD76B0099 for ; Fri, 11 Jul 2025 01:37:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DB6A21A2005 for ; Fri, 11 Jul 2025 05:37:37 +0000 (UTC) X-FDA: 83650876554.26.6979358 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 9F395100009 for ; Fri, 11 Jul 2025 05:37:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Iflp5QYi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k+iX54p6; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Iflp5QYi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k+iX54p6; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf05.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752212256; a=rsa-sha256; cv=none; b=4CceMWmdkjUgLNC5H9Cmdujw/pG77oUtOjdhwZiJPQYHstyG1forl0m28CidSBKDUNWgXD GVJoxe6yLLp+t9tz/Gwp9e4iTfr56xKPpLpy7K2U88tUAASZOGtkrEs9EVbcoBWZkX08nL GFZkRNBoR3SthNQ4ITdFN6nWpyDBw4Q= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Iflp5QYi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k+iX54p6; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Iflp5QYi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=k+iX54p6; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf05.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752212256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zlTJJOEghHWi5AvqIQkQx+n2k9MW3l3aA+Wsviw3KI8=; b=WSTB6/Hxk2gO5+pZe+mYD0x5LGd2Ea7mBCGwnQ+mgKtD/ZLvzklq1POOLjFn55a4pfaGVw sCG2NsvNVvMH9AXW3kOfKtcKjRpsY9s3aKZz9WPmIdSrFqCMpF63Ek0iKL+BkCt40uve2y UfxohIcUCLP4UNW0k5mMtsjGORcb0m0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 084A41F7C0; Fri, 11 Jul 2025 05:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752212254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zlTJJOEghHWi5AvqIQkQx+n2k9MW3l3aA+Wsviw3KI8=; b=Iflp5QYiwcDEk5hTub8boPpWLJUDyowsbylD/OpxR6I2J81/I/IxHidNPFM8inuwfng+1w Z5RYyX2pKz5InJEhc8EBNROG+oiJzcjNrn36byFewufV1PbvG55cCYhS4x1Z8YwIN2Nt2L 98kpuirexWbFDjBJM5C9w0vN/ZKKllw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752212254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zlTJJOEghHWi5AvqIQkQx+n2k9MW3l3aA+Wsviw3KI8=; b=k+iX54p6YTE/zfCGBahKcT/sRQofW7qMbebmgd8wE4+XoGF9RhpNI0HF439OPzU/sHfHmj MryocLMrghyAeTBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1752212254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zlTJJOEghHWi5AvqIQkQx+n2k9MW3l3aA+Wsviw3KI8=; b=Iflp5QYiwcDEk5hTub8boPpWLJUDyowsbylD/OpxR6I2J81/I/IxHidNPFM8inuwfng+1w Z5RYyX2pKz5InJEhc8EBNROG+oiJzcjNrn36byFewufV1PbvG55cCYhS4x1Z8YwIN2Nt2L 98kpuirexWbFDjBJM5C9w0vN/ZKKllw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1752212254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zlTJJOEghHWi5AvqIQkQx+n2k9MW3l3aA+Wsviw3KI8=; b=k+iX54p6YTE/zfCGBahKcT/sRQofW7qMbebmgd8wE4+XoGF9RhpNI0HF439OPzU/sHfHmj MryocLMrghyAeTBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8288313797; Fri, 11 Jul 2025 05:37:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wNWYHB2jcGgZJgAAD6G6ig (envelope-from ); Fri, 11 Jul 2025 05:37:33 +0000 Date: Fri, 11 Jul 2025 07:37:27 +0200 From: Oscar Salvador To: Jinjiang Tu Cc: akpm@linux-foundation.org, linmiaohe@huawei.com, david@redhat.com, mhocko@kernel.org, ziy@nvidia.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Subject: Re: [PATCH v3] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list Message-ID: References: <20250711021734.2362044-1-tujinjiang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250711021734.2362044-1-tujinjiang@huawei.com> X-Rspamd-Queue-Id: 9F395100009 X-Stat-Signature: bx54zubqqd9nh3q47zhbziat74k5wfjq X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1752212255-785478 X-HE-Meta: U2FsdGVkX1/anDPd5VErmgTndg3Q/VAPQVEDSvqzQe/iG3dWERpT6nbFs+VFsHmidL5NbBlS5ptyCda+v17MxHkFWMvJutfD6D3IW1I3rhI902AP0oHBLC0Risk0Fo4Y5ei4630qXfCRrf9G+XLUZcKT9kTe5SSC0E+UVpnUeh0njG1ToPSSaCgWEcVq7hOh0piuisrY9KZJaq/ZZYL6JCQvqnVGv6UO/SiZJK4Q+N5KshqiElynES5KVciqWbVLpE2yHOUupOXklx2rkFQCMAbAkfgsilJ627vdUdMsBRkHrFJ6BMF3HrQ3+ocQxVq9KRCt1FcrtyLUBYjcLfuqLYWetMpINMwpupdPRK4MMfAxM271BTmz2BqfI1eWQGHdfZy+fM05Bqo+NExWZ/Hw07y4qMAZwk3nhxrGBFYTD6JzZEfKeXwsivaXIR0N6dM/5vntNIFF9ORBRfEBqtraSST/Pq6uykEYTHcIVOBDsEumdf0zh+cBz9ct+YIxr7hV8Zo0u8hl/8cFODXceZRb9/ck9jPrsIHbWCsni8QDTvduy1vS+F2DI+047ri3RmP9+OpJQIQ9HCWqvZC57n6o9rZ/s9jx9hu2mpQFPgBbyX/7lMizK+AHkJ1WiFlzXh1+0BrCQh3UI37xgTr1FXYdj0l2YR6CwUJ4Et4Qi7ydEFFyjsB7ptUfEkvLp3wgVzRDhR9jSQnzG0RRSKOUwnhEsMbbtzlE2ik3cl2PQKCyAVs8ie1sQRJ1vbYbcsF783FqxHFad8Jo2mEmed2knKIiHIL+IUnkjUZ1ehorbp96oRKUfoCaXFOdoe7OgX6AXRL6JISMnaDde4L8WPUhCQlj3wwm7yUYSu1IPncGSReD8BplwPgfZkScBTPWEQQODga7k/rHzmv9cfHkSvOnHumF1mXJxEnf+4BMFgqjhOQrlN37QX5mHfMYp3k2qXc2tIVA4VcPL1nRSTtonNgAr4q R3fDHnV9 vKZkd461WNrC4RIsqOjq7/yJGS11uwPpNUvFbf4/4dYpi56Q3klz5P50brb/6USTmFcsMC8eH66S24IbTrpZ01OtrNZvUOT6r9Be+1L23DXxV4nW9xH7ofnQqWmNwHsS7URfEy5UxENYe3c6cMHLiO4NkTjkS4zu5Ud02VvvbR2+b9mjwUAOE+g8NZgYbT+lWQvqL7pxo9MITFarRjFXGK/yH4EKhBGpDAXx7K4KKBB2h001aieGkmkH0BeXONT4sNZQmyC4Zew55FuNbj7OBqPa2h2Cx+VKi68vEIyRihyw3kzGNkmYMcOMA/GQ5J6D1UCsfUwkY3xiGfEv18UtMBzIEs2mlCTVa/romDExFfhunqiT4U2IDowJ3MqfZFXEWSvGVFUiWbZCPu6i98TbSXxJvYNTnCPKcUojafUDV1aRAgCk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 11, 2025 at 10:17:34AM +0800, Jinjiang Tu wrote: > In shrink_folio_list(), the hwpoisoned folio may be large folio, which > can't be handled by unmap_poisoned_folio(). For THP, try_to_unmap_one() > must be passed with TTU_SPLIT_HUGE_PMD to split huge PMD first and then > retry. Without TTU_SPLIT_HUGE_PMD, we will trigger null-ptr deref of > pvmw.pte. Even we passed TTU_SPLIT_HUGE_PMD, we will trigger a WARN_ON_ONCE > due to the page isn't in swapcache. > > Since UCE is rare in real world, and race with reclaimation is more rare, > just skipping the hwpoisoned large folio is enough. memory_failure() will > handle it if the UCE is triggered again. > > Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") > Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/68412d57.050a0220.2461cf.000e.GAE@google.com/ > Acked-by: David Hildenbrand > Reviewed-by: Miaohe Lin > Signed-off-by: Jinjiang Tu Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs