Re: [PATCH v2 1/1] mm/hmm: Move pmd_to_hmm_pfn_flags() to the respective #ifdeffery

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Fri, Jul 11, 2025 at 09:35:49AM +1000, Alistair Popple wrote:
> Shouldn't the Fixes tag be for the commit that introduced the #ifdeffery in the
> first place? Ie: 992de9a8b751 ("mm/hmm: allow to mirror vma of a file on a DAX
> backed filesystem")

Looks indeed better, I was lost in the maze of the history of mm/hmm.c changes.

Fixes: 992de9a8b751 ("mm/hmm: allow to mirror vma of a file on a DAX backed filesystem")

The problem is that backporting to that, if needed, requires a bit of adaptation.
Nevertheless, I added it above, and we actually can have two Fixes tags to make
backporting easier for those (we don't have LTS kernels older that the second
commit anyway),

Andrew, can you add the above tag as well?

> As far as I can tell that is what would have introduced the warning. Other than
> that it looks good though so feel free to add:
> 
> Reviewed-by: Alistair Popple <apopple@nvidia.com>

Thank you for the review!

-- 
With Best Regards,
Andy Shevchenko