From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80287C83F17 for ; Thu, 10 Jul 2025 19:57:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B6B56B009E; Thu, 10 Jul 2025 15:57:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 040A26B00A0; Thu, 10 Jul 2025 15:57:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E71596B00A1; Thu, 10 Jul 2025 15:57:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D4CDB6B009E for ; Thu, 10 Jul 2025 15:57:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6CE6710F069 for ; Thu, 10 Jul 2025 19:57:10 +0000 (UTC) X-FDA: 83649413820.19.9836C0F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf22.hostedemail.com (Postfix) with ESMTP id C04F6C000E for ; Thu, 10 Jul 2025 19:57:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GwD2iFsa; spf=pass (imf22.hostedemail.com: domain of kbusch@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752177428; a=rsa-sha256; cv=none; b=IlnGdVDN7FAmV21rcTykvCaaiE9hLIOSGPMgbjf5V5lR6cx6lpKZcLB/mjBoh/EyatFsKF nviEuSyOZTg3NMll+5RrLxon4ZjcUlR0qnuy1LYMQ1lN77m2fk94UuJLTK/gcplIxn/Fmz 7ARCWcA321epbTAS996V5JKx8ZxnSG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752177428; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=laq88QMPXADMspyDTjRQjifQmCe9VhuNZqwCpLqzVJE=; b=aevRbxm3RDpMwRkSl6LGj7ZRhP4v9Zl0IZK+PHtvaHC6/fTVXnx3eBcWV0Yuw6hfrjLBUV 9JiWiWb+4FXfLoGS8oP90SAaaf+SeY/buqDvjKlt6nKR/R9VJkd5HSpw3WTKLq/HA5GXN5 CtrrPHb42pk67UyWCKHz/CScZ2Q328w= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GwD2iFsa; spf=pass (imf22.hostedemail.com: domain of kbusch@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=kbusch@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8AF4845BFB; Thu, 10 Jul 2025 19:57:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A155AC4CEE3; Thu, 10 Jul 2025 19:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752177427; bh=laq88QMPXADMspyDTjRQjifQmCe9VhuNZqwCpLqzVJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GwD2iFsaw4fxL1BjVNjmfm3WRvqCmFgJKLfACA44hTVucIl8M2h0ZNONEkTGm6w4m dkPcGtuXMdtm0buwX847l1KErF/FPUPm5vSxtBgka5liQ9UJ8/kfamjX0KB2rRY6Xj OyugyOfNkATYnXnwG3zwjqdK0tgg03RuNBnUoDYBLe0vrQ1IB0MtgcDOBKjazFPseL Wg7xrMDvUn0gApDbKkXxq4QjWlAH1IJJlefhV4SgBrBGe+XhdMcp9BPIZBiTkaO8wY cjVOp7O/JzJ6B7L4QScc8DVLp39lTC3fPIoxUxkLTtx8HwbFovYkd/tsRGHtAHmvyk cXQQqDK2Q0T5Q== Date: Thu, 10 Jul 2025 13:57:04 -0600 From: Keith Busch To: Mike Snitzer Cc: Ming Lei , Jens Axboe , Jeff Layton , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Trond Myklebust , Anna Schumaker , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, linux-block@vger.kernel.org Subject: Re: [RFC PATCH v2 4/8] lib/iov_iter: remove piecewise bvec length checking in iov_iter_aligned_bvec Message-ID: References: <20250708160619.64800-1-snitzer@kernel.org> <20250708160619.64800-5-snitzer@kernel.org> <5819d6c5bb194613a14d2dcf05605e701683ba49.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C04F6C000E X-Stat-Signature: 14xk43ocbhz5wez5cqpanmmf167hwuxm X-HE-Tag: 1752177428-810342 X-HE-Meta: U2FsdGVkX19HFQ6G7u4KaqQQLkRBXYX4lA0oIPqYpMb4SbaCLYiH/CF9bTKKwL8C7SM3eTnvpLwpqLhbYaoHnMxnPU0fBmZqYS0mtRiv89VbZ7BBEs4U62g3gD1zB25wnEKWK7kO5VH07AXvhsQ+DqEPxcfraiSi4U9jJ0AFCj5CuQdTGEhJSwd/KmEL+83USBIKUJK/UBnRPNkoFjrf/n1WR2k3/3AMVVJLvaf8rQ0XkN4OVC3oMR8hbdcUkLUKSzHEhDqWN80Ii6fxldfbTzjyGs8mtsroYzhxMyXiKM/KNYZUvONfDexmVH6av6C/cMYyASIqhWlrysHdSIbZMVfd/uYqhu0M4eAnxPo/92y1O+SNe3+QlUwNolFNrCJsf6uv7FtF9JdZJckuuGMHjEqP1LpdTeN0uT6FPYb10XAxmlQGdR5g4txkh9Dh7BR/JyORjSU+MrUE1WRntGFCk1VIyvVEek6adGacJJeo40j/Dtb8UYpIJLWPZAyiNqFFZRzc+GfvbsGeDX+kF2g7fQN3dRKd9JwuCl/0KA4Rfmyy33fAP2xRtk0u46PUxjgZBpQ2GsfP9rYKDtdDoMlmXeSHCJVznamhmFKCCkYr9F41Pk+6MU6gvIWDY008TyeX6BETECVOi6W3Pyg6kAXN50Brr0Qa2owzhVsxprCRh/yyxx3z1aSpOHK3bgivGIn8qpgpSS0/brN3Jzc6Ed3HxEwAjHhtTcsbKNips74XjRYAbxIVNOnE1iLojk8/WhtZTwegFwoD67RPckRzhyQ+NIHVceMF9wmn00+u0xla+lzy2+dDBPJtBr9M2CkAKCyXfzdloHqcTwWb5G6up5XeCX0nmu1TRUtRN5DxRwl0DNMMdHvy4g98LKvU/LUqIdgVI9vGm5mHHF5v3WG7uSNaaHGtNbkPDMGuHzZXLIzWqy5TnyEoHC3/Sk+2j0mSKEHx92rTlj2b7kNuHcle0H7 6arkmdw1 KoueGXetknF3Xs72AARZZbYTyq6LWfLag0SELNOaSorxKLnw8aCKskCeO7DHcBSF4IHt1Vwf/g9DvV0xEKmlg+hvRpdSzkYrYJIE8WzG+MsBaTTjaREUV6w2vj7OKCIa7iMSUJa/ERDpKrw5HXQKFRWNN83dF+/SHjS8Ni9TEQ8hMcnIgsY0SC73qHkwOZhP2e6js1f1USocFcRJm4RpqA+CHy3a/S4lKMFzNA+aIh+jILv8ebDXbBOvVwFfd4bjg7eHAzxblCBcR0TKM2AyjNnb3tTJrBpVHLwRSeMTpYTQrkmI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 01:22:59PM -0400, Mike Snitzer wrote: > I'll revisit this code, but if you see a way forward to fix > __bio_iov_iter_get_pages to cope with my desired iov_iter_aligned_bvec > change please don't be shy with a patch ;) For the record, I do like the cause you're going for. I wanted to make that work when I initially introduced dma_alignment to direct-io, but the spliting, merging, and respecting all the queue contraints for things like virt boundaries and segment limits was a bit more than I expected.