From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06088C87FC5 for ; Mon, 21 Jul 2025 16:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9242A6B0095; Mon, 21 Jul 2025 12:45:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FBD06B0096; Mon, 21 Jul 2025 12:45:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 839286B0098; Mon, 21 Jul 2025 12:45:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 73C276B0095 for ; Mon, 21 Jul 2025 12:45:34 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 38C5F140130 for ; Mon, 21 Jul 2025 16:45:34 +0000 (UTC) X-FDA: 83688847788.22.8493D5A Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf01.hostedemail.com (Postfix) with ESMTP id 67F2E40002 for ; Mon, 21 Jul 2025 16:45:32 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aL2rW9ID; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3q25-aAYKCMwAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3q25-aAYKCMwAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753116332; a=rsa-sha256; cv=none; b=TbaipdUNetNEVdrBUXGSgjjy7tFpQ9MV3AqZ/NrUzddRuZqWtExQBhfOn8auNmzxX959W3 30ZhARtLjGhggY8tpY3UMwNMTTrQCV1TwUpYlPBJ/5MiVqTdWuki/avqcjBEsSFNWBiWj0 o7f5Vv/rVQx35Ej0YhYEFm5a28ixy1M= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aL2rW9ID; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of 3q25-aAYKCMwAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3q25-aAYKCMwAws51uy66y3w.u64305CF-442Dsu2.69y@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753116332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yAOibZEvB75yoGxnODpftmDSDVcEbsFLE1qXCbwGYCg=; b=A9loy025tZNYvmJSo3N5bVmBdXEnAY/Wz0LvXT/dMLgKLpg8UKcfECIJnEa5IhYZnGtzjN iqw7WHQsq+ot/1XHc3acGe1+RnxdVd0q5nU3Mv7vu0NOdEFsyGbKGoa0b+/h+oXQ2sJtu8 udiS/yGtAHq9XMzVWTv2V5bxhChyQz0= Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-237e6963f70so73744875ad.2 for ; Mon, 21 Jul 2025 09:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753116331; x=1753721131; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=yAOibZEvB75yoGxnODpftmDSDVcEbsFLE1qXCbwGYCg=; b=aL2rW9IDkp8sfQWkP+CFibgRm2xTYtC7YTpUZ6KAS+YSVdghdQXljFFY3qwfxXez1d g0CLRW4vXeB/3OF2CEmZpFivDeEwR6pKjpeNbRJMOCs6bX/PCCbgPsCQZxB1rmAU/QTE 87GE6NgR/1vrTUFm2U5g3C2CW9ExafX4xI/yuF7so1rtoHx4ql2jyP+S6yqoBd2j9Ug/ 7USRXjnUAOQAPZCenV1Gsv672BWGqiOZhiRdXKKp9lQ+mDiKMG1ZpaJNPAalJXBrbfdx MF9wyOf95E8T0xZ8qN3MgZhJXR3NMCf5QSJTp4S29nwwZH4nSzda9hw6eZ5cn1d2toeV 2hGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753116331; x=1753721131; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yAOibZEvB75yoGxnODpftmDSDVcEbsFLE1qXCbwGYCg=; b=j7YusqFe6CfLIpGRmQssGojoUJpoo4d9JPzKzBSJ931QHFay8e1auU8hmjI40asvYG wwOl4tsnGy+yfZqPIDDBsAB3/3Qax1+BD9enOGSKzqEtGKjkz5AKXMDNPIxm96lXxYW5 hgSXWnyWKLs8LXJFvf4wzvc0xbBKmm3N2awF2EIwmtThsHjfeTGrmZinO8gAg4+6ok/H zbGdZYC24wYqUXLEWAU0ea3itcDsmLjkmM1TXKiKmzKVKbiOlrOGXjYz+3S94Pzp8LtC 3816BJ4fpx87uvxUz07xBbTKRtKQupNpflPD+zu6UDX+3Hw99Nqdwt0yYVTp0QyEzFl1 LsfA== X-Forwarded-Encrypted: i=1; AJvYcCUocXxm9fx9HuI3IPHgxrseeWFRSGmsqhEFOMrkBaSzo25mOuHIvI+BLN2KLS7OlxQDGx4ldRc2Lg==@kvack.org X-Gm-Message-State: AOJu0YyLgAntvYSBkng3TYtXXs10UDcAX0FuJLAaa9YlyuF/HcYycXhy 0Sxda5Um/Du0VlW5AFAp1NYfPD6JZUe1KC5G3mgZado4m71Qc8vKXlO0NcSGhMdCb7noC+jKCHv gqGQSRw== X-Google-Smtp-Source: AGHT+IHu1HfCgvYEV3fuK82lq6nrK2dBiNzDor9LvjKKktGOdzxraTRt3N+GgvdklqDV8NTxdW/4WHyUTmU= X-Received: from plbkn4.prod.google.com ([2002:a17:903:784:b0:23c:7695:dcc5]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ebcb:b0:234:e8db:432d with SMTP id d9443c01a7336-23e3035cbe7mr243642325ad.39.1753116331166; Mon, 21 Jul 2025 09:45:31 -0700 (PDT) Date: Mon, 21 Jul 2025 09:45:29 -0700 In-Reply-To: <20250717162731.446579-5-tabba@google.com> Mime-Version: 1.0 References: <20250717162731.446579-1-tabba@google.com> <20250717162731.446579-5-tabba@google.com> Message-ID: Subject: Re: [PATCH v15 04/21] KVM: x86: Introduce kvm->arch.supports_gmem From: Sean Christopherson To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="us-ascii" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 67F2E40002 X-Stat-Signature: 5c8ybhnp6pgq6rowxsa4bp5beti9z33g X-Rspam-User: X-HE-Tag: 1753116332-261628 X-HE-Meta: U2FsdGVkX1+ycDNmslOo86fpy9kvKZjF/Z0KsLYsP1IXYT2S3WD6LTmQCc71KRtr5gcq2Rt7umYn77gzaNuw40ALHHJr5qMW0sdVig6HaANU0BnUm5glIUDoN+O1VsGDpRaMIdZDt8KEWFsWG6kG+j5f3Hq3jdS4uR7BWYn6zF+/4B7HSN1Ec5Jn9zZPRjXK+mwchiujzadOzP8NzYgrJXeQ1kRAGYPvS0dKPLIOzgWYYCUqL0JRZiw2/LA81Zh8dNmKqYTpd2G6PehqtlXSFhWIOcSlEmmFsUDaCuU3cKLuQA7kJ2h0mE3CNEtGqhgk9JIOfp6Tn0r+55mlyhOMP8Dp9OoakY+YBmauUoM2cVyXjQyBS7YnCHjxE8wZHMEuhTDYzm6QvQemm3lqL7k6hPtASMRv/3ARR0lolVTFH3yMZbLkqW8zK/V9Fwj4emvyTZ3z40EJCOax6BKIkTsWbJTz7vGKKCULO7/hCbcK9oP/00XgmVkncFRQ7JoqA8dQ5rNForEcHAdRAzu5KtkV8Nn/aMPE4XhtOQ9b3IXT/10PWcJgNWm2lpwa2iPRTbtvPWFXbxFFAGFIQTcG7ZcXJS3d7anq9lDKSJf5rebDc1z9ybPP6/SACfTRRP6/uj739EY+82TN4FChpOOSjtBsdao248t682iYc/OOzNxbK/HW5VYb1NO5l+SHl5wSxKSsCpQKCVQePjgVTBNva2iQDVXFWl5g0XkNfJRoqDynNqrYa/gqwwuj2IMPE5M1+5qLXJLe8KbOjDT8nUHwf86shQ+pe2bzZ//LYubwJDWQVupzg3zXMfv3JeAX+932b2IdaCJB2PZ3eL6CSXShjUrs/Tmv3R9dIfYxvrwqE/LWLbAPQKhm6T3R+38mjP8sR+WdzOzkZFEPDwBimoT0vGbeFb23Gjigho1j3Q/ERtUDEG8E42wz8iuNgECCHFRxMuUtITgq8X8tQP+038LyBFD x0NzqCei gtP+R7MkDrLMbWRO4LS0T9XfEcIn6HmINDpKJqpXi11nx1qrvNfACDa1QVEgrdh0dEQ4xcVd5lxEgI6bbm/6XDOcCfuLMYo9+VUdnQKDFvFTPrZycPBQsJUEocSwFlvjVfw8fThG0/V5kLWnFuf+cprQd1RLy3hImAKkmd2KgcgZ+uWAmq/IdIAl8Uzc7CUNqhT5v3wHYpAQp4Z/snW/AwSA9PWgx6hOZTx8kh73/hfdbgVfS7HM+wFqXE3pV3KS+LvgLJUam2xLNFwaieg98T+SWKQeQNMMnkegwdEKmHXdTbrn0sAP651ojcCxivhdbUMK8bSrDga88sJYMHtk5AJfkdmggsWj1pmoB2vnraqSJ3+9ZQKCgtMSRQ351ftAO+Ox3VxHb2ChuMPRIIsFg3gq4QH9KFOTlmLizhZB/SfECcQGzSZ/IsPZY7licz+tPm8QlpzHNMznUhoK03ZGk398jMKGndZSu2U2s7T1uYi1F/rMcrBeBeMezHzuOGY9wcrOzXEWAH0AQW58ppFuAIcPh8FEVQZsYvSUJv1mUxyLi4HBcbb6to0mLCzXD3jlaC21MqV6oFqGV/Nvxf9epnYditrMTRbKK+QIhzHCzhY6GafNCZtX+J8l9CgqVm1Mq9hFA+v9ZEFBXdOmcnmv4rz2Etikjm8wjip4ZcNvbObjcLiC6Uap8E49aagRcpuJs7NeO0YsQWYLnDUKEqi1IF5QLQ7i9KxDgvW02KeqWF54ozrjvdY2Y0qT84qhzV0SPk+PdO+fKim7WIMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025, Fuad Tabba wrote: > Introduce a new boolean member, supports_gmem, to kvm->arch. > > Previously, the has_private_mem boolean within kvm->arch was implicitly > used to indicate whether guest_memfd was supported for a KVM instance. > However, with the broader support for guest_memfd, it's not exclusively > for private or confidential memory. Therefore, it's necessary to > distinguish between a VM's general guest_memfd capabilities and its > support for private memory. > > This new supports_gmem member will now explicitly indicate guest_memfd > support for a given VM, allowing has_private_mem to represent only > support for private memory. > > Reviewed-by: Ira Weiny > Reviewed-by: Gavin Shan > Reviewed-by: Shivank Garg > Reviewed-by: Vlastimil Babka > Reviewed-by: Xiaoyao Li > Co-developed-by: David Hildenbrand > Signed-off-by: David Hildenbrand > Signed-off-by: Fuad Tabba NAK, this introduces unnecessary potential for bugs, e.g. KVM will get a false negative if kvm_arch_supports_gmem() is invoked before kvm_x86_ops.vm_init(). Patch 2 makes this a moot point because kvm_arch_supports_gmem() can simply go away. > --- > arch/x86/include/asm/kvm_host.h | 3 ++- > arch/x86/kvm/svm/svm.c | 1 + > arch/x86/kvm/vmx/tdx.c | 1 + > arch/x86/kvm/x86.c | 4 ++-- > 4 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > index bde811b2d303..938b5be03d33 100644 > --- a/arch/x86/include/asm/kvm_host.h > +++ b/arch/x86/include/asm/kvm_host.h > @@ -1348,6 +1348,7 @@ struct kvm_arch { > u8 mmu_valid_gen; > u8 vm_type; > bool has_private_mem; > + bool supports_gmem; > bool has_protected_state; > bool pre_fault_allowed; > struct hlist_head mmu_page_hash[KVM_NUM_MMU_PAGES]; > @@ -2277,7 +2278,7 @@ void kvm_configure_mmu(bool enable_tdp, int tdp_forced_root_level, > > #ifdef CONFIG_KVM_GMEM > #define kvm_arch_has_private_mem(kvm) ((kvm)->arch.has_private_mem) > -#define kvm_arch_supports_gmem(kvm) kvm_arch_has_private_mem(kvm) > +#define kvm_arch_supports_gmem(kvm) ((kvm)->arch.supports_gmem) > #else > #define kvm_arch_has_private_mem(kvm) false > #define kvm_arch_supports_gmem(kvm) false > diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c > index ab9b947dbf4f..d1c484eaa8ad 100644 > --- a/arch/x86/kvm/svm/svm.c > +++ b/arch/x86/kvm/svm/svm.c > @@ -5181,6 +5181,7 @@ static int svm_vm_init(struct kvm *kvm) > to_kvm_sev_info(kvm)->need_init = true; > > kvm->arch.has_private_mem = (type == KVM_X86_SNP_VM); > + kvm->arch.supports_gmem = (type == KVM_X86_SNP_VM); > kvm->arch.pre_fault_allowed = !kvm->arch.has_private_mem; > } > > diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c > index f31ccdeb905b..a3db6df245ee 100644 > --- a/arch/x86/kvm/vmx/tdx.c > +++ b/arch/x86/kvm/vmx/tdx.c > @@ -632,6 +632,7 @@ int tdx_vm_init(struct kvm *kvm) > > kvm->arch.has_protected_state = true; > kvm->arch.has_private_mem = true; > + kvm->arch.supports_gmem = true; > kvm->arch.disabled_quirks |= KVM_X86_QUIRK_IGNORE_GUEST_PAT; > > /* > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 357b9e3a6cef..adbdc2cc97d4 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -12780,8 +12780,8 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type) > return -EINVAL; > > kvm->arch.vm_type = type; > - kvm->arch.has_private_mem = > - (type == KVM_X86_SW_PROTECTED_VM); > + kvm->arch.has_private_mem = (type == KVM_X86_SW_PROTECTED_VM); > + kvm->arch.supports_gmem = (type == KVM_X86_SW_PROTECTED_VM); > /* Decided by the vendor code for other VM types. */ > kvm->arch.pre_fault_allowed = > type == KVM_X86_DEFAULT_VM || type == KVM_X86_SW_PROTECTED_VM; > -- > 2.50.0.727.gbf7dc18ff4-goog >