From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24DBEC83F1A for ; Mon, 21 Jul 2025 14:27:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 788576B0088; Mon, 21 Jul 2025 10:27:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7123C6B0089; Mon, 21 Jul 2025 10:27:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DA046B008A; Mon, 21 Jul 2025 10:27:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 478BA6B0088 for ; Mon, 21 Jul 2025 10:27:35 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 90253131E52 for ; Mon, 21 Jul 2025 14:27:34 +0000 (UTC) X-FDA: 83688500028.12.55FAA38 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf08.hostedemail.com (Postfix) with ESMTP id CBBB7160010 for ; Mon, 21 Jul 2025 14:27:31 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W5dZOYU0; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf08.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753108052; a=rsa-sha256; cv=none; b=tPO2wkfgCbRbw+BcC/MKKwTs3aAz4Gu8FP9q1CrWLWWhlUy0VpATmiGBX3wnFjKLSy5MjI toyDZ2J/ogiOyv1xtcoNEgdZ4jpn1sokRX9Ggc8iTt+QUAoVo6mvigVdl18NcmEbXBLIxO v9Xgx84hwyHOOu97CTHuAhJ2+wsQunA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=W5dZOYU0; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf08.hostedemail.com: domain of yilun.xu@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=yilun.xu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753108052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wb+KLctyBZgohdotR3g6qSvfYv1GhIXoKt1reVdRuEQ=; b=zPbMIU3y0VtwlLh2mIKPxLYXNZ8dBky4DfdY1DRaT5gpuadE2IKnwfdXVUpiqTzL2Or5oa BvMZxQUTorugUxnt+Wg+6WzwIjXgpE94XsqfH56Cj90nty5+7q+EN494kwajLzPqsSNb/2 dJCKYR3OBmNsivVaCpy6nUMbBXzsgd4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1753108052; x=1784644052; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=PNJKS+TVTTfsECa7XS5I8d4xMGqWb4m/BU6pFdO60nA=; b=W5dZOYU0mc8Omsqx6p6GqSsQbb3F/L/8ZaP3zIA5bcG55TX2W2Cco+1h Mv+KUvcYzpzqyC0RKImi9yyc6skMTjCynKxCIB4l/ah/nr79UuwlnrAnH oIgLHkvUoQQ+0U73IZPLu+RyRvIJq/7OowDearuCygFfFOisWxZoS+qll skuKxbM90gx2i7wyZ+lP8MQzcDCZmFAH7+PJCMRkgHdYRs7ReLF6PXr/k q8laAojfqa/eoWnE3nTH7C58J5v4LT56D0WtF018W2IHQegXm08XzXBdu DgGach596dJ3Z2mrE2tULuRO89B6ik3JnhFmRyjaL8tPqSK/9yRknJXh6 g==; X-CSE-ConnectionGUID: /pw3CInIRXCvSD755Uduxw== X-CSE-MsgGUID: 2oLjvdFgTKeSrjfqLnOEyA== X-IronPort-AV: E=McAfee;i="6800,10657,11499"; a="54424883" X-IronPort-AV: E=Sophos;i="6.16,329,1744095600"; d="scan'208";a="54424883" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2025 07:27:30 -0700 X-CSE-ConnectionGUID: z23pwguhRCq0pG2C6uHt2g== X-CSE-MsgGUID: R04oqIF4Qc+jd/Sk1KqXag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,329,1744095600"; d="scan'208";a="162898084" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by fmviesa003.fm.intel.com with ESMTP; 21 Jul 2025 07:27:11 -0700 Date: Mon, 21 Jul 2025 22:18:18 +0800 From: Xu Yilun To: Jason Gunthorpe Cc: Ackerley Tng , Yan Zhao , Vishal Annapurve , Alexey Kardashevskiy , Fuad Tabba , kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Subject: Re: [RFC PATCH v2 04/51] KVM: guest_memfd: Introduce KVM_GMEM_CONVERT_SHARED/PRIVATE ioctls Message-ID: References: <9502503f-e0c2-489e-99b0-94146f9b6f85@amd.com> <20250624130811.GB72557@ziepe.ca> <20250718141559.GF2206214@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250718141559.GF2206214@ziepe.ca> X-Stat-Signature: 18ewhxw4sxrf76o1kw9xrygi6ukfrzxb X-Rspam-User: X-Rspamd-Queue-Id: CBBB7160010 X-Rspamd-Server: rspam02 X-HE-Tag: 1753108051-291122 X-HE-Meta: U2FsdGVkX19N8qAr0U7u6BVDI7IsSznDFooqbeu4SUegNpDIU0RRwJCQWApw2SsUMNQUHg7U2hPRLCrNxrQMlc5XX1dCI4uWfrO+jEdAytXwjXaWgNPgvd1EGeNJzf73JenKbGC2zuNhVtqL3k8ZdPofM3VeNuk8i/gsssL9ZcOc6WtdCS0HsgFvk9j6eaz646TKyP7Ta2sWYgSngG40mdzVQ8UHzlVnkFpYN7YvssccHR2lIZVwm/9OqBwye0JXQVBacsffwHyeKQ4bbq3FyDN0KZB8zr95K9TBzWEdZ24y4eMS8eM0bLZqTqCs9nZbAjTcGrtL/rm2/JhSo5t55TAu0cHYHMUJJuYrHQVlJznC87KT15gJit6HgGgPUI+e2A1SqUDL//oiuavkLDKQJkOIBKKSi9QEXzhWOjPloSgv0FOj2T6ZldT4raGtc7ykgw1dNjAyI04LydvFP9ksfCmVpEkUB4z9ZIkxmHwU6YMPvL4xqIauacPmo5Vhw34onZqvu11VwmdzUb0RN91wuo4Jprw0t8uOYa53Jz2zMbnr+jMmUTWqh/MNs83jJC41HFT6VpuMfR9Y6dGuxVvx+bvEKuzwXAPy9gqYyL9WnAd84ZniWa2QhPXUvEbvuhvQYD3o80hUi7Le403VAjc1OE9T1v5/tY9zvcHzV3f/vk8ViBM3kahKqRn34nhSrSgWrsqiQDxfTxXKJrPLSpeSO05hL3VaGqRj/8XGFoGDbPZ59tjUHqPwu3cVUrJlkWWOU1++wtTvG4HLuKtoK5/Bg1fm0hamYRWFVqK5ZMCzFo7vIyZGEd8MXpX0rExHAcCuUgOtIkce4tJema8dFEgw5KLx2RZgC8zqTI8EJf7Syz38eEMdHoocjsk6lZaUtDoAa+AXYEHaH+Tcd8UYrhFzZh3G8v6ulLkr5CpNKVGY59cDVKYwARxYZhBTU033DAgLOYXCHhyI4uBcSnrIwAV bgNX24/c 9GISRzlbuZcQIw1r4jo5Torid9r19Q1+9YHuC4kTs/30zwGXEM+JY9SIlSJ0QZ/PGpfmQA3Gg+YFrxF2UEz8T8aMtP8ILdpXxIy1aAtuTtbzlA9yxBdAOAD4UOR8dEQgBcwi6RYWV5INEZxlOQQCEcAI82EpKJcj1+6KkEFD0uK/Tdb7S7W0v0bxiWGrc44fuftDmGFeo59cLIWMluhLApsClYdr1oc32Ush7M4rNo54sEXwTSMas4JnRARWHHSYbM0Jef5T09W0zx4SxRqfkkMjvoofYYT/BnMT9GtSdwDoUjmCKreGgetbN2qzI0coS1dG4V5ufXcO69EON2FcSiitznA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 11:15:59AM -0300, Jason Gunthorpe wrote: > On Fri, Jul 18, 2025 at 10:48:55AM +0800, Xu Yilun wrote: > > > If by the time KVM gets the conversion request, the page is unpinned, > > > then we're all good, right? > > > > Yes, unless guest doesn't unpin the page first by mistake. Guest would > > invoke a fw call tdg.mem.page.release to unpin the page before > > KVM_HC_MAP_GPA_RANGE. > > What does guest pinning mean? TDX firmware provides a mode, that host can't block the S-EPT mapping after TD accepts the mapping. Guest 'pins' the private mapping (KVM & IOMMU). TD should explicitly unaccept the page by tdg.mem.page.release, then host could successfully block/unmap the S-EPT. This is necessary when shared <-> private conversion. When TDX Connect is enabled, this mode is enforced. Thanks, Yilun > > Jason >