From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C71C83F25 for ; Mon, 21 Jul 2025 17:31:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2272B6B0092; Mon, 21 Jul 2025 13:31:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7F96B0093; Mon, 21 Jul 2025 13:31:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ED916B0095; Mon, 21 Jul 2025 13:31:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 01B4B6B0092 for ; Mon, 21 Jul 2025 13:31:43 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7732F10D5AA for ; Mon, 21 Jul 2025 17:31:43 +0000 (UTC) X-FDA: 83688964086.15.B2C06CD Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf05.hostedemail.com (Postfix) with ESMTP id AE59310000C for ; Mon, 21 Jul 2025 17:31:41 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iRDRaEp4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3fHl-aAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3fHl-aAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753119101; a=rsa-sha256; cv=none; b=Gsob/LubnFVY3R7XwvYK2PBXuoeM93wM4sNOAFI56jhEFCzv7zQmTsug3lgNfs7HZE00j1 uUFk7LalAaNdtTWNt5Juln5hIOkhvIHKm+WlACurBD8n76XOkAkSa/bVbxcp4dx25zUjqV N9J93WqmDIznykP6SPMwaXXQINvI9RA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=iRDRaEp4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf05.hostedemail.com: domain of 3fHl-aAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3fHl-aAYKCLMlXTgcVZhhZeX.Vhfebgnq-ffdoTVd.hkZ@flex--seanjc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753119101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RSln/MKxaz6pbnhToBUcsd5CJU17vyymHtLzt6u7vIs=; b=wYf4MaRDbPsi+Nm6BesHgSL+uH1YiIqvB2O6WCavE0qFPYYQSTq2ZgxPM1JpWPXCcuEHk/ QA7yLTe+kgGscK1RJLrBh2WqNXUHiHDBqd6nPrBZ95o3RJTUVBbVKRkwfZgYMZnccekztL JMqGvUJ5TVaN0imQjjy6e+jFWrWkKcw= Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-311e7337f26so4811745a91.3 for ; Mon, 21 Jul 2025 10:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1753119100; x=1753723900; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=RSln/MKxaz6pbnhToBUcsd5CJU17vyymHtLzt6u7vIs=; b=iRDRaEp4lIgF7aWH9AQ68yjw8szlSaRD5vi2SvnEFxNNkRZA3qhiCjlAiz900AC4Pi hvtblm1sFW11N6uXnsDwniFvqPP5gn6+F/eJ2uHCMYYRvjovyb5WLYeXJEQHDXaB9EXK BC8zx5oWdkGq0UWClUxVlChcREBxwP32esF0hYO6ujOPjyl33tOFZ5RKp6SvWZ/2GFgF NrlQoz5FwarRIpqsCV/uGPzHphIi8d0w2yjjMsV5jgIBICVjKJL/EvE4ubtAueAzRkRM B4uN/0yMGbRczu8Kvp9JwX5iQ4ruJBxWQxfctxZObFpRBDH7JMeDcOmbz96o8btZKjaC OWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753119100; x=1753723900; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RSln/MKxaz6pbnhToBUcsd5CJU17vyymHtLzt6u7vIs=; b=WsHcfuOWiS0OtAoZq6nwHwhFMCvF/HuffssLFEGxAQVB2g51yeuE6aub+LS1pYEE3L Ev+6XtUxdXUVLPsPNWeCdzj/CT8f6cNLhD5UyawvdB7DIxDXbF7GLTbxtKxjDrORdEVf W//RPnak2CAZgSz170x3r7AY8Khj8Tv4gkrwFrfl9P55L+cUqTawsWx5SaZF3H4sbv6c 2ORciszqCw3cc4HtnkavNxkAvC1alKXs7kLibOnyZp7izkYkLxJnKOd5QQl8EZN1UYEi wYo9y0FoC0pt3viEI+QeIhIstjugz7NoiEdLW363Xprx0uJGaWcycgym8OGQ0RJD2Xb/ y1SQ== X-Forwarded-Encrypted: i=1; AJvYcCWdEAk/AqDjsyECe7mWv0/3G3CU1bGX7VtNk2VUiGGtYSTxdbZkV9WOKAJcWdJd/eg8shBBRZrG+g==@kvack.org X-Gm-Message-State: AOJu0YxdDCk7dhvY7LVOKB7uJBl1BT0GJKd3V4T/wFT+4/uO1uFnw80c JgFfTv9/bXE9Cn46pkXKRkuj1QpFgmu0gi/LG9F6CZCshzcOl3cDDcxGc53c0GLWW/JCt2plmAS 9Czc0Rw== X-Google-Smtp-Source: AGHT+IHKvmg6wx/J1JbCtyV7n/8+lPoe0UGP9o7wTaBYQtOLo2cMF1vbrd7+a3IA2/sXmgwXQiNECYqTZBw= X-Received: from pjtu4.prod.google.com ([2002:a17:90a:c884:b0:313:1c10:3595]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90a:d00b:b0:312:639:a06a with SMTP id 98e67ed59e1d1-31c9e79383bmr30253550a91.31.1753119100498; Mon, 21 Jul 2025 10:31:40 -0700 (PDT) Date: Mon, 21 Jul 2025 10:31:38 -0700 In-Reply-To: <20250717162731.446579-20-tabba@google.com> Mime-Version: 1.0 References: <20250717162731.446579-1-tabba@google.com> <20250717162731.446579-20-tabba@google.com> Message-ID: Subject: Re: [PATCH v15 19/21] KVM: Introduce the KVM capability KVM_CAP_GMEM_MMAP From: Sean Christopherson To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AE59310000C X-Stat-Signature: fjhuexx94g1ri91zx8wxkicmjmuefzox X-HE-Tag: 1753119101-895134 X-HE-Meta: U2FsdGVkX18L2TUxVgUNKQrsBh0IKeUUxlD0FlDyYtIanf11ZzgUPW2MHo/+6TtZy2VpAbqHq3rOq9/tetHrXF/y+t/9hdG8D5ESI+D9B8rj/SSMChup3Oyw8e521xBhVLtWOKPKfSXoS8mXSEjlh6yKnbVOgBNTzZvgw8UuqyH+7q5Rz04eNo8yjsj1c36SL87xOgX3cewFOhbRnW585vujGOQLIbcVtSTTvPLrGHwJuyHbZ0lUPxumL7Hv5OT8ujrHNATJmzamwbhjzbLCifj+j+dR6Z1X1fAgs2Km8d+hFljZYhIus8S7XoS2HqZl2kEtZXKYX5XA2nuOQiq+ePacuxaU37SUBEiDdWQU03On8P5i1fODVV7nskKn9WNnH3r0nye7ZkeW+SMZfHxRVjBk5MrwBFGOUl2pgr33wuuFadOPJY51tcSTLI58qXuqltk5vNB2d9hOCGVuwcJL48C7T2F6hBA5BHTYxd3XtDezyux4SX4dh7w1g2MYplrSAjrpt1N4Dh2O5rBIe7noFZh4f1Vmsboap0kQRQtu1Tj5A40AQe5mDtL9gKVFOni1+n5TwU7Zqa5g1D5eNCEsIlG1ujvDpQDyhMKJz7pUcn+VQe7hdGUbhAeCFb0cIwB/3tlkkh3347HWcXX3Ro3rrzAJPoy2Wbr1H7oxUAT4dcBrp1RdZcb7h8bQsvdAOpW2pXgEIqJmj+B7qOBaEL+cBDfQ4TOaFTKngRM41V5SxZs/qI81XrZ7HPxQz8EiSv9d5ceS2RvwUnWbsHST+nMi+R9ns4LdyvMy4myBnqFRYIH50zb/I759fGCOvt6DcO6nte31+MGzSFFJW7DaadQZb0ODI+V4Rc5D7tIXit8oocKZBvGdMdU1yg+WxrCDu687cHhCqfvu45qOmxKeoGe0YdC0qlkc4qA2ViG6mwGLKhjwTpHPaRbtn3mNAWXHhR58uXfNAHpRQwNemqkL1ST h+PNSMMv fJt1wAHg3LGKOoSe3JgLNagOwvLj5tNklCAOLVaA0Z9PdCaylW/RWX9WnEZ2RPX3ufddUTQwKRJbcbY/uRT8s0XNWjRC+jjl7Dev0O9EpZrfiTXRl/300sJFnFq8wbZxLzWtkHujZ4hOr7MExOaV3BLqnPTzlFAj1Q+bbpDQuoiUqlsULBcBcFWdVNhMkOI/yYN7BxlI/2mN/PrlZf77041em2F9zgLO/ZR5s5TV63OY209AoUPpCER4blWH6/vTbXRDkwSnKdk+5MzKqu0i+u/NjipjegaNXweGzeZ4eZ4WAEc5GVzd3nW9rb8ivL25c6J2P2zuc/lRIFk5NJ/sNMT+g3Oixn20Ik/drnbxflOuTbdmNmoWG6bFmpwpiCEFwFCAuqw9PAQx9mqw5dvcCJRNU3P7uG6Tcda5Qcp3ozoJX3saHkgt2I6URyZcaHJ13SVZYxxQ8OcI8I2JW5l4v1vVg1bh0uvPbQjTBDCvrYwMQmWZH7FEpun/f52SO82H5ULx4kkvwv6lBU/8ZTg56rSQ0JzZWYn/e6ckKJ9c2X3kni+Fn1bS8RXu07DChPsy9Pkyob/ir6qJUA0CT4kkLwQc/gRFzdjMuRcZM85fB96kVYv66tFJCHQjhaDAQsGH85zW0GCTr8k8T6ac4jNDS6WnSnVI3VMvhUGlQbCWNswJb2dqie0lpy5rrTJDKfiP4459QVmg3vIbqcml2QiuiGuPj2oDXSLSUjjjaoLPC/IUeg5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025, Fuad Tabba wrote: > Introduce the new KVM capability KVM_CAP_GMEM_MMAP. This capability > signals to userspace that a KVM instance supports host userspace mapping > of guest_memfd-backed memory. > > The availability of this capability is determined per architecture, and > its enablement for a specific guest_memfd instance is controlled by the > GUEST_MEMFD_FLAG_MMAP flag at creation time. > > Update the KVM API documentation to detail the KVM_CAP_GMEM_MMAP > capability, the associated GUEST_MEMFD_FLAG_MMAP, and provide essential > information regarding support for mmap in guest_memfd. > > Reviewed-by: David Hildenbrand > Reviewed-by: Gavin Shan > Reviewed-by: Shivank Garg > Signed-off-by: Fuad Tabba > --- > Documentation/virt/kvm/api.rst | 9 +++++++++ > include/uapi/linux/kvm.h | 1 + > virt/kvm/kvm_main.c | 4 ++++ > 3 files changed, 14 insertions(+) > > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst > index 43ed57e048a8..5169066b53b2 100644 > --- a/Documentation/virt/kvm/api.rst > +++ b/Documentation/virt/kvm/api.rst > @@ -6407,6 +6407,15 @@ most one mapping per page, i.e. binding multiple memory regions to a single > guest_memfd range is not allowed (any number of memory regions can be bound to > a single guest_memfd file, but the bound ranges must not overlap). > > +When the capability KVM_CAP_GMEM_MMAP is supported, the 'flags' field supports > +GUEST_MEMFD_FLAG_MMAP. Setting this flag on guest_memfd creation enables mmap() > +and faulting of guest_memfd memory to host userspace. > + > +When the KVM MMU performs a PFN lookup to service a guest fault and the backing > +guest_memfd has the GUEST_MEMFD_FLAG_MMAP set, then the fault will always be > +consumed from guest_memfd, regardless of whether it is a shared or a private > +fault. > + > See KVM_SET_USER_MEMORY_REGION2 for additional details. > > 4.143 KVM_PRE_FAULT_MEMORY > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index 3beafbf306af..698dd407980f 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -960,6 +960,7 @@ struct kvm_enable_cap { > #define KVM_CAP_ARM_EL2 240 > #define KVM_CAP_ARM_EL2_E2H0 241 > #define KVM_CAP_RISCV_MP_STATE_RESET 242 > +#define KVM_CAP_GMEM_MMAP 243 KVM_CAP_GUEST_MEMFD_MMAP please. I definitely don't want "gmem" in any of the uAPI. > struct kvm_irq_routing_irqchip { > __u32 irqchip; > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 46bddac1dacd..f1ac872e01e9 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4916,6 +4916,10 @@ static int kvm_vm_ioctl_check_extension_generic(struct kvm *kvm, long arg) > #ifdef CONFIG_KVM_GMEM > case KVM_CAP_GUEST_MEMFD: > return !kvm || kvm_arch_supports_gmem(kvm); > +#endif > +#ifdef CONFIG_KVM_GMEM_SUPPORTS_MMAP > + case KVM_CAP_GMEM_MMAP: As alluded to in my feedback in patch 2, this should be inside CONFIG_KVM_GUEST_MEMFD. > + return !kvm || kvm_arch_supports_gmem_mmap(kvm); > #endif > default: > break; > -- > 2.50.0.727.gbf7dc18ff4-goog >