From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5412C83F1A for ; Mon, 21 Jul 2025 07:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3533E6B0089; Mon, 21 Jul 2025 03:01:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DD896B008A; Mon, 21 Jul 2025 03:01:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CBDC6B008C; Mon, 21 Jul 2025 03:01:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 06D176B0089 for ; Mon, 21 Jul 2025 03:01:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9AC12130CF4 for ; Mon, 21 Jul 2025 07:01:01 +0000 (UTC) X-FDA: 83687374722.21.F6D7A9A Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id F3C9740009 for ; Mon, 21 Jul 2025 07:00:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FrQtjwJF ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753081260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AgLgPBRTNxxvHF8cSuGGdkujqZoQFY1bUgkbASNTV9k=; b=Xzpuy67k/ardgg167mupa6AePu1ABXzb9RZpOmabpJketieg/NlTu7ZBnwNmTfAI4tp62x oFGeNHJOOAn8habR7p8W9WHr6nMDvooKEyoGbhao/vASQTRriKV9x66T79dMneLENOaDyN AR7LS4ZpmKZB7kHIeOO6p7wdgQMomqs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=FrQtjwJF; spf=none (imf11.hostedemail.com: domain of BATV+f2aab5d857cf6ffb4578+8002+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f2aab5d857cf6ffb4578+8002+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753081260; a=rsa-sha256; cv=none; b=hSmsM1AA6WzlyN3lxAaotdY5ZL2PnPeU1BbwA9Psbeupe39itxJtjzEU8+DOcfEfMklXbj CCVrmffx4m0uluggWf9KgvPT09BgiRKf7ELJBqRDRAZ+IMu9OrPIiy+bwjytjfFeJEvV2I LDL/HffJnGW5tw9ixBFVGzWWvqLBaXQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AgLgPBRTNxxvHF8cSuGGdkujqZoQFY1bUgkbASNTV9k=; b=FrQtjwJFdTS0B8Kua0PIQIJwO4 3Zk4OyGXroeJfhkGSdhFxSEBscp3zXhBhIQ6NwXrtxpbI60BKwSIZXQl+KtjCzhiJXmJFlaCgW5H6 787Obg4n7axKxGI3qFCHvAQUEnqWrxbhqwrrQZ7WAkM4bp4H3/jz2k4IGrAPVCh0qP+LaA9JZFgDr jjEUKFcl8C3TQemByFLGJ1jsaQ7NovcnBV2OHT5r8P4osQ/hy1aidsCJhHekKhoWfD4Msh5vd/ph8 axLv1bME8qKqnaZNCpYgUHNEjLQm9rPlsEFOVoq3Nv5r8+S0f7cDr5BgLpcKQstH+81zMrSB2v8cd PLo+MAmA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1udkW7-0000000GRux-455c; Mon, 21 Jul 2025 07:00:55 +0000 Date: Mon, 21 Jul 2025 00:00:55 -0700 From: Christoph Hellwig To: Yonatan Maman Cc: =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jason Gunthorpe , Leon Romanovsky , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Alistair Popple , Ben Skeggs , Michael Guralnik , Or Har-Toov , Daisuke Matsuda , Shay Drory , linux-mm@kvack.org, linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gal Shalom Subject: Re: [PATCH v2 2/5] nouveau/dmem: HMM P2P DMA for private dev pages Message-ID: References: <20250718115112.3881129-1-ymaman@nvidia.com> <20250718115112.3881129-3-ymaman@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250718115112.3881129-3-ymaman@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Queue-Id: F3C9740009 X-Rspamd-Server: rspam06 X-Stat-Signature: howtcr7nphbg9qsu8nqmnwibhgcbrpk5 X-HE-Tag: 1753081259-510196 X-HE-Meta: U2FsdGVkX1/XTIIL/G/+bcriUioLj3oGJy+l2eX2UnWY6R+L/eAFX0EEGhlhQhzo8Y2+kXSMrr/eyGD1pZyexyNMKsbsbHoAaaGu/znkPTzl3ZG+PutdoqgBrpPkMFgGNuG55b2khnngY7QTRYF3w5Se2wLgJ0cE/CQz88Gec1pjwpmk4lU8K8pJdvv00TusTNNm/JOgvdehcwt6WRFOQQyBy8/+sXB1lq1MA7MHSOdM4WZuRz2cCY5DmBTSnu2D1NZMeBYbPYh7lJrFi52yNYNUHjM2i7CPbHB3TIBO7fNUCM74K1Ko/Fu96PuRaEw7Wb4OvlIaRzU2NTpL4bUm7XSlrbnFJ2ZbAx7ap84zDnFSomMjO96mO8TfuMCS5+hvPtBaIly8VegdlQEiSgCMUaUbJo9RLc5fDIpAafILmdmsuOQ9abBsqL/ECEIblXBHVWyHG+zSFb+2cuPkp2JYJJeC9WsU9bi3g0IYxDSg6czxkCnee3sJZWXUhQdQbC4oy+Z1WHS0ZH2HwjJ9iRzLgKXGDFreUYzo/Xc4FpbuyCMAx6WYmFmMQj73bJegYE6BbySaFXExcvccF8HPt9fTiF+KTmWBamW193+I4unJN5b8NdID0iojO3DPr3mnT1D/x5/x9aOZLEoo3qnHxTbL1SfTLP8uF7sxVLKUD707LXdlU5oJ7XlBYoGm6/vSVDA2NaOU9y+kWXvtea/vfectj0M442MgoGTPsVbXTZG877OUWMGUeL29D0iU00R/G81we9EHQ0LcNHJwY7SSVx3wXxpCR2g2/Gqn08UAQ14H7sqLGlNmZxCaEsgosOEq1UbEUPp9RuZaH2KM98Pu55klBXtUUMtKQAy7WEVy8EkYpqbcY3B4xBWy1NxFU6GmDrGfyQNqturJll8blAUMDGLRBcGQMRob7JQZXHdLaUoB3G1qLRviLBXvjcOAaS9mRojGwptN9YukUVQRevhbgCq 3aL10X3M F9KUzH8tj8kL+tJ9bzsuS3xtZMSbDqNdurjUo8r2UvWcvVGXivgz4FM0ljbFIBds6VnyJXaMhcaPAcUAFS11yZ7RsggR8d+H4+wYQ/sxlz1Art9ATcb4mKPAMdlNY2K/FhxA1yVLyPDYfJnI2vmzjftNx8TtOx8bvtMARg4TbJOwdq9Fu7bfc6/tWhDHz/i5FEEOVqQNGjvRHONvpVkZziVlnUyOwHHUXho8mQkzrUT64Get9nuFyZjGhU2KUQJmQYNtwPFyq4VnsM7yaanvmv3bLu2e4sO9Vx0Mm4+XKzX0UpL8k15ITvAt3YuDAhtWg7xjFbg3cIvWOG6LxpDaX5FdteY4E3vJQ6DGsxVxgT1MwsxjRt9Re+SC64WL6yAacYATFnBl13WVe7oOBzMoE9Q8347fHnZmIvO0mRuERrYlXRKQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 02:51:09PM +0300, Yonatan Maman wrote: > + .get_dma_pfn_for_device = nouveau_dmem_get_dma_pfn, Please don't shorten the method name prefix in the implementation symbol name, as that makes reading / refactoring the code a pain. This might also be a hint that your method name is too long.