From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A64BC83F0F for ; Tue, 8 Jul 2025 08:29:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4C486B0119; Tue, 8 Jul 2025 04:29:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AF1D6B011A; Tue, 8 Jul 2025 04:29:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84FAB6B011B; Tue, 8 Jul 2025 04:29:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 672486B0119 for ; Tue, 8 Jul 2025 04:29:56 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0F912593E1 for ; Tue, 8 Jul 2025 08:29:56 +0000 (UTC) X-FDA: 83640424392.28.934078E Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf11.hostedemail.com (Postfix) with ESMTP id 147D94000F for ; Tue, 8 Jul 2025 08:29:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="B+ANi6D/"; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="B+ANi6D/"; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751963394; a=rsa-sha256; cv=none; b=jVABOmVZtIRWDhgio7UjwOM9XgqRC9yZ/XoWZ/sPHYz+UteOMyaelX7Wj9yH612E1QpqFI I45sg77eQy7FwAbwSe+H9WYqhwtRuTqdmGc9y680EKxaRaqcFeCm22ziRZFEdK0bNCmbdW ETliyHxY3c9SwnPmGq7QdfKF2biOUh4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751963394; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mIMqnAPkWP+ME93BihsuuKLeNX+DuHUXURXep46K9K8=; b=uhsoedyGBsnte2yUxSqbRflhY/szF4JJz55XcF+xGe1yAaSNWwvbFjU0eAQH3Mkp/i0Az4 qx6Ra5NYsUi2iFdP1dZw1CLxjiybIjfDJPsW5z4qoavlbEb9a7IOq4xIu5cZHc652O4xbl SdKPiTOhL/l0ZSJ5NhLdxFWoUslvX6A= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-553b60de463so4129799e87.3 for ; Tue, 08 Jul 2025 01:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751963392; x=1752568192; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mIMqnAPkWP+ME93BihsuuKLeNX+DuHUXURXep46K9K8=; b=B+ANi6D/rxhC6hSjwtmDZ3OXHX2NJ7CGWp2y8maoADocfA+DMtgEuLtoaXtJML2yib Oe4j9fEpUqpMe8iXgtZDNZgHfRrUa0afqa63BFh6s4I0C/r2qxBNNjGpGmg6M0hLblw2 zVOOhxfJKfpgcbWnBUD3mnA0k5NCmYtvp7qJCBUzoPq2HxqjnzsDYybIdk76ibvUCTm7 9RPHpfYo+YQVx/APr7kzU62wPAVW8lWlAjfxd/BVdWfqm0VboxTpEkzNxkdPsJuijx4p z8rZosiRRmjP0Qd/5p0/FvtdinytOh5VqsaVQ3iBkBHgF2kXoeG7U+7Qhdl6uHTUi00J Vkvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751963392; x=1752568192; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mIMqnAPkWP+ME93BihsuuKLeNX+DuHUXURXep46K9K8=; b=H6uYHXbg5GOjKZiFgQQpy91qAU4DZ9y7nH+5wLWXKWqY9BMDu7TI2fD8kNco4r6sgw yRcU6jlTkmTQWwAn2q0PykAHey1X1oxEVwdY5E1RWBQb0+j0CN0+8QqfHtZDFJqsYycG 9Z6nhJXlAmhJju7V715qXc1oGEXoPzihSMkbMTEEg5cfuj4uZOooidKqh6o2qC8dCbSK 1U0TyXZR9Z1YWJ6c5Bsloak6BtqQ+8V1c1j2xt/85BwbN9TOYybfv5wKszyebYtikpnt urKpvxqWyWLMqQoE5IxpwA1SwWYA4hzv+69gnkqlINSlPM7Cp5CC4/EujW/x7H1AUe7p LBrg== X-Forwarded-Encrypted: i=1; AJvYcCWD9+MK4s9LCY7Hzk0HwLUk3oAWcpQAb0Yp5+mddJGn2b9qo2x+ueQ/vUPAqqb0e1l99fqrzIc9VQ==@kvack.org X-Gm-Message-State: AOJu0YxoSUUrWRPyuCsFodkxDA6h3fFfvUXXsWcfuy4qRSk6uCUjgpdX 334o4Fk/ETKru/Gk40ddf22TB56kVXnWfse4S1asJ1+UoKqqty78nBgo X-Gm-Gg: ASbGncukGJjtOF4UvxKSaWCjnnyAWDCUFcR5r6n5C8yQrflr+gkpB11G32rrGv0lryG JRxvQl04ZHR0RQerHzsPOKO85LzEPkxlboitFAzsxnCVh7w8BUkH69fVww08X5JhwID4XETWA04 OZ3typRC/P5gdTASUWGSnL5geOLfwQxPpeEgfDT+Qohn8Z4g9QLH/v7c9r/MI2AjiK66RDtOep0 1kHN7282tBVt9MBeWSfEZJElEr4SdZwrqNcdH1d1DdqBEdLSG4QXtwxhmYGu/1kbu5f1t3m9Eis KIYmVc87qo9oMlCURhuycSIoR573 X-Google-Smtp-Source: AGHT+IHAkjYUgvYuREFNuq1/uzTXv+D++CYIo1Q29V9d8H1P758gISwkZGPcfy2i2YvTvYmUKB0xcA== X-Received: by 2002:a05:6512:3b9d:b0:553:a5e0:719c with SMTP id 2adb3069b0e04-556f2758357mr4399346e87.51.1751963391837; Tue, 08 Jul 2025 01:29:51 -0700 (PDT) Received: from pc636 ([2001:9b1:d5a0:a500::800]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383bb6eesm1602893e87.3.2025.07.08.01.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 01:29:51 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 8 Jul 2025 10:29:49 +0200 To: Adrian Huang12 Cc: "Uladzislau Rezki (Sony)" , "linux-mm@kvack.org" , Andrew Morton , Michal Hocko , LKML , Baoquan He Subject: Re: [External] [RFC 1/7] lib/test_vmalloc: Add non-block-alloc-test case Message-ID: References: <20250704152537.55724-1-urezki@gmail.com> <20250704152537.55724-2-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 147D94000F X-Stat-Signature: osatx14skcpn3oya9wysbdim197ekfad X-Rspam-User: X-HE-Tag: 1751963393-275672 X-HE-Meta: U2FsdGVkX19P4meirG7aIXDvLs4NwN+XpuYGAuMfjszGD1X3j+cpjWauwwUhd3T10NZxyBK8S+7GsnzA7Vdoir3f06oxpPcKIAHFhh8xKDTwVba97glgqv4YysbqbzvaleQB5PEqz470H+JfJWEKR/Gp8eZt1mZ6OUtRdPev1yOiGFlMMXV6SX7QLcbdlkFlgoHlopb4u3d3EFOz31ZQjLCeRBLXijaMq+JJfN8h2Q1c5AcSn/U3/p4GKrsv4XPE/VleVcy8KrgKGevIGUPSp0VCoRCMvRlnJkul8HBCvTxeN1CqdNIUAPt461fzDSTBT6LmkCHji16TLeonJfh5MjCP+Gc9BQuQcLQaGntEjiZV4MA0WVXcAi8/Ta3ynJOEssezwKP1OCKyrgB1c2zLdd7JcdYAy37io6RDiGLYXOZh741YLleIdxZymCtpq7qs30usy5L5ca1YtheDkDcXXayagQeJON6mBEqO9gW16grVhCmbnxcNUTTRctuPvQ3I0ykPijZtTp+KBh3Ox8Qo4M3awLFkapj59Qnc3JtpVKt6HKvW0KViEa31ybFeuh//ccTu/znhNuJgi2/lNjiYOa9OhR6iLN/RE1peG5qVy4912zk4EfdBpCqXcjdG7ArBBl8OzY/y4nwV3yx8b78JfkzpGXiz0jUyWPwZhZf0px+TORUi11cmkyXf3O8NPmGZ6PeO8eB2NAUJqt62khH4XbSeggIzd7GZjh76GSTlCy3UDSJla92zKGenRO0ud6OKMKXymaw/49jZkbTQRoV3M78TfRjCg/mrZc4K5tgL6R/6FnTbf50IUZthswhIVAK973bLugQG6wYjTnwwYHy64R+LL7877zOrd2zK2C3Yb6rDkHhivY0qYgI94WxM+ZJ7fTR3ABC0GQafBDALT3vuxhcnSBbmFyJDrBd8uGCdHqTCmEhxE2rNMqsLFHFAed6SDUSP/ijSDqIbephmyjp RaPJcywq C0pU89suml2fFtiulXK38f3cYir04+sHk2CUgGTOfhPmpenB2tq9/D4uP8YIN7e086oa71tqlMRHim7GcidZk6NPcR1SLorDVPNAUckv4QEKkXDkFgSeLC1PB4AVVJpifElYfyAwjcBuX/TDTCAZnknTbox3Ke3el9h8g1DXAuoFeaeSE1EWl4+cZ0AK7ztytt2wamd+wB86Y2n92HQvxLHm8wYg5Lab9yds7VmRTOdjCXMUafOJZIk0ErVqin6FYX4l8RHbdFUMU9fJ4ZmnSqUOLMFV2VPEfIne4NrRgDujauSe0L/pTm6lLcOwzLERY6XlBRF+UGVGrG+4BzQV/rrc05f1F9DjMh3WJ7VRKMb0emFqw/2GaF6swJ2ihZcpZeOLw/HJZ0NFk1S2iN/6F0znunRtV5kPh/8a99jOi2kJUzcIeLnu4miT2QWStGGnK2WyOo7kGq5cgW6DUxWeiO+5ojyzXmaVqAbGChzWe+XX/OXe0c9oRPdf97l5f4TpAodQL7YPk8mCXyxTwyP1AJUIi7bEvZltmyWEh6yydal6jExracSBMDe4/zbqUZHC8hIED3nyC2wtGpjDP8CmHHKyO7jkXfR9iQsjwS+uV3sFdTMuh4kb+GY+Fx6mvPQx+TLGysJmXoPqZepcWPeDx+vT8/6ZIDkGJJhjud6Om43UMjzhx5EXxi84Jn/M4O0VFvth5qQ8GHewkWCTvTWjB+zw1rg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Adrian! > > > -----Original Message----- > > From: owner-linux-mm@kvack.org On Behalf > > Of Uladzislau Rezki (Sony) > > Sent: Friday, July 4, 2025 11:26 PM > > To: linux-mm@kvack.org; Andrew Morton > > Cc: Michal Hocko ; LKML > > ; Baoquan He ; Uladzislau > > Rezki > > Subject: [External] [RFC 1/7] lib/test_vmalloc: Add non-block-alloc-test case > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > lib/test_vmalloc.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c index > > 1b0b59549aaf..9e3429dfe176 100644 > > --- a/lib/test_vmalloc.c > > +++ b/lib/test_vmalloc.c > > @@ -54,6 +54,7 @@ __param(int, run_test_mask, INT_MAX, > > "\t\tid: 256, name: kvfree_rcu_1_arg_vmalloc_test\n" > > "\t\tid: 512, name: kvfree_rcu_2_arg_vmalloc_test\n" > > "\t\tid: 1024, name: vm_map_ram_test\n" > > + "\t\tid: 2048, name: no_block_alloc_test\n" > > /* Add a new test case description here. */ ); > > > > @@ -283,6 +284,31 @@ static int fix_size_alloc_test(void) > > return 0; > > } > > > > +static DEFINE_SPINLOCK(no_block_alloc_lock); > > + > > +static int no_block_alloc_test(void) > > +{ > > + void *ptr; > > + u8 rnd; > > + int i; > > + > > + for (i = 0; i < test_loop_count; i++) { > > + rnd = get_random_u8(); > > + > > + spin_lock(&no_block_alloc_lock); > > Since there is no shared data to be protected, do we need this lock for serialization? Any concerns? > > It spent 18 minutes for this test (256-core server): > # time modprobe test_vmalloc nr_threads=$(nproc) run_test_mask=0x800 > real 18m6.099s > user 0m0.002s > sys 0m4.555s > > Without the lock, it spent 41 seconds (Have run for 300+ tests without any failure: 256-core server): > # time modprobe test_vmalloc nr_threads=$(nproc) run_test_mask=0x800 > real 0m41.367s > user 0m0.003s > sys 0m5.758s > > Would it be better to run this test concurrently? That said, it can also verify the scalability problem when the number of CPUs grow. > It was added just to track the sleep-in-atomic issues. We do not need that spin-lock in fact. Instead we can just invoke preempt_disable/enable() to simulate the context which is not allowed to trigger any schedule(), i.e. sleeping. -- Uladzislau Rezki