From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E99C8303C for ; Tue, 8 Jul 2025 07:10:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91D176B0372; Tue, 8 Jul 2025 03:10:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4A96B0373; Tue, 8 Jul 2025 03:10:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E34E6B0374; Tue, 8 Jul 2025 03:10:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6C70C6B0372 for ; Tue, 8 Jul 2025 03:10:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E42041D918B for ; Tue, 8 Jul 2025 07:10:52 +0000 (UTC) X-FDA: 83640225144.08.75537FA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 3279F80005 for ; Tue, 8 Jul 2025 07:10:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=afTs5ENv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751958651; a=rsa-sha256; cv=none; b=HUxKfQ1KsfWh69V2wTquLYA1w65QN5EQP0We8+VSw/Dvm735P0Ws1ktsW4+N0ZpVV5Cgxa mN8OfYIR4kCEYCqV8ox90id7NqLfic6Xub9IhvMjCulrqX/CMZXET/xuDXg9OQfy+FzlOu q/YtRqRLEugQE/QsWKRRZm4EAoYXraE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=afTs5ENv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751958651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MhbFbriUlgZMxAaP+ulMqQbCTqMpKUTXuOG7nuQAr0Q=; b=GpInS431/kveIF2pAgxYwUZioiJ7QMUEelH84cLGQI+syKAXC1yIPGv6+sHgx2GovPtACr GJLh4B/HwJjm9gcant6gEF00K9FyF/TJhkAG0TDCVk8YBUF/MPYJa4usbP6RTAoxgh1Tm3 YDstxAIuiknbofHiRzk56cNjKJ6Gfxo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1ED8B5C6202; Tue, 8 Jul 2025 07:10:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90835C4CEED; Tue, 8 Jul 2025 07:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751958649; bh=CC5iDx0Wrj+Klrk9Ri4aS+NjdvqOQWWSjSxWvVcXFTo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=afTs5ENvhkamb0LLqd+IgEiyQGBJe90QeMYZYjcrMkTNC8Yu/NUAMmEf9niXbRH7a mYJWapF7+xQckyQVQmHOifdktVPPFNQniSX4nriWuNq61s3H7R7txv3USrHQ/l1De8 XwVHB3FItTDK9gJGT0g8XBRf5UxPYBI5VCtKChiCxSy7sh4Twat/vQu4c5wES8cXG/ Qw75thLg7rjQNPPWvLjr9xHmdMxlKoViNHGp6O1/7jjBFU652BDxVZzEiQ/2Pd46u4 se56Zl8WSMr/s0TMKrumCoE+CTJ+R8u8BV9TcygQUFtUFgsXl/nJDWWEYtQz6A2BT/ wly+OikM25RRw== Date: Tue, 8 Jul 2025 10:10:39 +0300 From: Mike Rapoport To: Yann Ylavic Cc: Andrew Morton , Andy Lutomirski , Borislav Petkov , Daniel Gomez , Dave Hansen , Ingo Molnar , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Peter Zijlstra , Petr Pavlu , Sami Tolvanen , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 3/8] execmem: rework execmem_cache_free() Message-ID: References: <20250704134943.3524829-1-rppt@kernel.org> <20250704134943.3524829-4-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3279F80005 X-Stat-Signature: y1tnc4kkn1arceg7c4bii1xenni4m343 X-Rspam-User: X-HE-Tag: 1751958651-833060 X-HE-Meta: U2FsdGVkX1+ki7cboXEBUBswImM9mc8qrydsiiriRzA9RSEZoGFwN3XUVQU2RvaD/24MlxDuJG+0RLXmiUjRtgnnQeJyWcqG4/fOX0Ka4E7dlWLNUemX5OAp1/TVLB8ReoY+VJu3iNBN/jO1RLqwp8G7xe3h7fYLknaRta/MkpcW7G0XRkWpBNXR4eu9rWLghzctpwHXT575UVLDXygYA4K6iIW25ZygYOfYFuKlVDGTdIoxEeNMgcg13pckMNhqzXIZbQXB7cXa5Dm4JgPG3+ZXt5t8OA3cu4QgBGVRAqIPG9BM2EccA4uab9GB5oE8Wx3vo2o8GPVB1WUMAxYtKcdPJMFU++vCuMiWWcXHj8Eoc6bM6fG26bG5561BR7BDdLZjl4cQQ+UTqyNGqSxDuPrget1BPJvWpkx43OBZZAowHKB5rZiR2j17Gr//E7UJCedG8cCZNPGmV7Km82ZLB2NcR6Yashq8kXmrmzZVHG7nglKjz82lSUaqv4veGbQ0yojUR5r46QQvpRlNKB1Ne12RJ7Gp6hXZJCRPHaD9d+hkcf/4oLt+Gjgs0zZHvdxzG+is4QgCMrINRVhDfEShNmyPPyHTQqPP68pzRJleFYcIGZTdVZ04Rf9OyokkcpXfPc/gkqLvRpAvzPWmzWBgC9WhOiqx8eHljTESiKQQQ7rLc3w2avsfCK9lCCbuYEI18BrbO/KgtvLqnS8oAfC7Nnk4tXDCrqt77uV0OlvHlWeXuyMeYy0tj30kjV7CDjdOInVwq+SSpW69HIRhJ4Z+PInA4Bb9w16qFtLYqdwYiUy1LQL6gDXWp88VHMScKT5Oqo4QGgOn/VKNBWUF9usQPTqCo4PaQELn4xO8yK2Cf75QNyaqz3RHMZ1syb40wUAW7ct1vOIB1U8h7DQXX/elZmAZmxXrWl0jVyNhUVbrJZDHZ8MM1QShaJ9IJ0tz3rXpB5o0Uy1WBiIOHxtJVmo BHkdsPt8 GXuwYtQabXa/fsPKZiAwUoUCRm+Y2vjZuiwtLG467fjYk3f7Q+9BIalmc2umkg3ds74Hb//fMFMC/HVmOPf6uokiI/YUNreB1+UrnkrweER1jYSaDsUDD9GljPA95Js3vyuO1O+5ht110xNbeek2563c6pMSPCVgN9uYy67/5sUSoT7zuVH52+Qiwcwv1TpxeKw/coTCe9laLFJk6jx4UmFBRfOr40Jajd1478EK4keVUgSTgDY3uOP4qCpLzBjJ0rWBkQUkrMFZC8BQIqv98+Le9kOjc4YtOB01py6sOXUV/80gQ0kVWVC6M3y+3kOuCgfkNhT1Kax8+EuVShMRYBnmQmUE04ByeRcLdK2W99HPfmnZFD2qa2DEMjXx5wZT0NVAwdPjsdzfWegIWabvw/c98gPPVfYDLkhragO8W3WbkU8E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 05:32:11PM +0200, Yann Ylavic wrote: > On Fri, Jul 4, 2025 at 3:54 PM Mike Rapoport wrote: > > + > > +static void execmem_cache_free_slow(struct work_struct *work) > > +{ > > + struct maple_tree *busy_areas = &execmem_cache.busy_areas; > > + MA_STATE(mas, busy_areas, 0, ULONG_MAX); > > + void *area; > > + > > + guard(mutex)(&execmem_cache.mutex); > > + > > + if (!execmem_cache.pending_free_cnt) > > + return; > > + > > + mas_for_each(&mas, area, ULONG_MAX) { > > + if (!is_pending_free(area)) > > + continue; > > + > > + pending_free_clear(area); > > Probably: > area = pending_free_clear(area); > ? Right, thanks! > > + if (__execmem_cache_free(&mas, area, GFP_KERNEL)) > > + continue; > > + > > + execmem_cache.pending_free_cnt--; > > + } > > + > > + if (execmem_cache.pending_free_cnt) > > + schedule_delayed_work(&execmem_cache_free_work, FREE_DELAY); > > + else > > + schedule_work(&execmem_cache_clean_work); > > +} > > > Regards; > Yann. -- Sincerely yours, Mike.