From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED00C71130 for ; Tue, 8 Jul 2025 01:15:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0170A6B03C1; Mon, 7 Jul 2025 21:15:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F31116B03C2; Mon, 7 Jul 2025 21:15:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6E066B03C3; Mon, 7 Jul 2025 21:15:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D6D106B03C1 for ; Mon, 7 Jul 2025 21:15:35 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 81545140400 for ; Tue, 8 Jul 2025 01:15:35 +0000 (UTC) X-FDA: 83639329830.04.BBCBCFA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id B28BE1C0003 for ; Tue, 8 Jul 2025 01:15:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UzIsziio; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751937333; a=rsa-sha256; cv=none; b=0Mr7GJij4iYMOFS9GWPJQPlZJD73nmr65uGlzNdm/ParUmOKXr4dUpVHylvfDsej+CgAOp VmsgyMvBfmlDYF/wOcNwsS6BBYw8KGZKPxcBGIitHitoOkwp2QhX+Q0Ly5gAZFtR6rnLNv llKQL7JzEjzyuPhtU49oezcV28Q4+yU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UzIsziio; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751937333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NCq9jLpVcHtozxDNuvvVZy5vUfqexcgcFQQtBYQ6ojA=; b=7YzELUo6sms75saZsPgx6khUdZ57Itj+C6lP+oAcJDbsNECKEGnoEyOt0x6VdJn4yeR1he jhxJ1zllT6mYgx8crq7KzhHziIpkeJNgOahC28SVfTMLRaNLarlskrLE4Y/rwaXp+Qfpm9 47ELRSHOgn4/wHescIVvzWANaMyUFq4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751937333; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NCq9jLpVcHtozxDNuvvVZy5vUfqexcgcFQQtBYQ6ojA=; b=UzIsziio44XC9DJhp8NYiHfGaUJhR0+4wH7xJ/5ogMQBlos45lUCpAnu3eJOCvhRaIm/2j WF6MnjAxNgrfHiZgSOwD/aAiyJRIaSvCzvCfMG0g5QfeOu7ncNpAddUaXto8PIAymBrSRy +MMAqgkKtTuTJPKoeXVT6aJmb7SYr2U= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-vA0kA_sQMECKoIEQHtN51Q-1; Mon, 07 Jul 2025 21:15:27 -0400 X-MC-Unique: vA0kA_sQMECKoIEQHtN51Q-1 X-Mimecast-MFC-AGG-ID: vA0kA_sQMECKoIEQHtN51Q_1751937326 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 34E7918DA5C0; Tue, 8 Jul 2025 01:15:26 +0000 (UTC) Received: from localhost (unknown [10.72.112.60]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D805A19560AD; Tue, 8 Jul 2025 01:15:24 +0000 (UTC) Date: Tue, 8 Jul 2025 09:15:19 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , LKML , Andrey Ryabinin , Alexander Potapenko Subject: Re: [RFC 4/7] mm/kasan, mm/vmalloc: Respect GFP flags in kasan_populate_vmalloc() Message-ID: References: <20250704152537.55724-1-urezki@gmail.com> <20250704152537.55724-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B28BE1C0003 X-Stat-Signature: 9w1ukusrc1jn9fkjdxhj5jzau9g4m51m X-Rspam-User: X-HE-Tag: 1751937333-152108 X-HE-Meta: U2FsdGVkX1+JoGFOhywwO4sYyawaDVwVTcaXfqoyqqK2ijLIw+oSeRgRmxaGLjCsnJPzuPavr3Sxoif6fuHAU2LnUswvChzKgedTQGfcXoMTBrAa23cKY3bEvpTLhCnclEcNsPJPtc7dklXqcSNK+pb0YCaZLn9mb1LmWwuEJmIFUNBJsEqY3IgY9E2b6l3plzhl2e0qWOL6OBkP5YeRYNl9q4H8KAUyybvS1KGYs97JAOHpFL2+atf3MVaqyefcVPEPi9umQBjo10/VvHQjUVxIGJrNkArzauu4lmJn/TzC1YPft8kFm5s76ggK9ds6deneGiIxR9+fnqix9TIpyFQ9eB487jnJpavVW5ewNFhHdlRxSqwaS7iglHtAvM/D2sQZvg27WrP7OJ/hCFWEr5DIpZ/AI4VBkh5VM0W0PD9PrfXyYV3ATgy6wc9dFZwQtipFG8804sBsZPSORz9MaO9gfzuuWh5RkiTcIN+REhH4iuSJU0cZhIU31mbY4/Ko7A31dBKAaszL4DAgX8PeWvoLN6deOLJFUXQEOBjNZwG9TvQoiA/8o8bgCK0EZ232aCIuClrty2tWCJ0A9rKyl5Ct8V4kvrcfog6oCYIUKrI6VpAkI0QcqZ56vdzZV454j6XuG3PcqExG1hXo04ePdMzniF+D6ppslA6ZmGjWz575krF/5/9t2MH3WE5vkmXCcYnVfsubcDnbcgbInXl3bH8zB1DtXFqBRC0iS5c4emFL7nVIG55Vt8JRc1/pe204Swf/qUo62vMqX7A73C+7dvdBOnvWzqiJRPMsrbm4sPs7joK4kxrKctTX4J1bNzy0uheedCYbSyyeg2GjIEm0vDYELUxW4S40j89j7kLC51qtibfCCHKhzInqRYJYvhyE6yblqBqrwOniL+pnZ/DY+Nx2COv+S48sE3/X1xTp6IVyATkACxozvXcRf6rcxFxO0y+Dj5WIV32NXHRurr4 8ce+Rs4+ 5rfXQfFnZalHZueERwbTjy1tpnrdq9JGHCEdKNrNVmlGj4OTXKCgBbKAt0xjQhocngzWMNbn+qrIhzVI8UYKPmGAblEp5tbNGPG8djr1g1rEKq7XfCH4viytMH41X9pD+OpdnJlhNlRmXUg1PsiZLPM89tlu5GJBeuFfVD2hMhMP35O1SYbd5OL0jTTkJtBVA28IIyV3dh0RONiCM5f2L/p0aDnD3yjQ1AASojpZpZPbrP9ZV4OiTY/XvluL12vhcVQRfAtuVAN61O32PJyaJPL/NmnZ0wNG1qaiFdmtR0aH1yJNKC/6RZaWBhzF1nxAaJ36r7/TFGhwKchMUi9bNDEf8+TiH28dDe23gmHgpqKICJW2VFgk8oWTAtdsLBZxb7wwLQ1ePy8HAMRCveKiLAEPOk918iORfR3Lw/2KMVXhU/O6qVhiH2b2oAzOk6BJqwbXljVCta45V2q990HZ85TW2LNC6SYTWvfj9A3ez4kne4NCFlrYoPI4nTzT7MHdLdaBgHJwpnJ10PSo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/07/25 at 09:47am, Baoquan He wrote: > On 07/04/25 at 05:25pm, Uladzislau Rezki (Sony) wrote: > ......snip....... > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > > index d2c70cd2afb1..5edfc1f6b53e 100644 > > --- a/mm/kasan/shadow.c > > +++ b/mm/kasan/shadow.c > > @@ -335,13 +335,13 @@ static void ___free_pages_bulk(struct page **pages, int nr_pages) > > } > > } > > > > -static int ___alloc_pages_bulk(struct page **pages, int nr_pages) > > +static int ___alloc_pages_bulk(struct page **pages, int nr_pages, gfp_t gfp_mask) > > { > > unsigned long nr_populated, nr_total = nr_pages; > > struct page **page_array = pages; > > > > while (nr_pages) { > > - nr_populated = alloc_pages_bulk(GFP_KERNEL, nr_pages, pages); > > + nr_populated = alloc_pages_bulk(gfp_mask, nr_pages, pages); > > if (!nr_populated) { > > ___free_pages_bulk(page_array, nr_total - nr_pages); > > return -ENOMEM; > > @@ -353,25 +353,33 @@ static int ___alloc_pages_bulk(struct page **pages, int nr_pages) > > return 0; > > } > > > > -static int __kasan_populate_vmalloc(unsigned long start, unsigned long end) > > +static int __kasan_populate_vmalloc(unsigned long start, unsigned long end, gfp_t gfp_mask) > > { > > unsigned long nr_pages, nr_total = PFN_UP(end - start); > > + bool noblock = !gfpflags_allow_blocking(gfp_mask); > > struct vmalloc_populate_data data; > > + unsigned int flags; > > int ret = 0; > > > > - data.pages = (struct page **)__get_free_page(GFP_KERNEL | __GFP_ZERO); > > + data.pages = (struct page **)__get_free_page(gfp_mask | __GFP_ZERO); > > if (!data.pages) > > return -ENOMEM; > > > > while (nr_total) { > > nr_pages = min(nr_total, PAGE_SIZE / sizeof(data.pages[0])); > > - ret = ___alloc_pages_bulk(data.pages, nr_pages); > > + ret = ___alloc_pages_bulk(data.pages, nr_pages, gfp_mask); > > if (ret) > > break; > > > > data.start = start; > > + if (noblock) > > + flags = memalloc_noreclaim_save(); > > + > > ret = apply_to_page_range(&init_mm, start, nr_pages * PAGE_SIZE, > > kasan_populate_vmalloc_pte, &data); > > This series is a great enhancement, thanks. > > When checking code, seems apply_to_page_range() will lead to page table > allocation which uses GFP_PGTABLE_KERNEL. Not sure if we need to handle > this either. I am fool, didn't see the obvious added scope between memalloc_noreclaim_save/srestore(). Please ignore this noise. > > > + if (noblock) > > + memalloc_noreclaim_restore(flags); > > + > > ___free_pages_bulk(data.pages, nr_pages); > > if (ret) > > break; > ...snip... >