From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9664C83F07 for ; Mon, 7 Jul 2025 12:27:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54DB26B03FA; Mon, 7 Jul 2025 08:27:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 525C66B03FB; Mon, 7 Jul 2025 08:27:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43BC26B03FC; Mon, 7 Jul 2025 08:27:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3780D6B03FA for ; Mon, 7 Jul 2025 08:27:11 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C3067160485 for ; Mon, 7 Jul 2025 12:27:10 +0000 (UTC) X-FDA: 83637393420.28.9C28F06 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf11.hostedemail.com (Postfix) with ESMTP id BD2D04000F for ; Mon, 7 Jul 2025 12:27:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LShA2euv ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751891229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vdT3AgUINABtwE8EihkZZFkgFWExnIToCc9PtsmmP28=; b=E+/uC6yMivzeJvc+5/cDmq6aZoyE9R1bB0MpYDCJi8IYpK5q9yCQiJqy99pDWzAd3xoF58 iYo2hpIJVbj/Fm0PoJuBbWxSIUt2gS4GHB15WUUKz++2rpAV6cejTpeODSXOBhWtzbmhhF +S69cysL5BUdd+jKxUYVcfSMAe5HGGA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LShA2euv; spf=none (imf11.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751891229; a=rsa-sha256; cv=none; b=1rDp0K/VZuWGt+SR41ZWvdI/aCT5HdNTtguXc25zSVJc/VVa5P7QAoSzbZbb8U6wRyYrMy otEu2vrQ+nM3DHm3ctxgaJsgq7ZQ5g/uRrt8QzqatvihuYnwov5XhwwBYwLe+d1y4mwAfh d9/hxZOOucvl9ZadnoEAevV4LlP4E2Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vdT3AgUINABtwE8EihkZZFkgFWExnIToCc9PtsmmP28=; b=LShA2euvaWLp3TUtJvlXH4Hwc3 ki8zSGrrYpbbC33U7vTxcSB2v4aYx9fsLxdfv0hO1B/XtIeVg/vZEKImqbzEgMt8xEpVIYBNxRJch JcPrfBezDUk+O3KyHrljn3gnhWcsZyP7o2vOY2+gzdmVd64pIIaGYt9cCBeE0o9Vr9yylRt4UdzkS 7e54tjm/iMe2THJjQbAQWGnkaO2H+fTFod3+fh0cLaTV6A5NyQFJncPgujvjc3rN9/Q7g49jjNjSM 1PnZ8enN3cylXat4ZIEkue08LwLKX4Y0udQqwhETMjTHK5aPm0sPrQxpQw31X9ZP/V5oUovGjOway 6Bd4M5Fw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uYkvv-0000000CzOX-09LD; Mon, 07 Jul 2025 12:26:55 +0000 Date: Mon, 7 Jul 2025 13:26:54 +0100 From: Matthew Wilcox To: hanqi Cc: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen , "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" , "frank.li@vivo.com" Subject: Re: [PATCH v4 4/5] mm/filemap: add write_begin_get_folio() helper function Message-ID: References: <20250707070023.206725-5-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: BD2D04000F X-Rspamd-Server: rspam09 X-Stat-Signature: aqrq4wzg6paowpxfr144y55mfack13fw X-HE-Tag: 1751891228-704901 X-HE-Meta: U2FsdGVkX19wRkFHz10HWUw4pFQSWDe1T5vguhHQ3wVOqK3U8sQ71ARbjUqgCF6TQY7Kvp/obj/M2eWSF8TxldW+h/W0/EFjQPL5VaJ2OOWamgHMVvr87MlKC45UJLmysgwtFbO6k7ifQF8vC7bU1c6BfXzJW3wkfGtJAAasNFzsP2r7ewwQDc/IbQt1ze4YiAZaO+EDbDRcdNkm89ntIMr93SmmEEHOMAvLm+pNJe9cZeZVxJsUHdlbJNplMgYIes19gCnJbSqnk6JyjsUffNxV1LUe4NGJrQsZJ2/5ygg8LxQzhB2ELGU34e/BaS8xDXnRNmGhUNaNiJvR/4DBYv4kgbDoD5WlF4zi12f5+90RCDgXLqNg5bdv7N6y2zeWvDkjoj2or/kej3IUYA0DLta7R1IQ7a5+W+MdlCs6CFzi5AT8HG6wcU9coRHinLQV/ZgEfTQqoU9BjSY3/tGkwv1CtRw5WlehTik9nPhjGcHxgym2/q1erUN4sb3CC1m9g7Bcd7sxrTvOc+NntDr292qTiRRQ+3wc+0IeMg+Hl7Ldr1+Up4PWdJF4XkvgLcnN/E0+NJyRmHBiFPB2V9HFM0bX9ksxcT+a2BkNnFBrmpXYrWOVV2r4pFzUx4L1b/Zoq6DRqPphA/ikVeZTyIwYyX8aWKlSqAR0BwCdqWPF9ywH2RRQZEGy7uN6zlseh5EdAIoBgiNd1LjAP/aNHowZhrmEamoYiRBmHAmZ5ajZw8kW5I0ZTkFj1Jak23i3xXB8WQW+iH+JnrFCSYq3gdXyjvs6xpAVgqB3bqt+g7XeMgRfQP2rjK4QnhPwKZn4ZH4PIMRbqOntf+x5hS7orOSu4XAMSu9wwMupWKLZlDY1ePAAszyVQ3fNOLgT93kixbc05ryvjKlB2/J1AooDguast09hcnruEckUnWaBlYyyXLgVpo9/cFJn/1eUP8NS6r2h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 07:48:34PM +0800, hanqi wrote: > I think it might be worth considering adding an fgf_t parameter to the > write_begin_get_folio() helper, since in some filesystems the fgp_flags > passed to __filemap_get_folio() in write_begin are not limited to just > FGP_WRITEBEGIN. Something like: > struct folio *write_begin_get_folio(const struct kiocb *iocb, > struct address_space *mapping, > pgoff_t index, size_t len, > fgf_t fgp_flags) The point is to make the simple cases simple. Filesystems which need something more complicated can do it all themselves. NAK your idea.