From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67088C83F07 for ; Mon, 7 Jul 2025 01:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9029B6B03F7; Sun, 6 Jul 2025 21:47:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DA316B03F8; Sun, 6 Jul 2025 21:47:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8173E6B03F9; Sun, 6 Jul 2025 21:47:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6F5CA6B03F7 for ; Sun, 6 Jul 2025 21:47:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0C67312806B for ; Mon, 7 Jul 2025 01:47:52 +0000 (UTC) X-FDA: 83635782384.25.0D79245 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 1695520005 for ; Mon, 7 Jul 2025 01:47:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EREvv7Bh; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751852870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1/W2YF/gvP/DLp/ARaAeE9iRBNkC+Eys8vYw5JjQSL0=; b=Jyli74Fs7oRV1+apFcMbk76weM0UrzVg9AQr4pE6I2xKBs9nUu7Mtgk6Y0k5YKI6fkNCou 7v68YmUbDhGhfUXb/CiS6YvhgIUwrinnDWHJpN54RhxbgpZupRxlPdhOGEwGSgola6EuWD 9B9ZQvSYhJoZrrAMtcB3oSAJRh8hgkQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EREvv7Bh; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751852870; a=rsa-sha256; cv=none; b=rMqVR7iEUFIEab+rknpi6+qknLAwQK/1odskPclXeln1bsvLs+aS1qNrXJcoPY52g7aFZK EA4Me71Cp2HWdfCJ4nF3c0TWFyY8rTXSpV/YPy21/UdxozFSfLGel75Wj2ewfUfbMDU4TZ PjPtz/9iVbDVoS9PoVy+ZzizJZUrb/A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751852869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1/W2YF/gvP/DLp/ARaAeE9iRBNkC+Eys8vYw5JjQSL0=; b=EREvv7BhMfc2goms42MV8ilNq01yOm58nO7pLWd0uqkKM80yjjzEc8FRU7GIWGfxR+YaxO l/9r1rGqY1BUduSaig3Oyzu6i/R2ddQvU8lXuB5AnvuUIZgd4A9hwQVMET9DyZ36MQqe5A ogIEzIKG7ezFJotfOYxMAIAdIbLh2bg= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-dzVr7NIlN7utzYeZzBoZew-1; Sun, 06 Jul 2025 21:47:45 -0400 X-MC-Unique: dzVr7NIlN7utzYeZzBoZew-1 X-Mimecast-MFC-AGG-ID: dzVr7NIlN7utzYeZzBoZew_1751852864 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3AABB19560A1; Mon, 7 Jul 2025 01:47:44 +0000 (UTC) Received: from localhost (unknown [10.72.112.60]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 03BE2180045B; Mon, 7 Jul 2025 01:47:42 +0000 (UTC) Date: Mon, 7 Jul 2025 09:47:38 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , LKML , Andrey Ryabinin , Alexander Potapenko Subject: Re: [RFC 4/7] mm/kasan, mm/vmalloc: Respect GFP flags in kasan_populate_vmalloc() Message-ID: References: <20250704152537.55724-1-urezki@gmail.com> <20250704152537.55724-5-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250704152537.55724-5-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1695520005 X-Stat-Signature: 3fipfxz5egretr6sa358cug7coi4xban X-Rspam-User: X-HE-Tag: 1751852869-924431 X-HE-Meta: U2FsdGVkX19Uyl1AQ65fFvEJxdt3DNd71kMk4p+P/75une9NyaSyUDu6FoaslsDJ3e9SkqxBH5lK0b3J3ZjrZAfYxf980lTKG9ksfHljmDmDNoain9pdzY7rupmHCHZmCyvML12WlyiuXh2ZUVN8JtBZS82ivOaZVorCyd8RW8UnZDAbHVcUxv33wwU45URiNG8zMoIJUlP6Ejp8VZa6ol3/IFPagQX/ajbm6dsSqs7vmg3LwNV2SonrG3VnvQ0yMHd2bDXvWLxuGuFnChXOP9n0abLuDKKDqd+6DiwqSrAyZ3QV2FL7ioNuNRvWqzZlAUVdjUR0IofTJct/f5dAkcwUutDE/S3m5qvfc0ksB93/zQvE4Xnfs/1GPHKBQFDSdNQTXkbDEwwGkfmqD/eJ0t0ktXmBmYFfWum/NK7vEiVrumtclPvkgzZj76IA26sWzexn+tnUj3AkqkHIE3cZmwhUNBWx6wKGfSNKImprUGAyhQKs4S+J7Tz7VIKAxEDDqoRCKfB/mQR3eYQSVEhvBVV7V5Mg585tsKYdvQdXdL+VbFxkhPdvfrCDCGH+flTb1H0smRA4xVJGqlSqSLKfABm3XDi1ZPU5Livug3AKOc6pXNl1XJCnTfwJEyEHPXBZRL1IovpAdNR04qBIJ5Oywr75fgRs+31o/7QeTLCXuVv549ynFgcbXxRV5E9yeaHU8/WUaYVzwShKSBrnaQQkeNo8ufK9yeEK+RB3o8AL4XIh1+CSJmnA4kj8Gs+LkAUzDIPGwAzWF1N9lVvYTZnFyIWSPMK/U9huQhfCram/SxnIRle689TwY2LH0NiAvVE/gn+XePUDn91sViBhOkakzeEertqXieMZB50LT2Rh6N6a+sCaLlllphXXxmLtWKkFO0R95/wrD4O0YVljnuBe5eFXDxYoEsvSHSMoJRXeH9qEu+e79CrrS+FrfImwch5zZmIQY5A66VKg3ihvPnU xgTmy7An wRWMo0S4NSo1FCxbfDTO3n5ft2REZImCjyAQr/+fEjDqRCOl0vHdYQVR0mRC1HiZB29sr9VzP/AVraHMX/VZzYfBUMQi5qWOwQiOuL14Pp70IkElbQ7bPgKCKYVdBvN0j2sM4xbdbxp/S0X3TF+W2yVmkav74ZtmzBYXhHFYjco3kCTRBAEQELHT8kPDpOfQmCBeA82PuYfzDU0homOyop8CecGHCHduok4gkp8PpO3OtVXtVtVnhJxo7Zcc53TieBg0Kl84gi11mlhTIVMeT9SQVaWb95rlp63cs2YFJLsH/kH/BTC0AELKEitLYUZ2p+cR3PL4KJlJ9KTa/FPvEPlDPf6SrPBehGVWpoN9cwHNTwA9MnJa8YMsiaOSqD5NkGdT/ZnKjDz4kXBnzKXN7HBJK9CbB44AOAaF+8xYCS+atoftv8PIvXAHYOtD6VNnaVyilnkD1uCjYgXhSObH+jqGucfvHEPztomM2yLTWm4fUuso= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/04/25 at 05:25pm, Uladzislau Rezki (Sony) wrote: ......snip....... > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > index d2c70cd2afb1..5edfc1f6b53e 100644 > --- a/mm/kasan/shadow.c > +++ b/mm/kasan/shadow.c > @@ -335,13 +335,13 @@ static void ___free_pages_bulk(struct page **pages, int nr_pages) > } > } > > -static int ___alloc_pages_bulk(struct page **pages, int nr_pages) > +static int ___alloc_pages_bulk(struct page **pages, int nr_pages, gfp_t gfp_mask) > { > unsigned long nr_populated, nr_total = nr_pages; > struct page **page_array = pages; > > while (nr_pages) { > - nr_populated = alloc_pages_bulk(GFP_KERNEL, nr_pages, pages); > + nr_populated = alloc_pages_bulk(gfp_mask, nr_pages, pages); > if (!nr_populated) { > ___free_pages_bulk(page_array, nr_total - nr_pages); > return -ENOMEM; > @@ -353,25 +353,33 @@ static int ___alloc_pages_bulk(struct page **pages, int nr_pages) > return 0; > } > > -static int __kasan_populate_vmalloc(unsigned long start, unsigned long end) > +static int __kasan_populate_vmalloc(unsigned long start, unsigned long end, gfp_t gfp_mask) > { > unsigned long nr_pages, nr_total = PFN_UP(end - start); > + bool noblock = !gfpflags_allow_blocking(gfp_mask); > struct vmalloc_populate_data data; > + unsigned int flags; > int ret = 0; > > - data.pages = (struct page **)__get_free_page(GFP_KERNEL | __GFP_ZERO); > + data.pages = (struct page **)__get_free_page(gfp_mask | __GFP_ZERO); > if (!data.pages) > return -ENOMEM; > > while (nr_total) { > nr_pages = min(nr_total, PAGE_SIZE / sizeof(data.pages[0])); > - ret = ___alloc_pages_bulk(data.pages, nr_pages); > + ret = ___alloc_pages_bulk(data.pages, nr_pages, gfp_mask); > if (ret) > break; > > data.start = start; > + if (noblock) > + flags = memalloc_noreclaim_save(); > + > ret = apply_to_page_range(&init_mm, start, nr_pages * PAGE_SIZE, > kasan_populate_vmalloc_pte, &data); This series is a great enhancement, thanks. When checking code, seems apply_to_page_range() will lead to page table allocation which uses GFP_PGTABLE_KERNEL. Not sure if we need to handle this either. > + if (noblock) > + memalloc_noreclaim_restore(flags); > + > ___free_pages_bulk(data.pages, nr_pages); > if (ret) > break; ...snip...