From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1998C83F03 for ; Fri, 4 Jul 2025 10:07:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C4636B0284; Fri, 4 Jul 2025 06:07:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19BE46B0285; Fri, 4 Jul 2025 06:07:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D9156B0287; Fri, 4 Jul 2025 06:07:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EF8E96B0284 for ; Fri, 4 Jul 2025 06:07:04 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A275510222C for ; Fri, 4 Jul 2025 10:07:04 +0000 (UTC) X-FDA: 83626153968.15.F162877 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf21.hostedemail.com (Postfix) with ESMTP id A29401C0009 for ; Fri, 4 Jul 2025 10:07:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=luEUiYtu; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751623622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GBpUAXpUHK8L0O5x/PSZEh+Eg1La3x1VdaMrEDGAIBg=; b=qoufTOJaK09WVq4ME7OuG8Ob/ZxgdIv+G0iZ6OqwpbX0qFeczMXlY8mBuyP4fudbPxGW3j MDmJiievthLkUUwwwIX8iqG1Ef1nvidZS/oizCY0sMyIcyTsp+z1mzbUan3wmPSg9eIJoe BXAMgCD+XU+z0Su48kCwMzuMSB5gubQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751623622; a=rsa-sha256; cv=none; b=7f18MyzYO0OuECRHBYJhvOCftVqLadLhgzyTJ5x+dFWbpswGZ6iUuzyHC40rDVA2xGmRe4 r/LFoc7t1O983oOw0rpIijkzRlV/sopc9MsPxm2o7hSFsxx0i1VkP9KbFafzqEHP7WWJWe UCmuRDesXX63as6494Rl1KMIa0bqt2M= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=luEUiYtu; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-55511c3e203so733459e87.3 for ; Fri, 04 Jul 2025 03:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751623621; x=1752228421; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=GBpUAXpUHK8L0O5x/PSZEh+Eg1La3x1VdaMrEDGAIBg=; b=luEUiYtuEG6AJJpJoqd9pMMyNCFTxUib5TDqe9ls9FGXSMLu40gsXzpTsWkHj/GON3 D11RUvAgCVXkGAtLXWQfpXyOsRgD6HEVd/OsMt4T+RTz3T8MEtS8VTN/HMpuOtmo0sB4 hYmi7gSRJldei8Yd7Sl0bvnjwP8mBm7/rJZw/sM9znepbOpk3oA5P47smH5s/A667Xah yP7yHfVnKl2koHtsxvzu4vEvc8xRY4Xld4z7/P2qpBFKCMaMvaTN0X0fcqeB8G3oqVH7 udEZp/9MZcZgw9YffdUnzvtLtPYXpaA5nGBYILcrwH5KNceKLvhXqe7x37T5UCwfukBX ctXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751623621; x=1752228421; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GBpUAXpUHK8L0O5x/PSZEh+Eg1La3x1VdaMrEDGAIBg=; b=QKs/kiMVXdvPdMsfMWX3RZVCq1CfsJDt/2JTrYv0SBxdVnJSTQ76QZErZ8rDfPX+Qt O6AYaLeL23N/DaAfVucTU68WJQpYKWJGwGAK1ujF7CSAoTGFo/6evcGPuBHNJNfHr8YH FMquxGy/4dOMtbKLYDLgHNeLHDAf6wiRX36VIgUtZPmESU3IAHZTLXDasAy8y47ynkLA oYfL5b6JxdjhHv3g9VXGXfzur831XHFEwiqmeZUrzU8XoyiDyjpF7T0voukXdIrBjXTu doZrc5ceF5UrYCR3o7IGvcgr8x9bMQPEF0x2rpYIAFqGuZJIDS5O+Q2MiINzhpfg8RG0 0fCA== X-Forwarded-Encrypted: i=1; AJvYcCVaHE6FboFqytlgtuVIz+nNiMG0YOMfq+VFs/8jsnpIj3F5cmr5DZM9U+oArIDdGsa45Er3L0w5Nw==@kvack.org X-Gm-Message-State: AOJu0Ywe8Csxi63pwgwYw9SUJjzQyO9drMo7gKnefhdVJnBeReWxq2VB jaFN06s3H4/HuTQec1qEtQhXPO7ul+taG8o4kFFcT7gg2CEF+pYroKb0Qf8sdg== X-Gm-Gg: ASbGncsyCSRT2WzoA+sj32mgKhBr/iACkWndQemFq3woExiY223KNi6JUhIclZoHlty 6H5NxwpOTq6D95X5iIjFtKEJY/m5+nxCDUOMjFBDpMQzU2jS/9XJWN+cqJdjI25XtmhCy6l0R4F 3t7jlCmIrQaaGLL7fX8jIepJxUkRKvB4ZsvKhHO21SZXCRreXjWDGxXWofAWAJYbwklvNee8aU/ HJAEg0UdNBi3HblfV9cvAfYVX8TMwo0M1qQ4wCtAhSRfRuUMFhawPz8mFmiMQ2docZ4TWC8nzJR 9XOQGx+JCMeO1dEvyY7Dh5ZUGBQry4T0MqJeOlOslRF6mgAgMTgJif80oFYAZP4GpiKtAd8+ot8 vbnFAwSJDpxWSvQ== X-Google-Smtp-Source: AGHT+IFbHYwsnJG/zAoff3r3kG9W1cPaInyvNJ/r1hgcQ3EPqYgv6jIk4fD2RQezZhgJLjqbHip+1w== X-Received: by 2002:a05:6512:ac8:b0:553:3028:75ae with SMTP id 2adb3069b0e04-556de076273mr643698e87.46.1751623620593; Fri, 04 Jul 2025 03:07:00 -0700 (PDT) Received: from pc636 (host-78-77-210-196.mobileonline.telia.com. [78.77.210.196]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556384943aasm205546e87.111.2025.07.04.03.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 03:06:59 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 4 Jul 2025 12:06:57 +0200 To: Raghavendra K T Cc: akpm@linux-foundation.org, urezki@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] lib/test_vmalloc.c: introduce xfail for failing tests Message-ID: References: <20250702064319.885-1-raghavendra.kt@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702064319.885-1-raghavendra.kt@amd.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A29401C0009 X-Stat-Signature: ka54rmooyfxsmssnm1ktthptkrxpssdx X-HE-Tag: 1751623622-495712 X-HE-Meta: U2FsdGVkX1/U0rEw5I+UI5YradgbVeM9f87J9/URgeCST7G3p4OT+W0ICbgao8ipXrbo9FYLxUj7qjTTdWgVMEdWr60A0brq8vAlMp4DZP7HgoZCEgi0XEtoPnukfEjp2qjPtJV6Cko/IYrPyDPqAanj1RJKsToTguc7hs0hwONEyb+gKtIYjPF3xdswHhDe7ftLD+XtKqOkHCVMUWgLCIQGRuHCpzxkAVq1WhcB1EHERFEU7ptBFrJrtr5Y4KZOTImr8Od1NAwd3ua/vi7OKxzvtmx0L9/foM7F2HYn4BnBl8VzxJed7akJGiG0AcF55XZeAAAL3qRat0DtpPmIyvUQxUuMSip0kpMR4cQlhmYgSBoQ1m2Rqc/rfM+HEr1pEv9xkd16adXqh0QClWnLmk/KeDmO5RIiFDdrvFqtrkiERXLDLw1poiGBnlmBR/kQ3UpjM8XggxlH4e2uxHntncUK6CBU5y7aSBjpMohjAbvHtqRefYEVJWlJ3MPXLV4bz4YsaxuZcfmJy1rR9N/Wh0eqg2daS0TT6YdaqJDZTKMzCIYkDIRXi7D4qbCSbTadjoSZeg1qFdREnxVl9W53P0hCuPjia30zgLywQUEYXtjfVUqDbQXogeL8sozNtwd43SN6MuMCbrxhWgwMMSmWqwrGsBALIygs01SJlBndRnaVbtWTUwcf3ubWYk8rqs7WJv2wVhytu+1C2NRVaP822BF3WvWDPYdrTy5KYNTkVGoSz0nwjRJvwmpWtgZFStD4a/6w6y7AtL+ZSnnFesSiteqH7ffLq07Lr3qsQ3Oc4Jfe+lB73hw2obc8mUnLTlrYhjnzTDR0+/I3oWfms9WeNBDx/KtUOr8PmsXqWNMJbPnCujxsBRG5zxM3etQ30+eXnsBQ/Rx8Ig+0b9CijGHnw6iYA8oMyT/lQ8z44D4kn/oBANmdNOt4S6MQnRCt6HG+jknjjLkNaLUVHtxjpLd Jmv6j7qI 2qyhP1qVyEtMv+cWLCXec6U6kGk4m1mEUyfNfpgDPMZhvZ1Jyz/yE/fNcglnU5cSY9PD7QXRBM9U5Pjvfw94fYhAnshmV4FeEuQg6jJPALqT2hZK62Kr+kQqMsDgBMvANsQgS26zTYhCTttKqdywUXYvR0kG+kfUVzXLgaa3Eodv4vFy7FnIxyrbr+35x5qUrCvSkPXZS8FqxIPvd0F9x+ulxPHdjZkwlCohNr2SYvZM/Eaa/QZ2G/V9kB43xO1kmGo3cq+Shgkmw7U9lxQac2ZtjMaT1HGxWnQpPoV10zJpHBCv8t1B5q4tKkMd+/AMUOL0HpHipm1uBFq8hdBAOWVC1qGuBI/VkxIPFn4PDdwfd7FMmWYnSc+JCrFVYVt8NR3/C5abXNaRRx1qgdBbIixAhJe4aXBgLdH2nclV3E4cjucd9xFkNBGUZOa91zTY7eumuXSI0ax/UAZX/9IZN5UuwcAln3IShk4ccxJMHhaqNh+RzVaqffdM/WrfTEO7HeKWLrmFhGYcKASc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 06:43:19AM +0000, Raghavendra K T wrote: > The test align_shift_alloc_test is expected to fail. > Reporting the test as fail confuses to be a genuine failure. > Introduce widely used xfail sematics to address the issue. > > Note: a warn_alloc dump similar to below is still expected: > > Call Trace: > > dump_stack_lvl+0x64/0x80 > warn_alloc+0x137/0x1b0 > ? __get_vm_area_node+0x134/0x140 > > Snippet of dmesg after change: > > Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 .. > Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 .. > Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 .. > > Signed-off-by: Raghavendra K T > --- > lib/test_vmalloc.c | 36 +++++++++++++++++++++--------------- > 1 file changed, 21 insertions(+), 15 deletions(-) > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > index 1b0b59549aaf..649f352e2046 100644 > --- a/lib/test_vmalloc.c > +++ b/lib/test_vmalloc.c > @@ -396,25 +396,27 @@ vm_map_ram_test(void) > struct test_case_desc { > const char *test_name; > int (*test_func)(void); > + bool xfail; > }; > > static struct test_case_desc test_case_array[] = { > - { "fix_size_alloc_test", fix_size_alloc_test }, > - { "full_fit_alloc_test", full_fit_alloc_test }, > - { "long_busy_list_alloc_test", long_busy_list_alloc_test }, > - { "random_size_alloc_test", random_size_alloc_test }, > - { "fix_align_alloc_test", fix_align_alloc_test }, > - { "random_size_align_alloc_test", random_size_align_alloc_test }, > - { "align_shift_alloc_test", align_shift_alloc_test }, > - { "pcpu_alloc_test", pcpu_alloc_test }, > - { "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test }, > - { "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test }, > - { "vm_map_ram_test", vm_map_ram_test }, > + { "fix_size_alloc_test", fix_size_alloc_test, }, > + { "full_fit_alloc_test", full_fit_alloc_test, }, > + { "long_busy_list_alloc_test", long_busy_list_alloc_test, }, > + { "random_size_alloc_test", random_size_alloc_test, }, > + { "fix_align_alloc_test", fix_align_alloc_test, }, > + { "random_size_align_alloc_test", random_size_align_alloc_test, }, > + { "align_shift_alloc_test", align_shift_alloc_test, true }, > + { "pcpu_alloc_test", pcpu_alloc_test, }, > + { "kvfree_rcu_1_arg_vmalloc_test", kvfree_rcu_1_arg_vmalloc_test, }, > + { "kvfree_rcu_2_arg_vmalloc_test", kvfree_rcu_2_arg_vmalloc_test, }, > + { "vm_map_ram_test", vm_map_ram_test, }, > /* Add a new test case here. */ > }; > > struct test_case_data { > int test_failed; > + int test_xfailed; > int test_passed; > u64 time; > }; > @@ -444,7 +446,7 @@ static int test_func(void *private) > { > struct test_driver *t = private; > int random_array[ARRAY_SIZE(test_case_array)]; > - int index, i, j; > + int index, i, j, ret; > ktime_t kt; > u64 delta; > > @@ -468,11 +470,14 @@ static int test_func(void *private) > */ > if (!((run_test_mask & (1 << index)) >> index)) > continue; > - > kt = ktime_get(); > for (j = 0; j < test_repeat_count; j++) { > - if (!test_case_array[index].test_func()) > + ret = test_case_array[index].test_func(); > + > + if (!ret && !test_case_array[index].xfail) > t->data[index].test_passed++; > + else if (ret && test_case_array[index].xfail) > + t->data[index].test_xfailed++; > else > t->data[index].test_failed++; > } > @@ -576,10 +581,11 @@ static void do_concurrent_test(void) > continue; > > pr_info( > - "Summary: %s passed: %d failed: %d repeat: %d loops: %d avg: %llu usec\n", > + "Summary: %s passed: %d failed: %d xfailed: %d repeat: %d loops: %d avg: %llu usec\n", > test_case_array[j].test_name, > t->data[j].test_passed, > t->data[j].test_failed, > + t->data[j].test_xfailed, > test_repeat_count, test_loop_count, > t->data[j].time); > } > -- > 2.43.0 > Reviewed-by: "Uladzislau Rezki (Sony)" -- Uladzislau Rezki