From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 298C8C83F03 for ; Fri, 4 Jul 2025 10:06:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 852866B801C; Fri, 4 Jul 2025 06:06:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 829E76B800A; Fri, 4 Jul 2025 06:06:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73FEC6B801C; Fri, 4 Jul 2025 06:06:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 62B4C6B800A for ; Fri, 4 Jul 2025 06:06:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F14EC80421 for ; Fri, 4 Jul 2025 10:06:03 +0000 (UTC) X-FDA: 83626151406.18.F9AF097 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf06.hostedemail.com (Postfix) with ESMTP id E8D0218000F for ; Fri, 4 Jul 2025 10:06:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jXBB1Xo4; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751623562; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dcL/QQv0v6PsTVP/Yd2c+lopgAA2CTPotWFkTnuxIZk=; b=L3DsZAQgv/4W24JGkpqtZmexbs7ZqjzzP6AGgfmlopAhT6W0p0NxQ5kA8CJL/kLwrDYjwF 8pS5T4wTrpyoNqKyQAB8SFf2fbYdiKkZy/1LbwvCfv5t3W7fBkjciu2+lpFUjvaZNTkkAe 5R2FjLI77utcIP7fQBKWT4vpbAITHNM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jXBB1Xo4; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751623562; a=rsa-sha256; cv=none; b=imVBN6cLqJeUWtsCqruFRCwTp0F7H+Nj27UuDW3B/reGxxY+RYqtNnRrSzH/E6FHNg4vkN lfGMdgyr/wY14FNI9qnbmynoLih2BvOQaRi5xRrU2GE7jgxrZSAoyxfDWbtF88lzpzYCNv 9+KEjF9If1g+1e0V6CHMc95nEVVpmTk= Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-553dceb345eso968004e87.1 for ; Fri, 04 Jul 2025 03:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751623560; x=1752228360; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=dcL/QQv0v6PsTVP/Yd2c+lopgAA2CTPotWFkTnuxIZk=; b=jXBB1Xo4iCBwuDF4UQJ3PE/JnLY8/kIxeJWMcdiHZpmpiR9vBfP1hnq/wK2GBNRhq3 4Q6yY0HrablqumGXPdyt4Fh4gzzIjRJYuSm9rbiAajvgggKH56ozQIPrqVuHY/2Q/Yaf 7Si+12pl4nS9Lw5nDHVSD5IHnzkuMV3g/n3RW1Lk6ZcrFWnil39aA3N043/8Zg48a3gJ oHVL2MYvm9BXOGNANXzCqLLO0iG+sMweUL2vO6UfI1aOUcI5Yq8P0jx1vD48Oq+PIgGu Jl3fRfmDbx+Gy4eM5rQf3ioAjZR1kuMxg0nAuvDB/jesxizmtNZ8royGSYEnBWadtoPk BkJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751623560; x=1752228360; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dcL/QQv0v6PsTVP/Yd2c+lopgAA2CTPotWFkTnuxIZk=; b=mo3gWcr9JYcYX2mQQo3pAajAZAO9QdS+OV4GTxZRUE0+dDrNVyqk4gUlJ71UXLzHoB KljZ0dfsDyy/le7S9M/8DTvaNAmbRW5IWIBvCAIqzvxqm+o7YQ5wr/ZnNNaODlYtpRxc +iFHWTOtFxHuDWjpz70EDeIa91frZotX5vkqghsl4/tuh9VcRhZ+J6Lr2ibOch94HCX3 fjLL039FzWLv4vZA9BaiTbLDhssnTQNjP6rg/8k6eeBTvVAsOPNtvBDy1SkuHnsKFPYc lQIdv5axlKEzm5NaHg5wxm8xKoVVFVpJLauaIsq4d6SsSEHNVnb/DCZA8Aj1qruD76Tg MAAw== X-Forwarded-Encrypted: i=1; AJvYcCUxJO+O89y9mjLyjouv4gmfp94kmV/d3cTHwALxC4dm+aflOEU85vu/4nR1yGohwUQhccVKcUvP9Q==@kvack.org X-Gm-Message-State: AOJu0Yz5u02RjrFC24avX4N97Tbq4Ufbdn92ksoo9lq5QRbeNNPsQki0 iXiwlH0aQsQEt5ig0n1kGXIAvfKDTS7vaZPwI4u6x6EiAzloia1peHKm X-Gm-Gg: ASbGnctFynnlz5gIxVGJYbKAYv8cGN36sMb3DeT6XOYIRK+Oe+lJjJ3gIGrh/A0r/Jb 6l1Q5nsdz0w+t9/LtuJEwqG15xc31WhGEA8fQ56UwfBndTovoaDWZv/dl9JcfmFvoupwRBRC+GS 1cVoPrlp9wWatXtTUClBf7GjIKgTtE6Og0R6ZyJkDfGgG5wf55OqkdK8v1PoJjMYX4pjACelOvD KxDKTQsfaw+86I87SBwlQ4lz0YkiXXr7tNTbsDzOCX/VVL/33MscCkTclUF5eZFvSyQBA8OCcFJ NaKQZ96ggPDW44YoUxXXX551Su3hU5X9Qjijcmw8BGTRKCM4bDT0UQkH2Pw3vdfKFDx/yRI/N+u ylrGVClKFO0IfwQ== X-Google-Smtp-Source: AGHT+IFvpYCtGG5n2rvYiQTV9df6qhwb3okjDIjubuUdvRt1MOGH/ylKO+3O8AH7k8mMH0IPufBlXQ== X-Received: by 2002:a05:6512:12c4:b0:553:314e:81f7 with SMTP id 2adb3069b0e04-556dbd9640dmr605375e87.17.1751623559489; Fri, 04 Jul 2025 03:05:59 -0700 (PDT) Received: from pc636 (host-78-77-210-196.mobileonline.telia.com. [78.77.210.196]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-556383baf64sm209380e87.36.2025.07.04.03.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 03:05:58 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 4 Jul 2025 12:05:56 +0200 To: Raghavendra K T Cc: urezki@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dev Jain Subject: Re: [PATCH] lib/test_vmalloc.c: introduce xfail for failing tests Message-ID: References: <20250702064319.885-1-raghavendra.kt@amd.com> <8adf60ed-91ed-4469-86ae-59e8e30bc6ed@arm.com> <1ffe2e4d-88f2-4e2f-8888-8cb278f1cc28@amd.com> <980a1569-cdae-4343-bd94-4fb2ea6e247b@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E8D0218000F X-Stat-Signature: wfzdakjmez8rrwoy8uikxy96eqnjx7ob X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1751623561-59877 X-HE-Meta: U2FsdGVkX1/2YWlr0p5W24gJhk41UG9o6jlw/CwpMcfCAAyBWQL8pPUmRZdL3AFrBtP/yvKun7Zd8PINQXTgXOl0X5keCnFk47GoUPQyGvmqckUgVwu4Jl+HX2GHXjH3WqQbq7l/ooTxa3S3lXOg0ermtJuMvYwlVZfdZ+LX9IRZtZY4s0zR3jrcjCCJGWsCxB3dAT18WKIrc27bRAQG20dKw7ZYjupKUIMIVLUe2Yimj1Pt6pvj0c6MdicBsZTF5f5aepao9H4lsA1ye4+gRNiZ0wgXnj8/h0eFqL/moNUL43b/Y96i4UCwm+GsqxQrQpJvfHorhn897cuzABarPI95AM4weMiBr7xlHOPSiOG5F6LzPRF+Qbce/PwIbRf7B136nJPMNzir1674o+gsQ3XOCQi4WxkAQ8XLmaBqC76adDj4ns7tW71UujWubHFwNtS4Rxk7PDoat4KVZVP4HELia2MJtmGUK4OgNtj2sbvsn8X6O/L8Ns+l+ojbgDzSyVW6j6wtFC0Fn1Ljp+8CHIkpbgZbztNglB0eqoQic5uBc7JP1KMKbXiEvgS2bbswfuoGBLE9nTQkKiDytlhetWykyotPNmywsibsNAKS24+MSOTC4hdW29PLR7QKL1xdbkXXOruHW0/oryRPIaocaT/XsXwJUAXF3ATIm+pIS/Z/yFMg/YjWaTOsVjO8qgP0lWrJ221VzOS9X2p1QS11eVGJzY47AovJ0aZbiyeSMiGmaRR1Ot7j58OatHPIo/tsS3CGWEPFaF41NGTn2i/pC7C03hXlpmqyBw4JYegmRo4YUDV67wO8G0k/kfUPiGYg88ngWbKjVGcG7Nq4MzXb2p2Uy0saYyt6XrLbq9YIVGUlW14tbvLxwlRt3m/V+xfLlIPezxC5f86fvgCYjBLf3gWwNqT9COO68HjTpUZaGD/jjrJoSmjOWJP5utId9WN3g9SFP0zxL37oBIus5YM jZTAa8mp brCaLJiYzh5jBfg3Xbfa+54pakbuDonFMmQ+CcpFRFL5ip2o2pLQsi3qeaLqlXO/st74qHd3jrmqm7M90zPE3Yosn3c8KiKdgQl5auVypDEhJDMy/Jvf6TbHpgBOIYhrP9XoNGoWaeyth7vohIxX4KXuYYitEP08YoAvsDU8GlnbED0DoE8SO8c+2GZoGzbHFsF9GiJA9COQ28cfY32JZx48r5s92THTrsjD4WKb4LrBolhUIvyCNV4/FN8VnJygxFS1yzM1rrrhknLTZnMt69D50+Rn78qu4sPhDKlCb9OVSCkFOWNNvcF0yx4bADFRMuMdYeVL8TNWCN6PDV9tNNdjT+DS0GfSszBFF6/XOqb5TXVyF8fwTjEQ5h+dubEO1qGXWhWmXvz+gbU0Yv2Adyjq/5n3SVkPgmXUedyTub7Es0OIzffW6kVC1oA/t5T2NugB3OUG84xSy+lisxEvPPbl8MFs02GMLv/VfnEW5GtpDEfT0aPJ1a8dQUDA3apELtXEQbQT1yD7yjUE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Raghavendra! > > On 7/2/2025 1:43 PM, Dev Jain wrote: > > > > On 02/07/25 1:38 pm, Raghavendra K T wrote: > > > > > > > > > On 7/2/2025 12:18 PM, Dev Jain wrote: > > > > > > > > On 02/07/25 12:13 pm, Raghavendra K T wrote: > > > > > The test align_shift_alloc_test is expected to fail. > > > > > Reporting the test as fail confuses to be a genuine failure. > > > > > Introduce widely used xfail sematics to address the issue. > > > > > > > > > > Note: a warn_alloc dump similar to below is still expected: > > > > > > > > > >   Call Trace: > > > > >    > > > > >    dump_stack_lvl+0x64/0x80 > > > > >    warn_alloc+0x137/0x1b0 > > > > >    ? __get_vm_area_node+0x134/0x140 > > > > > > > > > > Snippet of dmesg after change: > > > > > > > > > > Summary: random_size_align_alloc_test passed: 1 failed: 0 xfailed: 0 .. > > > > > Summary: align_shift_alloc_test passed: 0 failed: 0 xfailed: 1 .. > > > > > Summary: pcpu_alloc_test passed: 1 failed: 0 xfailed: 0 .. > > > > > > > > > > Signed-off-by: Raghavendra K T > > > > > --- > > > > > > > > Thanks for doing this, been thinking about this for so long but > > > > I'm lazy : ) > > > > > > :) > > > > > > > > > > > >   lib/test_vmalloc.c | 36 +++++++++++++++++++++--------------- > > > > >   1 file changed, 21 insertions(+), 15 deletions(-) > > > > > > > > > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > > > > > index 1b0b59549aaf..649f352e2046 100644 > > > > > --- a/lib/test_vmalloc.c > > > > > +++ b/lib/test_vmalloc.c > > > > > @@ -396,25 +396,27 @@ vm_map_ram_test(void) > > > > >   struct test_case_desc { > > > > >       const char *test_name; > > > > >       int (*test_func)(void); > > > > > +    bool xfail; > > > > >   }; > > > > >   static struct test_case_desc test_case_array[] = { > > > > > -    { "fix_size_alloc_test", fix_size_alloc_test }, > > > > > -    { "full_fit_alloc_test", full_fit_alloc_test }, > > > > > -    { "long_busy_list_alloc_test", long_busy_list_alloc_test }, > > > > > -    { "random_size_alloc_test", random_size_alloc_test }, > > > > > -    { "fix_align_alloc_test", fix_align_alloc_test }, > > > > > -    { "random_size_align_alloc_test", random_size_align_alloc_test }, > > > > > -    { "align_shift_alloc_test", align_shift_alloc_test }, > > > > > -    { "pcpu_alloc_test", pcpu_alloc_test }, > > > > > -    { "kvfree_rcu_1_arg_vmalloc_test", > > > > > kvfree_rcu_1_arg_vmalloc_test }, > > > > > -    { "kvfree_rcu_2_arg_vmalloc_test", > > > > > kvfree_rcu_2_arg_vmalloc_test }, > > > > > -    { "vm_map_ram_test", vm_map_ram_test }, > > > > > +    { "fix_size_alloc_test", fix_size_alloc_test, }, > > > > > +    { "full_fit_alloc_test", full_fit_alloc_test, }, > > > > > +    { "long_busy_list_alloc_test", long_busy_list_alloc_test, }, > > > > > +    { "random_size_alloc_test", random_size_alloc_test, }, > > > > > +    { "fix_align_alloc_test", fix_align_alloc_test, }, > > > > > +    { "random_size_align_alloc_test", random_size_align_alloc_test, }, > > > > > +    { "align_shift_alloc_test", align_shift_alloc_test, true }, > > > > > +    { "pcpu_alloc_test", pcpu_alloc_test, }, > > > > > +    { "kvfree_rcu_1_arg_vmalloc_test", > > > > > kvfree_rcu_1_arg_vmalloc_test, }, > > > > > +    { "kvfree_rcu_2_arg_vmalloc_test", > > > > > kvfree_rcu_2_arg_vmalloc_test, }, > > > > > +    { "vm_map_ram_test", vm_map_ram_test, }, > > > > >       /* Add a new test case here. */ > > > > >   }; > > > > > > > > Why this change? > > > > > > Perhaps not entirely necessary except for align_shift_alloc_test line, > > > still updated the field since one more bool field added. But let me know > > > if you are okay with current state OR need a respin for that? > > > > Oh now I saw the "true", I thought you were adding commas for no reason. > > > > I think that's fine then, but will let Uladzislau decide. > > > > > > Uladzislau, > > Do you think this patch would be useful? and above change is okay? > Sorry, i missed this. Yes, i think it makes sense since it confuses people. -- Uladzislau Rezki