From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42569C83F03 for ; Fri, 4 Jul 2025 08:25:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACB326B029D; Fri, 4 Jul 2025 04:25:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7B8D6B0301; Fri, 4 Jul 2025 04:25:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9916C6B0302; Fri, 4 Jul 2025 04:25:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 86A046B029D for ; Fri, 4 Jul 2025 04:25:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 08B5F1A25B3 for ; Fri, 4 Jul 2025 08:25:53 +0000 (UTC) X-FDA: 83625898986.09.D51F2AA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id B9BB41C000E for ; Fri, 4 Jul 2025 08:25:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TtH81I2V; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="W/7mXwZs"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eA4nUpM5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VlJzt5bp; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751617551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zf43yxOuE7NOmR0oJcwZ9YLRAPEySM2EmW7Socr/hv0=; b=52hwsPeY0WWxUEqSTL309rjkjPRfdOVHxkwC6Lqn9fww0PlYn3XPWRgTkVTdlZ7tN2GLx7 2vfsr8BzgS99qNa1Fxgx3lt4fDqfhCwoGYNqhYVgD4ZafafHj/MWJQa6VuzrJiuu2hNTwc CtuFt782PcPvWPVzJaWTXnjdk/3uuUI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TtH81I2V; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="W/7mXwZs"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eA4nUpM5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=VlJzt5bp; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751617551; a=rsa-sha256; cv=none; b=QjVb9nR+N6qM0zz6gDNP+Vqv+CzL6khIRwmntj9Joxo/QdhAdejlgEnOFyzXwicz0XmKE3 mTq+2WXk3x4KfvdjW6p7iy+daH1WGWBFSSfAv4IyWTotURZ0kzh6R6B6dRpgWI6+4UNZdC N/NxYbb5UjcArNdQgz7Ht61yKq2DKvk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C753E2116E; Fri, 4 Jul 2025 08:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751617548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zf43yxOuE7NOmR0oJcwZ9YLRAPEySM2EmW7Socr/hv0=; b=TtH81I2VMhThvp4kTyGuvL647uAmVUM4eXJ/uJ3H2oQPwaFzpS8hLow1lvqxHeDzJ0NTs9 xvEyOZjWNP1MNhqkjjv2dSTChxJqchW/AU8xbkzjbGd9+PG9uw/1HRp2WRhkw/tZ7DtDU+ phx6GbvXgFnmqbLfr+W6RDqMdLJ2DBQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751617548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zf43yxOuE7NOmR0oJcwZ9YLRAPEySM2EmW7Socr/hv0=; b=W/7mXwZsyUmJf7zf5E0wlEWq4YDDcd2S0EBHtQBh5y8UBIyUGuDBT4OnQnwxChi05QZzb9 qJ+P1f+EmtMIrSBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751617546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zf43yxOuE7NOmR0oJcwZ9YLRAPEySM2EmW7Socr/hv0=; b=eA4nUpM5nrIyjrnl856c5QiPBkpnBqOVvUddVTBlIYnpzLVja9MgMZjseGGfY34c5GlfU0 Rz30UMihnhTk5nP1ivXIt5ZPtUj9ogCTEzvq9M4mj1BJwYF1YP4ggDU+aKWjtwftd+K7dS Wv2GGxFfBN6zvPJ1g8oqwKqE5Thfj18= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751617546; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zf43yxOuE7NOmR0oJcwZ9YLRAPEySM2EmW7Socr/hv0=; b=VlJzt5bpHg4+PSEzWcBM5mt+0/M4lkESqs/Eij3if+PRUsymHx5suhqrKGdPMcm2v/+cFn hWm3xeZW3Tak7/DQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 87B4D13A71; Fri, 4 Jul 2025 08:25:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id yu9wHgqQZ2gqEgAAD6G6ig (envelope-from ); Fri, 04 Jul 2025 08:25:46 +0000 Date: Fri, 4 Jul 2025 10:25:44 +0200 From: Oscar Salvador To: Hannes Reinecke Cc: David Hildenbrand , linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/memory_hotplug: activate node before adding new memory blocks Message-ID: References: <20250704063404.27495-1-hare@kernel.org> <20250704063404.27495-3-hare@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250704063404.27495-3-hare@kernel.org> X-Rspamd-Action: no action X-Stat-Signature: 1j6b1eqc36pusuoaqypg49jtffepa4he X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B9BB41C000E X-HE-Tag: 1751617550-268878 X-HE-Meta: U2FsdGVkX19lMGcVc0rIuG4ZtNUUOd0mRkHvZsgI/BIWjxTb/hWI3/7DqmMOsmktOg8H+v+waNLrOQfcbfdGNjd+tpPHeOY3YtIhblQMee6V8sBxGE5cFTJoEPHFfFF130HMfUzxdfmberQjjanvfCkG3h+MZremV2xWo145Ze8OtB/0Qxa0Po51h+K3GQ4tdWPsGkFJTbfOgu0ERvhc74jTNLOMNo79gID+cASk1nGbX7sRWTAjIuqeMFy9f8FEDO6vDEfZU/Syzk8nQm32Kmnpth479bLSWPSEptWMn4JhRnbbSSjHiUPtgO1AM4jLUgqLW4Pcc9THF+JzLqtcVlN+jKoD5Zcds+5ZNuvHTT9LycgyT1vdDkqUXZyFLsvidjAs7F1eAMia0EXxoOaXqGf4DRlqUo+cIctlFgNMNLTRYE1M11NeWZRagG7iaEoUOfRqfkCU2HQQE3V+fwM1L24OqHb2VFV4WMVRsHjclu9g19ne0IA18SyOy6oARQouco8qYS7bVtt7ff0fTRdxQ30NagX5eLymgFFPeLTdCI+pjoJT9MJpFKKcfFVZ9mq0417anAwQpU4O5CvBCXO3TUsNlQJDk9CM683MfPGWnbNrlla2YdIFa5tTcJFrfaVH0mXIysByWgeqwnW3x7L8I4TzQtHacYNjXSHJYKc7ZQ8Q/WXdiZqfhOONupFSiWqT/ujbpC4pfLNoR0gM2sUZuzxGzRFJ3plC15ebfPrp5xJCCvApvnkFXhX81mw828awSzsa3/pEf4uKw6LQAZEA+won+763CjKtxFjBPoB5OyaBfrGWUo0g1npHAkni5omIfS9VMd9VT/w6HMTUk6yAxlsF9kiB3Mwep61C7ZwQDj0pFjzarQ+PAgiYTyrrnZHMXYGHIlJNK+G2aA1rA5DARKQpwy+7Q7J7L7St12+BaVNyGEw9hnTtr88eAc7Xy7tF7p5Y+MqB7T41POTVjgN BqY+32Ef 1ARhmx/bTaRITZS/AdUxqZck6BZc+AuOrMIuK7vAY+Mo+RhAvwaDP83XgxYOtWjL8NsBLQAMcUMS1nQD6+JXjZtYEwuzpnqFduTbbUqzwSTVCin6w3+2kDe8oDaRAO5hzwvtSOAsrTuyOZLeOOOTIn66Xu1laGFw8muszzQZEvSIFVfl2+UWGGg2ZPu+iFNz2E6IbFpxACijlphQEtf70mI6Wh6pp15CIcEmJ0OQ9GdW8wbrIW2SQwHQDurGhSDrUXRdQ/n+rHmSbE2ytEphn7TIfPXChV7C7NnnT2jQUjwjVob5pqDy+k0zOCMXowPFARL47drfGC1uWBwRWhd7vqPeHNL0dUVsk/OyjNLtXjw+dOhQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 04, 2025 at 08:34:03AM +0200, Hannes Reinecke wrote: > The sysfs attributes for memory blocks require the node ID to be > set and initialized, so move the node activation before adding > new memory blocks. This also has the nice side effect that the > BUG_ON() can be converted into a WARN_ON() as we now can handle > registration errors. > > Fixes: b9ff036082cd ("mm/memory_hotplug.c: make add_memory_resource use __try_online_node") > Signed-off-by: Hannes Reinecke > Acked-by: David Hildenbrand Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs