From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447F5C83F03 for ; Thu, 3 Jul 2025 18:54:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CEDBC6B0288; Thu, 3 Jul 2025 14:54:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9CDE6B0289; Thu, 3 Jul 2025 14:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8C7F6B028A; Thu, 3 Jul 2025 14:54:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A92946B0288 for ; Thu, 3 Jul 2025 14:54:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 39EB11D881B for ; Thu, 3 Jul 2025 18:54:43 +0000 (UTC) X-FDA: 83623854846.25.5F63E71 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id 07A0B160007 for ; Thu, 3 Jul 2025 18:54:40 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Xe6qTk/a"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+ZBLDWh7; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Xe6qTk/a"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+ZBLDWh7; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751568881; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vzsfFTiRS699y17GeOyLYlzkrCo2oTvb9iPpWQ+lCzs=; b=LY+qA0K73KguyaoGzQ5F0YJj41Gt+JdmIg37esknMJc8nKXl8QnsqAFwJkxjMM+8KCKY6H LeYi4NlWAd2sRcJdtMlz8oiLsjgIjbpouvIrOGUUy7DYcxJaCKXLhlCUFOHu5uLd0cBLhT Cv1t1+nWmlAXoVU/vaOmikeKecStUlY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Xe6qTk/a"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+ZBLDWh7; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Xe6qTk/a"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=+ZBLDWh7; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751568881; a=rsa-sha256; cv=none; b=pLq5kcL3T2R+AJyhEbx6pc4vjpyOs1gOlV8OwN21JnhyfKbijysBNWkK52GQTV5VKhRMZH lRIfuAdlyXDoG4Hyq7qT/CLNMeG91hbC600spRndlYk3wZ2UGX0MWCIIP+lE84hSGuEPnI Jdk+xtB1O/FoyaQ8rIeh/hjBcg5c3bg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 63D3721191; Thu, 3 Jul 2025 18:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751568879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vzsfFTiRS699y17GeOyLYlzkrCo2oTvb9iPpWQ+lCzs=; b=Xe6qTk/aOmt7XhDBOHrBgT5umTFOZmoWnCdcEC/wmNQwQgan/3rYmR5Xfm6NBOcQk+nvT5 CGHRVZf50jNPGZWt13vBzRNooaTmnSdcCjhNhlsFtF+C8YN1apkTQUp24fgcOxeyCZR9DE WOK/yZmFxAypXFSGyBj+PBBDFe3OPDE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751568879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vzsfFTiRS699y17GeOyLYlzkrCo2oTvb9iPpWQ+lCzs=; b=+ZBLDWh7rdsznQTh7bWUvJ6kgOI2/juBBvMDkELqeHbfzgjw7H9nBz+ziIO1M+B/Jvov1Z 9kDFKZQoj6HJL5Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751568879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vzsfFTiRS699y17GeOyLYlzkrCo2oTvb9iPpWQ+lCzs=; b=Xe6qTk/aOmt7XhDBOHrBgT5umTFOZmoWnCdcEC/wmNQwQgan/3rYmR5Xfm6NBOcQk+nvT5 CGHRVZf50jNPGZWt13vBzRNooaTmnSdcCjhNhlsFtF+C8YN1apkTQUp24fgcOxeyCZR9DE WOK/yZmFxAypXFSGyBj+PBBDFe3OPDE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751568879; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vzsfFTiRS699y17GeOyLYlzkrCo2oTvb9iPpWQ+lCzs=; b=+ZBLDWh7rdsznQTh7bWUvJ6kgOI2/juBBvMDkELqeHbfzgjw7H9nBz+ziIO1M+B/Jvov1Z 9kDFKZQoj6HJL5Dg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E8C3C1368E; Thu, 3 Jul 2025 18:54:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id b9W6Ne7RZmiDNQAAD6G6ig (envelope-from ); Thu, 03 Jul 2025 18:54:38 +0000 Date: Thu, 3 Jul 2025 20:54:37 +0200 From: Oscar Salvador To: Mike Rapoport Cc: Andrew Morton , Alexandre Ghiti , David Hildenbrand , Pratyush Yadav , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 3/3] cma: move memory allocation to a helper function Message-ID: References: <20250703184711.3485940-1-rppt@kernel.org> <20250703184711.3485940-4-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250703184711.3485940-4-rppt@kernel.org> X-Stat-Signature: p3bxj7mce3yk655aeaaw8awfju9n9u8j X-Rspamd-Queue-Id: 07A0B160007 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751568880-310877 X-HE-Meta: U2FsdGVkX1/P/H7xtU4HhYJstNSxDa0etIZh00r1rhinXxrSnj9YbayvWKt1/4ERekY20M23tZyoKZwgXrgTfXbPHg/Hp/1Iuiq+rFvud6u8i9sKEK86PKCMJ/o1m1bjDachA/UlOwSWEGY5Lgzv3FAbcO1Gv+NNWAKWwiexY0Vg3geSmiLKpqtNN7MaqIpmq+s2Kbb+HlIrXGWbyrdOJQoUzVlxY3XHO5h8DpOgWM8gFbLyOLp6s3O7gyTouoVaNNTRTUoZbuPKAYM9IqdKYRP7MDspkj7MtIGfxQokw3kGsKoU54P5hq1SPgZkKpf5OWp4pNL+peTExuMe/QyzNM0HjtEdnFf2MzuePRkDHtsbZLB677R9blKPgK9hWulCvkQEDgOkzW9lHqZq8xxQkOwW6DpzE9tSELcAED3fljLKj/CbOYlolqncrgygjSy2QtfdULfv4PyDVcqAmZ1EE7uYk40ddfYVqN0mFlrpBZV+ampvqSxLmXxCYGDcg5FTyE852R3YYS4A86mnJCr/m1dxLzzZXWtlZ5OKzgESdYexEMkukvdhwD6822kW6B3LAAv3fH6MH1Z+HA/Vx1QQKzNoLbeUEY1hMA+L3HLlxqmeeNRmdZ8N5H4aNvLGAqRaFiG+Ql50DQkTrGLcyYx1WxsjB6YYb5oHvkpssGftXe6emJytLfoEefVIDJ9mmvQwFnjbsROKuZrlsRJPCKQvlRpAmAjOo0f25M05Bmd+jBJ7qWZlKkhnZIZCEVP903qhQ+jV6m6h/VGSGR/kr6Zs54HTlPuMX55Gvj+8eEytNfctbeG0fVCEaOIhOtTScIhC1Lhb0Z1SO6yt6Di9plANs8xd8xO6b9ieoTT0ZOh27TrrWwKs3fm2btoQbBO9G3hRBre+0mosAjAVHOApVJx6LJfuPOscxHzgfjostSoZVJFRP9nWXULNjR25aiIXtEtYSUWKrEH4un6uJQepotH rf5Zsn6C PKOJQzVlcUBIffkQ2PlmUzaoBvObPlwVbsf2GXeOMf3bYEaHizUCvv+ZFQK3Eottx8Bci9CeXXsJaYk6FAaZwxzy7LXvZEAn+1M0oT6jOBXJ5EfZaYi9kz4ZVO6YEO+pgavOmK5rEz4srIm3ri21ZwtaMzlhEBi8nBrsYRM+7bRa8w1h8pawkSF/47xKX9+BpTlfRET18VOe0A9XEVfHHflJ4j9kxR8CF7HhW8BvCHeUSvWjtWgSp5lBOXpPzDiq3w6zt39naSwCGS4EMlcPfmhqnzXRKzJ5eI1WGH0aoiVhTWqg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 03, 2025 at 09:47:11PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > __cma_declare_contiguous_nid() tries to allocate memory in several ways: > * on systems with 64 bit physical address and enough memory it first > attempts to allocate memory just above 4GiB > * if that fails, on systems with HIGHMEM the next attempt is from high > memory > * and at last, if none of the previous attempts succeeded, or was even > tried because of incompatible configuration, the memory is allocated > anywhere within specified limits. > > Move all the allocation logic to a helper function to make these steps more > obvious. > > Signed-off-by: Mike Rapoport (Microsoft) Acked-by: Oscar Salvador Thanks Mike ;-)! -- Oscar Salvador SUSE Labs