From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD67C83F03 for ; Thu, 3 Jul 2025 17:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1CB28E000B; Thu, 3 Jul 2025 13:40:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CDD68E0009; Thu, 3 Jul 2025 13:40:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E2B68E000B; Thu, 3 Jul 2025 13:40:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7DE768E0009 for ; Thu, 3 Jul 2025 13:40:01 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4A6361D4D61 for ; Thu, 3 Jul 2025 17:40:01 +0000 (UTC) X-FDA: 83623666602.03.47182AB Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by imf01.hostedemail.com (Postfix) with ESMTP id 5163E40003 for ; Thu, 3 Jul 2025 17:39:59 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; spf=pass (imf01.hostedemail.com: domain of cb@df7cb.de designates 80.241.56.161 as permitted sender) smtp.mailfrom=cb@df7cb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751564399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m/W3rnfu8sKt0vCY96im8ljRGveQocMntcNCEoCe4SY=; b=GbZ9sgBuxHWefaf71gH2Agzc3XHyL9E74ToIwml+6xmu0s0jEb+4dTnj7RGoQN+qotVhS6 KTOffGkRt9PLymclaObTiA319yGQCVkI2qrf4GQQ0SnRp3glB0iELIlIekrLdJkTHlAzWs y3SJoZqSRnBvQLybSPP474RCw19rpPQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of cb@df7cb.de designates 80.241.56.161 as permitted sender) smtp.mailfrom=cb@df7cb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751564399; a=rsa-sha256; cv=none; b=UMi6v8Az62r1oYzaanh5MeWo/y/IM6t4r0JfwPc1VDw1lKvKcCoi9WQ+pw3UyiuzPajDW+ LKjx+vVwExCiD9adVjH0scYoEjELR0D8FhNGt0vIDWOyQY0EVV/26gX1Fy8nmqXKRjdKGu BmGKy/9Q80QTkaFmEETcOoTFS0jn3fc= Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4bY3tf5XyCz9shX; Thu, 3 Jul 2025 19:39:54 +0200 (CEST) Date: Thu, 3 Jul 2025 19:39:50 +0200 From: Christoph Berg To: David Hildenbrand Cc: Zi Yan , Andrew Morton , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "open list:MEMORY MANAGEMENT - MEMORY POLICY AND MIGRATION" , open list Subject: Re: [PATCH v3] mm/migrate: Fix do_pages_stat in 32-bit mode Message-ID: References: <25EB3C6C-4D6D-4946-BF0B-9B322E7DC16D@nvidia.com> <069a44c4-754e-41b7-9a42-7c2b77afdd37@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <069a44c4-754e-41b7-9a42-7c2b77afdd37@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5163E40003 X-Stat-Signature: gh7cmcj8jzuyomi8ytww3osrhxgwfixs X-HE-Tag: 1751564399-768246 X-HE-Meta: U2FsdGVkX19j/RNrwNrnKBIoqjsDWG90peDhXH7qlznWH6thwKwqYDvP8T28L+TkOk+5121oyKg07BKJsByCGQ99kgM+u/1v3jSfiaQbA33ajrrAFq0YR4x3qr6ESKe55wwyovK3UbiLIB+hl1Y5eoYWd3CWS2Ww3JskTb/DObY/ExjFY8HRJeqBQn3fRPaAGbYuMIqkm0cwJ+dvAIc6DumWV6Jnj7XLISGR+AUaoDI251ufu/z2zXnQqeyBiURzmoZAZ9uPXvwIlfG+q/PQnhxe4ToAsv5a0QvDZowjp+IksI9W/S6rSJQAYUpMMKNDhI4Kyen9tVFI5g4dTeR00ZfOgRAvbrxVaWn1YOC57/e32OZ+kj0H6EiD1nAbS7oaQ9IBAVHQczMrmuEvKEz81w70fXnSYxw2BmugPAzpie93T/M/ynJaSUgwZbaJCdrwVIdnAQI9ecyEC3FApQVK8jYUDc7rVie4ViqTDWBwvbTlACKWqGOGDV95ww9gx2b2u0FewmEPhj0E7aW9QOCDxlsQVly97l3C4agygDppSb7PstiO52j3fzY2aakwGyz2EnxIhnu9npVza/sRceTX6a3O3USSRVoz3jxV7Fdbwc2FwxHXzP9hWq2PqKVRNJ8zQyGB5lfuvba0SHqWi6cLG7lgQ7E1PA2x8v/KH6pBpvRTu82VY4cZ/UwyR1T6wUrk0c/aXVhILA1DkRP77/cH0F8T2WXXvksM2+VGBrT2aMbAgNI/hqCMSv95ornIePJgmgnEphld3nht99/h8TiRl7eomqbe2fxu9jB8KO6m2XJCpwtQd3Bwq6BDHtoVCAPMq74YM4JCI80CzA/b/FhU1ax5897rtBb48Eb0L6b6XK9ybWtR3RtN6wLI9ECcVt8LDyg0hX7TA8Gdp+XFoRTsJa1qFfV308xY+bdmqMUb6ZDDNyE54TRQvNizPr+adCiAWwHWnsq6q2iP2etxyP4 Z8GIl/qI iftRNcuesUxta1+tjAI9+RtHEaweJh7NWDDhcEuWq04YLzejCNEmkdZxpOcRbaoSG541DEXN77m7oRiTDCdCaSdoJk7BG76HDwHFhs+vjZ1KOYmO6zUzOPVcEKUVoHdj0NCCBOXYNrSgYWXzCur3Bc1KvlZKvL9pUJPit0RfH7N86nmTHNbhCgN4IV+ARu0+pn9nNu+8rduyY/ZBpPH8nH8XERaRl8ckQrr/eV2vtTTrAveQG9UeodyzeGe3mop84Wq3QtEOK8JezZ5KXZZSz9fUhYCOXJVVLYkOyZf7NJSDu9MMM5ygWndEqZUiNuh7JHilPQRqFsYhm55U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Re: David Hildenbrand > > For arrays with more than 16 entries, the old code would incorrectly > > advance the pages pointer by 16 words instead of 16 compat_uptr_t. > > Fix by doing the pointer arithmetic inside get_compat_pages_array where > > pages32 is already a correctly-typed pointer. > > > > Discovered while working on PostgreSQL 18's new NUMA introspection code. > > > > Signed-off-by: Christoph Berg > > Suggested-by: David Hildenbrand > > Fixes: 5b1b561ba73c ("mm: simplify compat_sys_move_pages") > > Hmm, still not sure if 5b1b561ba73c really introduced the issue. I think it > only messed with the "pages" pointer, not with the "status" pointer? "pages" was the broken one. "status" isn't affected by compat mode. > Acked-by: David Hildenbrand Thanks! Christoph