From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABC2C77B7C for ; Thu, 3 Jul 2025 11:52:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 090766B0178; Thu, 3 Jul 2025 07:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 041516B0179; Thu, 3 Jul 2025 07:52:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC05F6B017A; Thu, 3 Jul 2025 07:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DBC5C6B0178 for ; Thu, 3 Jul 2025 07:52:01 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8E500160169 for ; Thu, 3 Jul 2025 11:52:01 +0000 (UTC) X-FDA: 83622789642.18.5730740 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id EF39C4000C for ; Thu, 3 Jul 2025 11:51:59 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SqV3PAE8 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751543520; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8gqGNwk/aw7AQQO1FQ5aal4TZwL9ZOxfu4GeW6fMYeI=; b=D6y7H93Ai92Kuakq+Px3fDbghbAFBVNWN60b9ZIRMfGomAGoruosarjPAhqsFbEm3nU2Zm SkXZn1Yd9sphPGUePZOuEPxc25+Jhgt4QLDodXZa5ucpNO0Fq6Kx1MWK50dAoDmmBxvvI3 RAkL+FRVKrxzFGJa/GM0N/eaPKx6vYs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751543520; a=rsa-sha256; cv=none; b=XW5efhtkXhxWUE+orwP+JzihRL56Pua2zESteF6DqXTCoQgyfDVhhBksJElCfetaFavYzf seMfYXteZGev3HYdrfqoaOOC6Ful7iRw9b5RWtabpZWD2CAaDvAIwSNhpEHtSuIUCD7sf2 Y7x5EAqoOCwQnvRacW9UC8RXcadT/ps= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=SqV3PAE8; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8gqGNwk/aw7AQQO1FQ5aal4TZwL9ZOxfu4GeW6fMYeI=; b=SqV3PAE8kH+D1aRh0FKA6O+5jX aWz1ZZWlgIDG6TDmz8X5GWUOP1BF07togfdxtC2GX2hZsEV4l4+F4ldTs7qd3kM2dm9vsSO4JpuZg OBmdQ2BH6Z8+6u0qk8SaegJKcZlQXTVh2m0ietCdhI2iWFV1T7ZSVDe+jNfCgsFgmBdfGAf+QlXUX FwyW3WhCd9Z9uO2VRBF7yQx9TRiFkTKVjWRxmwXedfN6agug2TUVP+JaCNyBUqiyPdHyhZaLRbpyw O1GR0HzB+XLuop2WshkGAV2yPh7W99E2i4/f2bxkRxAn4eQiQJ5TrJTfSrkmHpMN3o6NZtTjaYtb6 fYe5r84g==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uXITt-0000000CxVg-1zcj; Thu, 03 Jul 2025 11:51:57 +0000 Date: Thu, 3 Jul 2025 12:51:57 +0100 From: Matthew Wilcox To: Al Viro Cc: Greg Kroah-Hartman , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/11] vmscan: don't bother with debugfs_real_fops() Message-ID: References: <20250702211305.GE1880847@ZenIV> <20250702211408.GA3406663@ZenIV> <20250702211739.GE3406663@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702211739.GE3406663@ZenIV> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EF39C4000C X-Stat-Signature: w6k4i9jifsnxq8jdhiqo8cn4fj5rbg4p X-HE-Tag: 1751543519-220843 X-HE-Meta: U2FsdGVkX185vm99mW4x7Yy07vEBgiHxLDvUDFtHf19vGJ+SYhIoD+glI66v0IqFKMlPd70v7Ju9GdA/KBEVRsddwmF/huE/K0uAfxTdC9oo45oYxPK9/dHQOys7C5m8roq8cLf1LNnbKL/cAzV1uz8D92Ew56CfsNJ+dOpUm6SUqL95P0SLA/mCJP4N7qV8QnZeVN+qVtVejYh7uq94xr91Y3IK5SAv2x0P8jJZt/TFkdFquNg+3bdG/P6amcc9o8T64+aN8KMgLNNes47xiyGQOL20EGfNC5bR76o7feijO8vpmDgT0ZIpmNlamOk2K+bXZagp3Q1vWIJ0uqVGancnAwKQtqe3KfII+tBPJ4Lztq4/+AbVjYqfQxwKDcSTdF4RB12NQBW/YeiVVznOMGLdDaBma15zMJ2pnpo/gSTIySon6u5QRkrltJESDbSXixsaSMaJxBkeHfVZJK+SlxbBXvshgQkyouPfwfQQ+k2H7KRqR1Mjk7221vzD/wBIjYTAoLwu55cUQ//5So6FNkNUl4gA3na5mR4qsvXM2mh/r05O1aBoAyicys5GneuPpunstsTp5+0ixpDK9vNPOn4scJUkrZM+4DI5UOlLfhPRoMuLQf4s07ZGWpYFtjD6oGEhomLXJMK9TSgVq2yY8lJzg0EyPhZLGdxVuriItaKCyKwKWWX+rwLKyjLwcYyMC6FlbHvClzxIrSGoOjuPIyJ2ZjtEKRoPWlDJ6GhTLcy6aCBl3P0kFqkZcVN29xPDKzZBfCBQbc3dfuYPdENRgSxiI1kCETC9DX9UGphhSTFSymh54EkY/c3UPjORsfQgSsYBI7KJ5uRap2sM9/4M63PYu+eupm9TqoGxuvo7EezY5pCmIgkNCye/AoCDz7lTh8yGdlKNULfbgk25Vd1kfHJm0DCUSssd3v3Av67+rHs2UASC7VMSUFOr+6CxqqIQPDexpIhuR7CcBgnoi8K ocHPxjGp wA+1gvG9NXVX5Qij/SgBvGNLwk5mCnC8a4eso9Po8PZcopokJ0kN4h5BP/bbLLzsXotR/ORDi5qA77dAY/4a1xHiczfeFC0z+BGmtZH1DxNCjPrn304It/vY9ATWdoOmJFwgN2k0/l8ERa49Su9Y8nQVhhg9wZJlPvcKflvrg1jep8+Ace/XYUk18HSzNDTyys3w7AOlOhr35/lija6X7aENOJVI/l3nQWrAS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 02, 2025 at 10:17:39PM +0100, Al Viro wrote: > - bool full = !debugfs_real_fops(m->file)->write; > + bool full = debugfs_get_aux_num(m->file); > + debugfs_create_file_aux_num("lru_gen", 0644, NULL, NULL, 1, > + &lru_gen_rw_fops); > + debugfs_create_file_aux_num("lru_gen_full", 0444, NULL, NULL, 0, > + &lru_gen_ro_fops); Looks like you have the polarity inverted there?